From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D70AD44F2A for ; Fri, 9 Dec 2022 15:52:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7D4C668BD03; Fri, 9 Dec 2022 17:52:13 +0200 (EET) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9CABD68BA30 for ; Fri, 9 Dec 2022 17:52:07 +0200 (EET) Received: by mail-wm1-f44.google.com with SMTP id o15so127004wmr.4 for ; Fri, 09 Dec 2022 07:52:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=MAp2OyIVCPSJNozQ4i/T14H2+3il4UfeMbvDvm7ivn4=; b=lOlaIMY+MysWpitFwF9azpi9zZF3rb2YG5sAtztA70dNBJfGEfGz8kRFp2nFTs5HHX IJnVmP39hyf3JBDcWMXopncVQ/ZP3c3H4tlwOjaB99WwHiDl0TRENxVYMo2VR4gSinad NYfDfR23vAhKea5BLpdj8FHKtpCszE65wDSwrjkgu9oU4VtYkn2nP7PLsumIQPO0MeFy YygHu39XyoiKzbhnXn3D7Y0Kpt/eWE1SllxxVw8Op3ixgAQnqcB97b1XcBvf1lU0IFPw GPp5ytyO+zDW9FrxwAQvsZkhkuNLUxOoqycyD8EK7m9Q/WAMyfSnDIhllKH70orS2Ye0 /EBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=MAp2OyIVCPSJNozQ4i/T14H2+3il4UfeMbvDvm7ivn4=; b=JrKSz5XADQPymqHTl/el4t0UuwhO4RNu9VblHy9MUGh8eU4YcoyR9ThCWWVDyVES5z R0+LDHwSBjibEwkcrmcCtsnrKNWe9P24kqwf7sCCc7H6eCneTiSTQgSiU/sddT/XNkzV ggMEamMcDWCwxoyysArckfWBchvEufi1RSk/MGf7hC65iPX9yJgjmmovyszgGKP/Pmv+ 9fC+JN8QGZnGgEeCblkYbW2/MqWmhxN2rl2u6LB0NMunWnfa3ON4gxXmCFa4WYKdGAYz NHRDwDpFyJrPIWvrK2R8f8StHvQ6GQ/t8bphR0Mj3yRyqDenKSgT+HOMM8XQU/xkHRKn z1ag== X-Gm-Message-State: ANoB5pnsGVCyJFg4+9F4CtfxditU08NgiUWTViZPxvwnLDWbRyvhibjh Zr0D/XCznffkQ6xYYfjUpVLpoEy2xcc= X-Google-Smtp-Source: AA0mqf7YeLv2WNZHVpq2+cGrT6dw6ig8EfLlEo3cL+3uth5fjdI/snha2RFxMZYqoP7UjmbBp8aV1g== X-Received: by 2002:a1c:f210:0:b0:3d0:4993:d45b with SMTP id s16-20020a1cf210000000b003d04993d45bmr5166793wmc.4.1670601126795; Fri, 09 Dec 2022 07:52:06 -0800 (PST) Received: from [192.168.1.106] (33bf3096.skybroadband.com. [51.191.48.150]) by smtp.googlemail.com with ESMTPSA id k25-20020a7bc419000000b003cf483ee8e0sm111975wmi.24.2022.12.09.07.52.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Dec 2022 07:52:06 -0800 (PST) Message-ID: <48b7be12-0fba-823e-f632-70ca0fa310b8@gmail.com> Date: Fri, 9 Dec 2022 15:52:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 To: ffmpeg-devel@ffmpeg.org References: <20221209154055.21165-1-derek.buitenhuis@gmail.com> From: Derek Buitenhuis In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avformat: Rename IPFS to IPFS gateway X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/9/2022 3:45 PM, Nicolas George wrote: >> -static int ipfs_read(URLContext *h, unsigned char *buf, int size) >> +static int ipfs_gateway_read(URLContext *h, unsigned char *buf, int size) > > There is no need to rename local symbols. My intent was to rename in case we ever got an actual IPFS implementation, but I have no strong opinion on whether to keep this part of the patch or not. >> +const URLProtocol ff_ipfs_gateway_protocol = { >> + .name = "ipfs_gateway", > > It is a bit of a mouthful. Maybe "ipfsgw"? My personal preference is verbosity here, but it's not a strong preference. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".