From: Derek Buitenhuis <derek.buitenhuis@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat: Rename IPFS to IPFS gateway
Date: Fri, 9 Dec 2022 15:52:05 +0000
Message-ID: <48b7be12-0fba-823e-f632-70ca0fa310b8@gmail.com> (raw)
In-Reply-To: <Y5NYFzM+vebVpLru@phare.normalesup.org>
On 12/9/2022 3:45 PM, Nicolas George wrote:
>> -static int ipfs_read(URLContext *h, unsigned char *buf, int size)
>> +static int ipfs_gateway_read(URLContext *h, unsigned char *buf, int size)
>
> There is no need to rename local symbols.
My intent was to rename in case we ever got an actual IPFS implementation,
but I have no strong opinion on whether to keep this part of the patch or
not.
>> +const URLProtocol ff_ipfs_gateway_protocol = {
>> + .name = "ipfs_gateway",
>
> It is a bit of a mouthful. Maybe "ipfsgw"?
My personal preference is verbosity here, but it's not a strong preference.
- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-09 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 15:40 Derek Buitenhuis
2022-12-09 15:45 ` Nicolas George
2022-12-09 15:52 ` Derek Buitenhuis [this message]
2022-12-09 15:53 ` Nicolas George
2022-12-12 15:48 ` Tomas Härdin
2022-12-13 12:44 ` Derek Buitenhuis
2022-12-13 12:48 ` Derek Buitenhuis
2022-12-14 17:34 ` Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48b7be12-0fba-823e-f632-70ca0fa310b8@gmail.com \
--to=derek.buitenhuis@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git