Re: [FFmpeg-devel] [PATCH] ffmpeg: document -d option

[Gyan Doshi <ffmpeg@gyani.pro>]

On 2022-04-03 08:57 pm, Stefano Sabatini wrote:
> Option was added in commit 39aafa5ee90e10382e.
>
> Fix trac issue: http://trac.ffmpeg.org/ticket/1698
> ---
>   doc/ffmpeg.texi      | 12 ++++++++++++
>   fftools/ffmpeg_opt.c |  3 +++
>   2 files changed, 15 insertions(+)
>
> diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
> index 164419cad3..bf738da0c1 100644
> --- a/doc/ffmpeg.texi
> +++ b/doc/ffmpeg.texi
> @@ -845,6 +845,18 @@ ffmpeg -dump_attachment:t "" -i INPUT
>   Technical note -- attachments are implemented as codec extradata, so this
>   option can actually be used to extract extradata from any stream, not just
>   attachments.
> +
> +@item -d (@emph{global})
> +
> +Run ffmpeg in daemon mode. This options should be only specified as fist option,

s/fist/first

> +or it will be ignored, for example as:
> +@example
> +ffmpeg -d ...
> +@end example
> +
> +This option disables log and detaches the @code{ffmpeg} process from the
> +terminal.
> +
>   @end table
>   
>   @section Video Options
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 22c88287df..e3c93d1980 100644
> --- a/fftools/ffmpeg_opt.c
> +++ b/fftools/ffmpeg_opt.c
> @@ -186,6 +186,7 @@ static int ignore_unknown_streams = 0;
>   static int copy_unknown_streams = 0;
>   static int recast_media = 0;
>   static int find_stream_info = 1;
> +static int daemon = 0;
>   
>   static void uninit_options(OptionsContext *o)
>   {
> @@ -3713,6 +3714,8 @@ const OptionDef options[] = {
>       { "bits_per_raw_sample", OPT_INT | HAS_ARG | OPT_EXPERT | OPT_SPEC | OPT_OUTPUT,
>           { .off = OFFSET(bits_per_raw_sample) },
>           "set the number of bits per raw sample", "number" },
> +    { "d",             OPT_BOOL | OPT_EXPERT,                       { &daemon },
> +        "run in daemon mode, can only be specified as first option" },

If you're going to add this, might as well use the var instead of 
strcmp(argv[1]) and remove the positional constraint.

Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".