From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 33B124C9F2 for ; Sun, 11 Aug 2024 18:42:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B52668D9EA; Sun, 11 Aug 2024 21:42:14 +0300 (EEST) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 022FC68D981 for ; Sun, 11 Aug 2024 21:42:08 +0300 (EEST) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-428e0d18666so26699555e9.3 for ; Sun, 11 Aug 2024 11:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1723401727; x=1724006527; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mvWaj7hnBt84zBt/KlscPJ2jxb4OnAvbNL30nIfkB1g=; b=KG0jZ/DVMf0h7Az8TJNxpNXD80LCSP5nmYcrr9uLvwiaQubKQb7aGYGim/UZgtO3pd 8DXA2cHB+zJCdrKCiEEr1uqDJW2lLtTwUaFhrUvMzbJtg3PVvYWJ6C0EItYeEJHer9Nk kLSZqqERxP/XuB0ZIDjxqabLUgfuxVDlAFNPpxSljvQ5wCte/a1iSbjGXt44NsXAnwpy Sgm1qoxLKQ01PfozXnT9oAzv9fV01ZPjmGJUQkZzR1j7k4+1HPDeexF0ViydS2XZE1Sp LuUkz/xix5z2+7srEAxjbeQJKbniHm4S+WzqOrKOQWAKFHlS5U+2WEgBBlGOXX9G3hMn kwNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723401727; x=1724006527; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mvWaj7hnBt84zBt/KlscPJ2jxb4OnAvbNL30nIfkB1g=; b=Huyt7+hmSOD5RuEoXGqfsaSug/t6NHI+1CJI8BpQwhVIY4oYJEoeCfFCsprtAkwu0f lpToRP6n6jpuTGvcTxckslTCQ44etfS02DO6pDVXDzQ1G0seaY7oi4HgHax+MaksdWMq c7wXs4//GIV/qSDh36ucF4+LM2WSDKr1j6Gj2bZd/rcqFHCQVk9TSNzGgSjtxYZ4+aSU meYBr5hnFZ8wfVplOTy8f+smWVvdEXrneBXtAMTzuDkBgvWTiTw0HeQPHe0ec+7+eMHD /Trd+k4i8v0aeQFyA4AILLzVChu9ZOhBSeIJa52AbjETQuGCwZkpqznhTzrnrgNUe+Sr V9iw== X-Gm-Message-State: AOJu0YyoW/0vt6eWz8dmUH7N5BssJtqUGIATIJT7IeROSj5i+s42ruxs BRzorjYa2GBYhjAB4gV5L5q3vFwbA9zmT1kWG3a6updkMFUej+sxBpyCug8N1keVFTjILkpfNtl b X-Google-Smtp-Source: AGHT+IGCQfZkS+Zs72us4rTw0Tbvai2ZIR6nw7L/e9HZkcAwaLj6G1ew40SKM0HBnV2FVG5OpZmx/w== X-Received: by 2002:adf:a44f:0:b0:368:4492:eca9 with SMTP id ffacd0b85a97d-36d5e3c1cd6mr5654907f8f.20.1723401726448; Sun, 11 Aug 2024 11:42:06 -0700 (PDT) Received: from [192.168.0.15] (cpc92320-cmbg19-2-0-cust955.5-4.cable.virginm.net. [82.13.67.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429c7734595sm73893935e9.36.2024.08.11.11.42.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Aug 2024 11:42:06 -0700 (PDT) Message-ID: <489567c4-4149-451c-a479-b9a7c604e65d@jkqxz.net> Date: Sun, 11 Aug 2024 19:42:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Mark Thompson To: ffmpeg-devel@ffmpeg.org References: <20240730200235.1828384-1-David.Wu3@amd.com> In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1_vaapi: Enable AV1Profile2 VAAPI support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/08/2024 19:27, Mark Thompson wrote: > On 30/07/2024 21:02, David (Ming Qiang) Wu via ffmpeg-devel wrote: >> AV1Profile2 VAAPI is supported and tested on AMD VCN5. >> >> Signed-off-by: David (Ming Qiang) Wu >> --- >> libavcodec/av1dec.c | 3 +++ >> libavcodec/vaapi_decode.c | 3 +++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c >> index 1d5b9ef4f4..77f63661a0 100644 >> --- a/libavcodec/av1dec.c >> +++ b/libavcodec/av1dec.c >> @@ -599,6 +599,9 @@ static int get_pixel_format(AVCodecContext *avctx) >> case AV_PIX_FMT_YUV420P12: >> #if CONFIG_AV1_VULKAN_HWACCEL >> *fmtp++ = AV_PIX_FMT_VULKAN; >> +#endif >> +#if CONFIG_AV1_VAAPI_HWACCEL >> + *fmtp++ = AV_PIX_FMT_VAAPI; >> #endif >> break; >> case AV_PIX_FMT_YUV422P: >> diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c >> index a59194340f..a077e47326 100644 >> --- a/libavcodec/vaapi_decode.c >> +++ b/libavcodec/vaapi_decode.c >> @@ -448,6 +448,9 @@ static const struct { >> MAP(AV1, AV1_MAIN, AV1Profile0), >> MAP(AV1, AV1_HIGH, AV1Profile1), >> #endif >> +#if VA_CHECK_VERSION(1, 23, 0) >> + MAP(AV1, AV1_PROFESSIONAL, AV1Profile2), >> +#endif >> >> #undef MAP >> }; > > Based on this is supporting profile 2 only for 4:2:0 12-bit, and therefore can't advertise profile 2 generally for the decoder because that would imply support for all 4:2:2 and 4:4:4 cases as well. > > I think this wants something added to VAAPI in order to be able to advertise partial support for a profile? > > (It would be very confusing if we got "AV1Profile2" in VAAPI meaning only 4:2:0 12-bit and then have to add a separate "AV1Profile2exceptreallythistime" to meant actual AV1 profile 2.) I commented in . Please fix this before it get further in Mesa, having a version reporting incorrect decoder capabilities which we need to hack around elsewhere would be non-ideal. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".