From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ACA0843CE8 for ; Sun, 4 Jun 2023 14:34:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23EA068C3BC; Sun, 4 Jun 2023 17:34:29 +0300 (EEST) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1E5C868C1EE for ; Sun, 4 Jun 2023 17:34:23 +0300 (EEST) Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-973f8dbcc02so646967666b.3 for ; Sun, 04 Jun 2023 07:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685889262; x=1688481262; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=z32w5qSHOnQ/gp7AGSataEQNWeDhgFGghFAt1ATwunM=; b=TL7TAuAL1omdg7xR3se9AxJOMJrZ73K7nrNO0nzvtwhveTQZsZxOofOf7IJuKg7G2c DTAXbt1/m7ZfOsaveEK0B4LwaIXJKeAR/vWexHET+6igxAJxh53kQLSnxemaE9thHXM3 ltU36+QometQIiAyR7UXj46OW7RsGAFyNsunj5af070JsNZaj0nYFLVf6ko2DTo3bpEM tzMmLPAk8wULBMUOuJ9rdiBEg+L2aiWmZccddb1+1OCj/91AL9TQ3rg8Sx1N+XOQt7OS uSkkl9dfqzbvLacHVudmox90pz0wjkdb7x4kRT3gA2mktkSEG7R8pGOWZnlRZ8bSwQUo Neiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685889262; x=1688481262; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z32w5qSHOnQ/gp7AGSataEQNWeDhgFGghFAt1ATwunM=; b=PvOD2i4skr/cFpP1DqD/zDfOvKFBhCms+5znHtS9+keBzhzTNNZE3C3JsPnUJYWL9Z R8/eaHU+gkt+Ckq3Z325KGNPPMjL5za1XjAZOFgKb3uQr0cE5KCukhwk7pMHWU8W+I6H XUPHUj+rC/TTba5zn9fqYsbFX5lag5zHWG/O+t0+EN3XwP8FKz/g+ZQbmGfpJcIe2598 OPpwEAbG6ThF8pDwB728s/QNNCpyhKVbvqfbnO6lXc6QbmGuK1jOH3oUI0ABPJEUczMN AV0/1U+YtTM04cskDOb84yxbOX2KigJhfGeHWgrl4Aj24eBkWWyyzmIENg5UhxX9YRzk sRBg== X-Gm-Message-State: AC+VfDyOGe1KkNWaFhFQHpaw2TBk9V5Evw5ubkHCfgCMznuRxGAqCxoi 6sSSukS0922vbSyj9V/IooK5KaTyB4k= X-Google-Smtp-Source: ACHHUZ5lqk6MJwg94xGZTw+NXkU43+3fJjKCd4BrADoDduoMiI7H8ejvPB25OWn2ME0B7CmGQgdDBw== X-Received: by 2002:a17:907:3d8c:b0:94e:4489:f24d with SMTP id he12-20020a1709073d8c00b0094e4489f24dmr4680948ejc.61.1685889262283; Sun, 04 Jun 2023 07:34:22 -0700 (PDT) Received: from [192.168.178.30] (dynamic-2a02-3100-10ff-2100-e858-cc8c-f503-298c.310.pool.telefonica.de. [2a02:3100:10ff:2100:e858:cc8c:f503:298c]) by smtp.gmail.com with ESMTPSA id s7-20020a1709067b8700b0096f7e6d0063sm3112273ejo.75.2023.06.04.07.34.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jun 2023 07:34:21 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Sun, 04 Jun 2023 16:34:20 +0200 X-Mailer: MailMate (1.14r5964) Message-ID: <47F94F3B-C372-4150-85C3-044082905B27@gmail.com> In-Reply-To: <20230604142540.GA4274@mariano> References: <20230501114456.13898-1-epirat07@gmail.com> <20230521235235.GC14958@mariano> <8CA999C7-1502-4FAB-ACD9-9BC02ED68058@gmail.com> <20230526060544.GB3241@mariano> <20230604142540.GA4274@mariano> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4 Jun 2023, at 16:25, Stefano Sabatini wrote: > On date Friday 2023-05-26 11:11:48 +0200, Marvin Scholz wrote: >> On 26 May 2023, at 8:05, Stefano Sabatini wrote: >> >>> On date Monday 2023-05-22 11:23:24 +0200, Marvin Scholz wrote: >>>> On 22 May 2023, at 1:52, Stefano Sabatini wrote: > [...] >>> Should we also support the case with multiple same-key values? >> >> I don't see what could be improved there. You just call it multiple times, >> or what do you mean? >>> > >>> Also maybe we should mention that this operation might alterate the >>> order of the entries (unless we add a new flag to shift the >>> trailing data when an entry is removed). >> > >> We currently IIRC nowhere give guarantees on the order of items in the >> dict, which we probably should keep that way especially in regards to >> your next point. > > OK, anyway this is pretty unrelated to the current patch (might be > done as a followup). I was checking the current documentation and it's > missing some important information (I'll try to send a patch to fix > that later). > > [...] > > About your patch, please mention that the pop operation is > destructive. We probably want to make that behavior configurable > through flags, but I'm fine to keep the current behavior for > consistency with the set(NULL) operation. What do you mean by "destructive"? > > [...] > > Thanks (sorry again for the slow reply). > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".