From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org, Scott Theisen <scott.the.elm@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] lavc: export flag for MPEG audio dual channel
Date: Wed, 21 Sep 2022 22:44:51 +0300
Message-ID: <4768603.31r3eYUQgx@basile.remlab.net> (raw)
In-Reply-To: <20220921192611.3241-1-scott.the.elm@gmail.com>
Le keskiviikkona 21. syyskuuta 2022, 22.26.11 EEST Scott Theisen a écrit :
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 7db5d1b1c5..bcf3a845a8 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -2076,6 +2076,17 @@ typedef struct AVCodecContext {
> * The decoder can then override during decoding as needed.
> */
> AVChannelLayout ch_layout;
> +
> + /**
> + * Audio only. This flag is set when MPEG audio mode dual channel has
> been detected. + * This signals that the audio is two independent mono
> channels. + *
> + * 0 normally, 1 if dual channel flag is set.
> + *
> + * - encoding: currently unused (functionally equivalent to stereo,
> patch welcome) + * - decoding: set by lavc
> + */
> + int mpeg_audio_mode_dual_channel;
> } AVCodecContext;
I agree that the dual mono flag should be exposed to the application somehow,
but isn't this a slient ABI break?
--
Rémi Denis-Courmont
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-21 19:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 19:26 Scott Theisen
2022-09-21 19:44 ` Rémi Denis-Courmont [this message]
2022-09-21 19:51 ` James Almer
2022-09-22 1:04 ` Scott Theisen
2022-09-22 12:43 ` Anton Khirnov
2022-09-22 20:02 ` Scott Theisen
2022-09-21 19:51 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4768603.31r3eYUQgx@basile.remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=scott.the.elm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git