From: Andreas Rheinhardt <ffmpegagent-at-gmail.com@ffmpeg.org> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH 2/4] avcodec/opus/dec: Remove unused parameters Date: Fri, 04 Jul 2025 10:35:19 +0000 Message-ID: <476172932909fd45bdb96fb3cc3ed48c3a33006a.1751625321.git.ffmpegagent@gmail.com> (raw) In-Reply-To: <pull.105.ffstaging.FFmpeg.1751625321.ffmpegagent@gmail.com> From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> The parameters here are not only unused, but buf_size's value is actually wrong when flushing (it comes from the subpacket of the last packet sent and is therefore outdated). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavcodec/opus/dec.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/opus/dec.c b/libavcodec/opus/dec.c index a43146c82c..05f7a12d8e 100644 --- a/libavcodec/opus/dec.c +++ b/libavcodec/opus/dec.c @@ -393,9 +393,7 @@ static int opus_decode_frame(OpusStreamContext *s, const uint8_t *data, int size return samples; } -static int opus_decode_subpacket(OpusStreamContext *s, - const uint8_t *buf, int buf_size, - int nb_samples) +static int opus_decode_subpacket(OpusStreamContext *s, const uint8_t *buf) { int output_samples = 0; int flush_needed = 0; @@ -581,8 +579,7 @@ static int opus_decode_packet(AVCodecContext *avctx, AVFrame *frame, s->silk_samplerate = get_silk_samplerate(s->packet.config); } - ret = opus_decode_subpacket(&c->streams[i], buf, s->packet.data_size, - coded_samples); + ret = opus_decode_subpacket(&c->streams[i], buf); if (ret < 0) return ret; s->decoded_samples = ret; -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-07-04 10:36 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-07-04 10:35 [FFmpeg-devel] [PATCH 0/4] Opus ffmpegagent 2025-07-04 10:35 ` [FFmpeg-devel] [PATCH 1/4] avcodec/opus/dec: Don't use outdated size Andreas Rheinhardt 2025-07-04 10:35 ` Andreas Rheinhardt [this message] 2025-07-04 10:35 ` [FFmpeg-devel] [PATCH 3/4] avcodec/opus/dec: Don't call function multiple times in FFMAX Andreas Rheinhardt 2025-07-04 10:35 ` [FFmpeg-devel] [PATCH 4/4] avcodec/opus/dec: Simplify resetting AVAudioFifo Andreas Rheinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=476172932909fd45bdb96fb3cc3ed48c3a33006a.1751625321.git.ffmpegagent@gmail.com \ --to=ffmpegagent-at-gmail.com@ffmpeg.org \ --cc=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git