From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 80F4744E2C for ; Tue, 28 Feb 2023 00:07:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9CA6268A0F0; Tue, 28 Feb 2023 02:07:38 +0200 (EET) Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 35DF06809C6 for ; Tue, 28 Feb 2023 02:07:32 +0200 (EET) Received: by mail-il1-f176.google.com with SMTP id l2so5346432ilg.7 for ; Mon, 27 Feb 2023 16:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rcombs.me; s=google; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=HIsH1NzVAUue6QqhSGckA286dPYQmd77ceWN51dgqEw=; b=PGuA5dVxSWGzf9g+kDrpbGbBxMe5Iw1qc1hxjs5lk1rzXXNOg/ZGU4uCHqwOMESeLZ vMZiy4/ypAzJfyux4Rpq8WOQi6qcHlxgaTakkQPk2O+yKQ6+feYLPE06SvikiCD2DIVF LPW2Anv5IX2csaCH+pw3TkaqnEGg2Ueso5AMT4bJnvNgtFG2l/CnonL3MHMREo7hrCod p2jzf52xOCeRCgbos91/vw1YCCYWzf1gN25af4g/+NJHPdDWsVjJxHz2elc0CfMrtUkI XAmc7YFVRrL3AG2nz0nqj25PoEcZnQy363waqBY1NqnUk9lcP+ro0XXPfEd6Kz5I73kJ ojFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HIsH1NzVAUue6QqhSGckA286dPYQmd77ceWN51dgqEw=; b=0jFGUrPXR4Aiv5ZZb/uqoai/nI3WqlxorX4Rm+OSpjXq609fv9lLyrTpVM2dKeC9vQ f0TEPlItAB8FqIz2yRqdjutVy9tY2terio335b14j+Q4FkAYHjo6hupBht8HULEvy8TD TBPMUq7UpK8935jcEhMjeZFRq533tE1dIQ/ficbwjPcvMnpHmCqVznK7Ga0SWBUGWBpD ZLpRIQzqsaM+PnQVPgUGr3AP8Je4l35N+kVpvBRiX6eoDX0AMwav/wwrjl6U0eefbaJI VSKPPK8IR0ZDFXqw5A3S/z0u/LqbA86xi3Yy4aLu848cHDUouwHz/bBpx+PqeMJiU7m6 tzDQ== X-Gm-Message-State: AO0yUKWanEUes8HXNoVkTq5ydJ37SVGkMihpZamnIsyVmTh6eQzrBeCA VZmeox8+rYbfj5m1WSWwfkog6uEIMkQ8jABRTQ== X-Google-Smtp-Source: AK7set+ox/FTBGKj7t+Rsmp1Sfi5PEfr/jE+IyI1fFDw0CTfXWcfdn3ksHBtXBs8XBNYOt0AYtlaSQ== X-Received: by 2002:a05:6e02:1aa1:b0:315:8bc0:1d85 with SMTP id l1-20020a056e021aa100b003158bc01d85mr1219762ilv.11.1677542850103; Mon, 27 Feb 2023 16:07:30 -0800 (PST) Received: from smtpclient.apple ([2601:243:2000:5ac:a8bf:22bb:add8:351e]) by smtp.gmail.com with ESMTPSA id i15-20020a02c60f000000b0039deb26853csm2553578jan.10.2023.02.27.16.07.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Feb 2023 16:07:29 -0800 (PST) From: Ridley Combs Message-Id: <47396232-645B-4D31-9145-4FC79A8A693A@rcombs.me> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Date: Mon, 27 Feb 2023 18:07:18 -0600 In-Reply-To: <20230223101718.562202-1-aimingoff@pc.nifty.jp> To: ffmpeg-devel References: <20230223101718.562202-1-aimingoff@pc.nifty.jp> X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v7 0/4] add ARIB caption decoder using libaribcaption X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: TADANO Tokumei Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Feb 23, 2023, at 04:17, TADANO Tokumei wrote: > > Ping with rebased patch set. > Some chages are added to reflect review results from outside of this ML. > > --- > This patch set add another ARIB caption decoder using libaribcaption > external library: https://github.com/xqq/libaribcaption > The library decodes subtitles of ISDB-based TV broadcasting. > It is not only for Japanese ARIB STD-B24 caption, but also for > Brazilian ABNT NBR 15606-1 and Philippines version of ISDB-T. > > Unlike libaribb24, it supports 3 types of subtitle outputs: > * text: plain text > * ass: ASS formatted text > * bitmap: bitmap image > > Default subtitle type is ASS as same as libaribb24. > Advantages compared with libaribb24 on ASS subtitle are: > * Subtitle positioning. > * Multi-rect subtitle: some captions are displayed at different > position at a time. > * More stability and reproducibility. > > Subtitle type can be changed by `-sub_type` option. > You can see ARIB caption with ffplay tool: > ffplay -sub_type bitmap MPEG.TS > > Sample files exist under: > https://streams.videolan.org/streams/ts/ARIB/ > Some of them are encrypted and some don't contain ARIB caption data. > Good samples for ARIB caption are: > brazil/07-25_20-33-35_UCV - HD_.ts > japan/channel2[137]_clear.ts > japan/osaka_15.ts > > --- > v7: reflect review results from outside of this ML > - rename -ass_workaround option to -ass_single_rect and default to > false (latest mpv supports multiple ASS rectangle) > - add -canvas_size option to specify frame size to render bitmap subtitle > - add -caption_encoding option to specify encoding of subtitle text > - change behavior of profile C ARIB caption > - some cosmetic changes > v6: reflect review results from outside of this ML > - check clut table overflow > - do not adjust vertical position of ruby for ASS format > v5: reflect review comments from Mao Hata > - reset correct variable in aribcaption_close() > - add aribcaption_close() to some places in aribcaption_init() > - check if av_strdup() returns NULL in set_ass_header() > v4: reflect review results from outside of this ML. > - resize bitmap subtitle image to display fonts with correct aspect ratio > - multiple font families can be specified by '-font' option > - remove 'rendering_backend' option > - add document > - minor bug fixes > v3: combine former 1/4 and 2/4 due to the patchwork shows build error. > - fix help option content which incorrectly separated to 2 lines in 2/4. > - amend commit message of 4/4. > > TADANO Tokumei (4): > lavc/libaribcaption.c: add ARIB caption decoder using libaribcaption > lavc/codec_desc.c: remove AV_CODEC_PROP_TEXT_SUB property > lavf/mpegts.c: set some properties for ARIB caption > doc/decoders.texi: add document of aribcaption decoder > > configure | 4 + > doc/decoders.texi | 150 +++++ > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_desc.c | 1 - > libavcodec/libaribb24.c | 1 + > libavcodec/libaribcaption.c | 1171 +++++++++++++++++++++++++++++++++++ > libavformat/mpegts.c | 6 +- > 8 files changed, 1333 insertions(+), 2 deletions(-) > create mode 100644 libavcodec/libaribcaption.c > > -- > 2.30.2 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". This set looks reasonable to me at this point; the one thing blocking it is the issue with assenc.c muxing for AVSubtitles with multiple rects, which needs a decision on this question: http://ffmpeg.org/pipermail/ffmpeg-devel/2023-February/306850.html Once that's resolved, I'm happy to merge this. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".