From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id B3A0E401E3
	for <ffmpegdev@gitmailbox.com>; Fri, 19 Aug 2022 08:08:08 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6677168B960;
	Fri, 19 Aug 2022 11:08:05 +0300 (EEST)
Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6661968B75A
 for <ffmpeg-devel@ffmpeg.org>; Fri, 19 Aug 2022 11:07:58 +0300 (EEST)
Received: from smtp102.mailbox.org (smtp102.mailbox.org
 [IPv6:2001:67c:2050:b231:465::102])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4M8Drq2lS3z9sSr
 for <ffmpeg-devel@ffmpeg.org>; Fri, 19 Aug 2022 10:07:55 +0200 (CEST)
Message-ID: <46fefbee-3ed3-77be-abf7-3a7ace9a5a61@ycbcr.xyz>
Date: Fri, 19 Aug 2022 10:07:54 +0200
MIME-Version: 1.0
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <6301fb24-1d5d-b069-a773-0defdc2086df@ycbcr.xyz>
 <165944996002.15471.1799609688209274723@lain.khirnov.net>
From: Steve Lhomme <robux4@ycbcr.xyz>
In-Reply-To: <165944996002.15471.1799609688209274723@lain.khirnov.net>
X-Rspamd-Queue-Id: 4M8Drq2lS3z9sSr
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/pthread_frame: update the main
 avctx from the current, ThreadContext
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/46fefbee-3ed3-77be-abf7-3a7ace9a5a61@ycbcr.xyz/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Hi,

On 2022-08-02 16:19, Anton Khirnov wrote:
> Why are you not resubmitting your original patch that stops copying
> hwaccel_priv_data to the user-facing context?
> 
> It seemed more correct to me, since the user-facing context should never
> see any hwaccel data. Or does it not fix the issue fully?

The original patch is not fixing it properly. With that patch and 
avcodec-threads > 1, the uninit of the hardware decoder is not called 
anymore. So it will replace a crash fix with a (big) resource leak.

For reference, this it the patch we're talking about
https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg94274.html

> For a more proper fix, we probably want to bundle hwaccel+state+uninit
> to a single refcounted thing.
> 
> -- 
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".