Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/4 v2] avcodec/librav1e: support setting sample aspect ratio
Date: Tue, 18 Oct 2022 19:38:15 -0300
Message-ID: <46ddeed4-8c3a-5eaf-9c26-2ffb9158d416@gmail.com> (raw)
In-Reply-To: <20221012130829.2392-1-jamrial@gmail.com>

On 10/12/2022 10:08 AM, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> Changes since v1:
> - Ensure we're not passing values like 0/1 as they are not supported by
>    librav1e.
> 
>   libavcodec/librav1e.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c
> index 0601efed2c..a13d6c9eaf 100644
> --- a/libavcodec/librav1e.c
> +++ b/libavcodec/librav1e.c
> @@ -298,6 +298,12 @@ static av_cold int librav1e_encode_init(AVCodecContext *avctx)
>           goto end;
>       }
>   
> +    if (avctx->sample_aspect_ratio.num > 0 && avctx->sample_aspect_ratio.den > 0)
> +        rav1e_config_set_sample_aspect_ratio(cfg, (RaRational) {
> +                                             avctx->sample_aspect_ratio.num,
> +                                             avctx->sample_aspect_ratio.den
> +                                             });
> +
>       rret = rav1e_config_parse_int(cfg, "threads", avctx->thread_count);
>       if (rret < 0)
>           av_log(avctx, AV_LOG_WARNING, "Invalid number of threads, defaulting to auto.\n");

Will apply set.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2022-10-18 22:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 13:08 James Almer
2022-10-12 13:08 ` [FFmpeg-devel] [PATCH 2/4] avcodec/librav1e: export extradata on init() James Almer
2022-10-12 13:08 ` [FFmpeg-devel] [PATCH 3/4] avcodec/librav1e: support AV_CODEC_CAP_ENCODER_RECON_FRAME James Almer
2022-10-12 13:08 ` [FFmpeg-devel] [PATCH 4/4] avcodec/librav1e: use lavu image helpers where adequate James Almer
2022-10-18 22:38 ` James Almer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46ddeed4-8c3a-5eaf-9c26-2ffb9158d416@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git