Re: [FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC

[Marton Balint <cus@passwd.hu>]

On Sun, 26 May 2024, Lynne via ffmpeg-devel wrote:

> On 25/05/2024 08:10, Marton Balint wrote:
>>
>>
>>  On Sat, 25 May 2024, Lynne via ffmpeg-devel wrote:
>>
>>>  apichanges will be updated upon merging, as well as a version bump.
>>>  ---
>>>  libavutil/channel_layout.h | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>>  diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h
>>>  index 8a078d1601..4e19bbbd9e 100644
>>>  --- a/libavutil/channel_layout.h
>>>  +++ b/libavutil/channel_layout.h
>>>  @@ -79,6 +79,10 @@ enum AVChannel {
>>>      AV_CHAN_BOTTOM_FRONT_CENTER,
>>>      AV_CHAN_BOTTOM_FRONT_LEFT,
>>>      AV_CHAN_BOTTOM_FRONT_RIGHT,
>>>  +    AV_CHAN_SURROUND_LEFT,
>>>  +    AV_CHAN_SURROUND_RIGHT,
>>
>>  You want to add a channel ID for Surround or Side Surround? Because based
>>  on the subsequent AAC patch you want to add it for side surround, but then
>>  the AV_CHAN_SURROUND name is confusing, since we are mapping Surround to
>>  AV_CHAN_SIDE. So I suggest using AV_CHAN_SIDE_SURROUND_LEFT/RIGHT instead.
>>
>>>  +    AV_CHAN_TOP_SURROUND_LEFT,
>>>  +    AV_CHAN_TOP_SURROUND_RIGHT,
>>
>>  You will need to extend the channel_names[] array in channel_layout.c with
>>  the newly added channel IDs.
>
>
> Thanks, changed locally.
> Planning on merging this in 2 days unless there are more comments.

Can you post the updated version of this patch? It is not entirely clear 
what you added, or e.g. what abbriviation you planning to use for the new 
channel IDs. Also I noticed one more thing, you also need to add the 
AV_CH_* variants for the new IDs.

3 days for new API such as this is a bit short, and if your AAC 
patches depend on it, I suggest you wait a few more days.

Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".