From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C1E014FB3C for ; Thu, 26 Jun 2025 22:27:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8090868E676; Fri, 27 Jun 2025 01:27:16 +0300 (EEST) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id DBB2068E65B for ; Fri, 27 Jun 2025 01:27:09 +0300 (EEST) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4538bc52a8dso8076625e9.2 for ; Thu, 26 Jun 2025 15:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750976829; x=1751581629; darn=ffmpeg.org; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=SiwuM0fvajk5fy2WFYSO+OctgPXLtsHqX8k7hlAH8/U=; b=dqL7kjKCGEJjWCpbwVT7gq32JRIchreaGRs7Kg+vyxytylF6ZhrsFrb3TiVUFR2apa vCx2pUeYQo8BalwSICkkvVwZ6I/qvbpIUhUyHb2JHfih0NzEvqAHI2VR6T8V5xpfo4nB AufUsf5vS7uElhFH4W80+JE52V/QNYbaXvr3QJJ28z+E8/ypnUM3ma4jfhEhhyhnh6wS RaKrje3dm8OXWgYtZi6nd0EdyvRBkv34oGoC1NnOMwyWPv0XSyvYxDdVH2rJ0sWv0hFM aecfpgm+sMk/Z6yRrfT79seLpPcObIsgBH6YqCmAwIGlnH0L8j3VMHm7J3iQDTZkqMsn f1FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750976829; x=1751581629; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SiwuM0fvajk5fy2WFYSO+OctgPXLtsHqX8k7hlAH8/U=; b=LJusWfnxSx4yI5cw8zd7HLMYfnJUdkXOUKd3Kk8iIufHzLs0ZmmbS9w6bMk//eyJnN uRA5IcmstraHpW20d5O0C79jS4/P/iG908hEzHjRrAijHoiwPpr5o+bqBh2KGqSiyhvA i4FeuE/NLr6sBfd1jeOni9QMWsqejriQyyM9yjIU/xgpm03CAx+rpcXYngV1DUCRsoED lnKF+v5++uE/MuaqTzANHZuoXZAR5j7Z719pDZwfHIyMG0jm6aznUWIZMImTsk2+kfQK sEQkJgTfj851c6zRkpK2xxAbZAs1K1fGHwkS4dM/WZ9LIBe30zJSOkBAFVjM78er7ugA bAKQ== X-Gm-Message-State: AOJu0YyFygYeMcdH5WTCr+af9mlSM0vTfo/yKpFsdjMbXYMz1t2XVEDO lTnKk30baqYTdFkUr2u8FoVpHDhCXEM8IzAWGWlKSrhTSHtbZUtZ488SJZsVkg== X-Gm-Gg: ASbGnctgwu0fIbEjuY0aiedfpuBU3JYMzDcVot21ADfRqHlqpx+nxrGUn7s9q6eKJ5E SPdcjfHOUEcPKoGaX+LGBvIMnK9IiNCveG6l28EUj/+AndlAtc3ypngtAFJR4/CHDXRITmfw3hv B7z8KkoNcMRbl0JFNE1x5b4uCUZbgflnYfRNWB1AWtD15KDIpvNJwMSx7ZG2TzPxsuwmQNJsvnp jWG87qjZ7AFH4MwMxDjP6Hqj9P+308GtWYhJl6td1+oxkPU8H9jFXPVyopDL4VBviJPuHsWjQxX 27knEdkz/8oT4IjPG50tmomDxKARwz8hMwgRjUpgU3oD0+DT8+AlKURPNwCSgFZXKFn5tzGc1oQ VMpJY7nP7/OqvMQbPbB92HqKsQTmxIUIxhNJLPNtPNwNKppwYVIPpmOaaoXBYZQ0JyG5AdC1YU7 I= X-Google-Smtp-Source: AGHT+IH3clDWQifAsSW/lyGDEbE2UWAePrlRi9ZuM82eJlbUXnJKQWyOPcaIsL81BbQpgA5GqujZkA== X-Received: by 2002:a05:600c:3b91:b0:445:49e:796b with SMTP id 5b1f17b1804b1-4538ee5d62cmr12094475e9.17.1750976828726; Thu, 26 Jun 2025 15:27:08 -0700 (PDT) Received: from [192.168.178.57] (p20030102370045007d7f230e46ac5795.dip0.t-ipconnect.de. [2003:102:3700:4500:7d7f:230e:46ac:5795]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a3fe0efsm31192995e9.24.2025.06.26.15.27.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jun 2025 15:27:07 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Fri, 27 Jun 2025 00:27:07 +0200 X-Mailer: MailMate (2.0r6222) Message-ID: <467A87ED-05A6-40EC-8698-CB2B64CBCE9B@gmail.com> In-Reply-To: References: <20250620110853.1448602-1-nicolas.gaullier@cji.paris> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print 64 bit integers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 23 Jun 2025, at 0:04, softworkz . wrote: >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of >> Nicolas Gaullier >> Sent: Freitag, 20. Juni 2025 13:08 >> To: ffmpeg-devel@ffmpeg.org >> Cc: Nicolas Gaullier >> Subject: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print >> 64 bit integers >> >> Regression in ffprobe since textformat introduction >> in d7a3f68feae0b1c3718f9d2671c6d41c60a40680. >> >> Fixes #11638 >> >> Signed-off-by: Nicolas Gaullier >> --- >> fftools/textformat/avtextformat.c | 2 +- >> fftools/textformat/avtextformat.h | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/fftools/textformat/avtextformat.c >> b/fftools/textformat/avtextformat.c >> index 14779e6f0c..14bad9022b 100644 >> --- a/fftools/textformat/avtextformat.c >> +++ b/fftools/textformat/avtextformat.c >> @@ -437,7 +437,7 @@ static char *value_string(const >> AVTextFormatContext *tctx, char *buf, int buf_si >> } >> >> >> -void avtext_print_unit_int(AVTextFormatContext *tctx, const char >> *key, int value, const char *unit) >> +void avtext_print_unit_int(AVTextFormatContext *tctx, const char >> *key, int64_t value, const char *unit) >> { >> char val_str[128]; >> struct unit_value uv; >> diff --git a/fftools/textformat/avtextformat.h >> b/fftools/textformat/avtextformat.h >> index cf23d93871..8316829af5 100644 >> --- a/fftools/textformat/avtextformat.h >> +++ b/fftools/textformat/avtextformat.h >> @@ -169,7 +169,7 @@ void avtext_print_integer(AVTextFormatContext >> *tctx, const char *key, int64_t va >> >> int avtext_print_string(AVTextFormatContext *tctx, const char >> *key, const char *val, int flags); >> >> -void avtext_print_unit_int(AVTextFormatContext *tctx, const char >> *key, int value, const char *unit); >> +void avtext_print_unit_int(AVTextFormatContext *tctx, const char >> *key, int64_t value, const char *unit); >> >> void avtext_print_rational(AVTextFormatContext *tctx, const char >> *key, AVRational q, char sep); >> >> -- > > Hi Nicolas, > > LGTM! > > Thanks a lot for the fix, > sw Pushed as 2b25a66238c2508ecc02b0610f58bcf2156f3bec. Thanks. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".