Re: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print 64 bit integers

[Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org>]

On 23 Jun 2025, at 0:04, softworkz . wrote:

>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>> Nicolas Gaullier
>> Sent: Freitag, 20. Juni 2025 13:08
>> To: ffmpeg-devel@ffmpeg.org
>> Cc: Nicolas Gaullier <nicolas.gaullier@cji.paris>
>> Subject: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print
>> 64 bit integers
>>
>> Regression in ffprobe since textformat introduction
>> in d7a3f68feae0b1c3718f9d2671c6d41c60a40680.
>>
>> Fixes #11638
>>
>> Signed-off-by: Nicolas Gaullier <nicolas.gaullier@cji.paris>
>> ---
>>  fftools/textformat/avtextformat.c | 2 +-
>>  fftools/textformat/avtextformat.h | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fftools/textformat/avtextformat.c
>> b/fftools/textformat/avtextformat.c
>> index 14779e6f0c..14bad9022b 100644
>> --- a/fftools/textformat/avtextformat.c
>> +++ b/fftools/textformat/avtextformat.c
>> @@ -437,7 +437,7 @@ static char *value_string(const
>> AVTextFormatContext *tctx, char *buf, int buf_si
>>  }
>>
>>
>> -void avtext_print_unit_int(AVTextFormatContext *tctx, const char
>> *key, int value, const char *unit)
>> +void avtext_print_unit_int(AVTextFormatContext *tctx, const char
>> *key, int64_t value, const char *unit)
>>  {
>>      char val_str[128];
>>      struct unit_value uv;
>> diff --git a/fftools/textformat/avtextformat.h
>> b/fftools/textformat/avtextformat.h
>> index cf23d93871..8316829af5 100644
>> --- a/fftools/textformat/avtextformat.h
>> +++ b/fftools/textformat/avtextformat.h
>> @@ -169,7 +169,7 @@ void avtext_print_integer(AVTextFormatContext
>> *tctx, const char *key, int64_t va
>>
>>  int avtext_print_string(AVTextFormatContext *tctx, const char
>> *key, const char *val, int flags);
>>
>> -void avtext_print_unit_int(AVTextFormatContext *tctx, const char
>> *key, int value, const char *unit);
>> +void avtext_print_unit_int(AVTextFormatContext *tctx, const char
>> *key, int64_t value, const char *unit);
>>
>>  void avtext_print_rational(AVTextFormatContext *tctx, const char
>> *key, AVRational q, char sep);
>>
>> --
>
> Hi Nicolas,
>
> LGTM!
>
> Thanks a lot for the fix,
> sw

Pushed as 2b25a66238c2508ecc02b0610f58bcf2156f3bec.

Thanks.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".