From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EFA34408ED for ; Wed, 3 Aug 2022 03:20:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6BDBD68B6EE; Wed, 3 Aug 2022 06:20:24 +0300 (EEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7FB4A68B1F6 for ; Wed, 3 Aug 2022 06:20:17 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659496822; x=1691032822; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=1nuLeI0K5M7Tb8JeSDIoUE0jHahh/d8vnwRD7z2MvWM=; b=CCrdbJclCYvU4SZEvSRga9IENH6cukZrpuuht/B1XIl0VgEV2uhIrw0q O2uBXlQGJRw5HMRormIXbYisXM9JdiKsi1d5V6JQ7jsH1DId9e/Hwm7Ri v2ozcH6/Tdspe0/ES5H9wCsLkNc0DOKlCjAlqMePZcfEA/axWiKb+7WDJ Ydqt5PBLMm4QcpdSaFJz74fiyG3HC7HuTFHpYQn6vhrwRohk4XocLHBrZ hOuUAh8MwMfwyfL0b7aDCmVr7IrgHisx9+r3zCrfkE0fw3zywgRuspjAd yBxEd412WF2cXpXfss6ajG4mvVWqZVyxc2grXAE2eZHcVsDWXfqnZHodA w==; X-IronPort-AV: E=McAfee;i="6400,9594,10427"; a="287131831" X-IronPort-AV: E=Sophos;i="5.93,212,1654585200"; d="scan'208";a="287131831" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2022 20:20:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,212,1654585200"; d="scan'208";a="602667890" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2022 20:20:15 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 2 Aug 2022 20:20:14 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 2 Aug 2022 20:20:14 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 2 Aug 2022 20:20:14 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Tue, 2 Aug 2022 20:20:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f4/7DG0KRmocTaPQljYEE1zdXNoeAC1oYcovdYUrLnWdWsWdGC1l1CnhR+r0ZnFSLipRVviv0dHYz5kyrovoVzMiE7K6utHcL3bnHU6uGZ6r296Zx2IlRRH6axp53FpA1Us/a5UFfOz7LjX0Q+SlNtW5graQxI8NlC3kqsHO9B3suGViXakFcFOgLjMdvKJ9Rmph1e2qGacjR3sznazotMd5EBitFfaZLv+ldg06U8aF/ShWpKQFxOc3b9sRTOV5y/9Tm2Renfbmc13lxnUzcFp4yT8wfZbZ447SESrB3K2YXct8SfXCG2KZ3DIfaZkMLf9OuiNL+cX45fF9ryzF5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1nuLeI0K5M7Tb8JeSDIoUE0jHahh/d8vnwRD7z2MvWM=; b=jWxpNAbzQja7A8rGZnnTCRQE4ghf9dqRmoJzQ7pVz6B9eyKJRIaqdOgiwPfStVmM7a068exbfh84d5r+Ji+tQ19MIZ1hVfY6ZX+NQQPwzAcjQYZ18k+V6CEgwfxopUtJp8Q8uH0Qp9hGsmyf6nffv1H3T6qMMXsbmgsvIXP5CDx1tDwBADKHd3ASeyGnvTRVEFfho+gcTt21xvcPsIRi+wd71hSSKcJtIAkGHOkJgvFc9zn/xaJEjTMpvnHOMqzzKUnkCOY8l+VFdLMQQ3PRaR9MRxsltNa12mRO/MpfFbGuaogU5nGAlZWW6aoMk7sT9oZrdKBZuRwDpL9G6PUtIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BYAPR11MB2967.namprd11.prod.outlook.com (2603:10b6:a03:8a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Wed, 3 Aug 2022 03:20:11 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b%2]) with mapi id 15.20.5504.014; Wed, 3 Aug 2022 03:20:11 +0000 From: "Xiang, Haihao" To: "anton@khirnov.net" , "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v4 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder Thread-Index: AQHYpkVfquEZ+nhIDUyi9G2tGBudVq2bedOAgAEJggA= Date: Wed, 3 Aug 2022 03:20:11 +0000 Message-ID: <467606112c9f385099bc1f9d30d0ae9088e169d0.camel@intel.com> References: <20220802075601.31925-1-haihao.xiang@intel.com> <20220802075601.31925-2-haihao.xiang@intel.com> <165943979360.15471.7494839221217612939@lain.khirnov.net> In-Reply-To: <165943979360.15471.7494839221217612939@lain.khirnov.net> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4e516532-219c-4e3e-d22c-08da74ff136c x-ms-traffictypediagnostic: BYAPR11MB2967:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8u3CQhah4PsN9SfbmKUT5BUIZBkReb8TGfcBV/ciQIxqkJ70z03Si+dLqDQ7B8Xgq+BUnnlDp6PVD7ENuKziFoLd6N3uXDlDsxduG5xc+M1WVzevD5cZyTE9Rz3zle9tH2R0OgpRJr2YTmb1P5RgIWgUpA8Kz0rQ75+rRXzmBDLEQL+GYhzjWgu0YZRbp4TC6nIkpox2oAlEzraDdFMoiU45zoLUc9AnLw8vnJ5No5f90dOHS/YpTKBfU5Zt62Vyw50bkCZlVJ3fgZ85p8CQGWjr9CQGOZ/CWRCTxrgRj+m7+WSGJHJJgoF0YM+sUuqZrHoRIu+MK7EEzsbArKQN9ypdNxvb0+dYgOCPgn8J06jeUdn5qMfuuynTrYommZy5SejcjF0z5Rf6IJseNQQeO+enaR8gNIf2Z242/qDy8D7aBsltOnBW+LHUIUqhN23wCmuqWW0jaUELYqoxVNZMNw+fdsQFOUbLvqFxEyvveUoUSkgd92PC6N+UWYjKryqU0cGvlWTuvAdvvWHp4v/Jul4MEQvGUOJ+OvE0Qn9QMn+BPIVlzpYXbpge78n7gie3uLsqKy+AkxCVZv/475NM1RAmLYwBiiY29xFoKL5et2blMUkNEORfaSV9L1YTpcveXqLiEnnkHezd29Y0LnKZnmBIlcOgrdCcM01mOnstyhX6w1t2TooE0jasydUimB0u1zIRFUVBMrQNmblVUYgFputFTNYTsTPA7SjzitUGnTskwuFkaGX9ok0mEpJpUTaGD3XBpDkalCJ1itwWb2ajSO7jwJZObd2ZO+Cfxrt9fO77YV6t/pncjep7vmFPcOYTEsDIPcTgK77BG33dv4SjwA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(136003)(366004)(376002)(39860400002)(346002)(6506007)(41300700001)(6512007)(26005)(478600001)(86362001)(110136005)(71200400001)(82960400001)(316002)(38070700005)(6486002)(38100700002)(122000001)(83380400001)(186003)(2906002)(66946007)(36756003)(91956017)(66446008)(76116006)(66556008)(8676002)(66476007)(64756008)(8936002)(5660300002)(2616005)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dW9NS3hRRXViM1JXOGcxL3RqaVFnTis3Q3dBcTZwa2VSZ1c0VUw1TjZxS2pP?= =?utf-8?B?QkFiczAvd2oveDZFU0plbmk4V2hleU05OFhSbk5hMEtsSkFyQ3ZpMXBxS3Ay?= =?utf-8?B?TmpmQkpSOUFybStMUGhhS2lEYnpNa1Q2dlJYTlF4TUd1akdKYVFGRkVuS1l3?= =?utf-8?B?b2lBUURnNS9weENoNkZjcHVXRWdWYmk4M1I1bnpGand6M1pEK3RwSTdqT3BM?= =?utf-8?B?dHJjSE5wakxDOGVnck9yWWZhLzdMRlNPSEhlUnRQRE1EcHY0MGxFSExIcEtq?= =?utf-8?B?Wnk0WU91RWkwckQ1UlBYbGR6bXJ4SU5TMWtCajNIL2hnRnkvVG1yWWhRTDl3?= =?utf-8?B?SGZFanU2T0dTajZJZjBlTlIvcFZaalZhNUV4d0Zoa2hYQ3dCbEUrTnNSSmxR?= =?utf-8?B?MGhKMDVpTFpOOFJTRVQxV1BJb092eHVEMGlmWjZqcGw0U2h3bjZoUGNMMXRR?= =?utf-8?B?R1p2VnJUTk1pd2RaMlRuWTE4QnV1Nk9sbDJ3aGEwZ1BhVTd4NFg1M1RxcUN1?= =?utf-8?B?andKZ2xDR04vdG41MGRzN2VjQmR1L2QzUGlUM09Sb0V3RDgzVUdyRnc1SEJo?= =?utf-8?B?emRONTJrVEQzeWJKTWJlNU56K1l5eVIyUnhaRDRDL0xCSmo4Ris1dkhSeHh0?= =?utf-8?B?NEd5REJYcXQzZHM3a3RGNGlOM25uV1JSZVlLYUJNUEhja21VSGE4QlNKeHpq?= =?utf-8?B?SW5MMktXVm1BeUZ5Y2VzRkZTYW9NVFNyRU1tWk9PSUR6Q1k3MEg5MXdFaEdK?= =?utf-8?B?QWwrei93UENZR2txM3FwSlQ4TlZmSTBUQ0I2dlZTS0FUdVFqRFNtQ2ZwMEhu?= =?utf-8?B?N3J3Z2thUWhEcHJ6K1BCb0dua0JNN0dxdGJrVnRqYysxQzFjUmNzQ0dPQmJq?= =?utf-8?B?TGpoN1VMMlZ1bEdpb0w2YVMwUHVOZTFpOW1TTlFvOVZJM3RsMUZ4R3RhWVZl?= =?utf-8?B?SUQ2WGxpMmtldmo2TzdldVRRNFpIVDQwRCtMbElleTJVOTEwTmVxVElsN0dM?= =?utf-8?B?c2RURGhEU2k4N3JSTGhzZGJSdVJTY1VMYkErc1laT0pnM3IxR3BCZHcycUdo?= =?utf-8?B?c1I4cGNhNzEybTFRYlU0VnVEWCtqSktlQmdaNmxTcDZLKzJRTWRuSm5xTDFZ?= =?utf-8?B?eEVEeTVmK1pkWWhNcDhrVFN5S0t5amx6Zlc3OVhxbngxcTcrcXV1T2dIU25k?= =?utf-8?B?WGhrZVNCK25yVWc2ckpiaWdKeGxiUVNjeC9DUkhwZlVsU09OS3dqaW4xbHo4?= =?utf-8?B?SWx2ME1Na2YxWURKYkxmQmI1WnlhTTg0dVlibmY0c2tzVS80Y3Q5eXJCeng0?= =?utf-8?B?LzZoaXJ6aDNsZ0hwUjkyY08yTmgwclRidXpYUzVMTXBCWHowSFpWRThPcWR3?= =?utf-8?B?enhINmllb0NoOEM3UFlZMmp1WlZGREcxUVBzVGpJRE52QmtWRURDNnJCM2Vl?= =?utf-8?B?ek1MY1cycTdlWjNHNGV5QSs3SWlUYTQ0MHpHQ3c5dmZmdmxmTThmc2lKeWxX?= =?utf-8?B?OXdsWFY1OTBhZ05jV2xqY0hiTU9CWkE5cEpqdkZZRlhlSk1aZ1QrZXdMbGNN?= =?utf-8?B?VjBSOXU3NHpPeXBkNTJqQzEvODlDSmxGSEtxRE1GUXNINFBheWVzZVBQNkdh?= =?utf-8?B?ZzJCL3FkRGsyQWJDR3QxNkNTUndpTHMrc3ZQdDRDaEpBVEJCNnVKdXl4ZkFn?= =?utf-8?B?V3MxYU9ZT2c1SWRmTmpJSk8vazYrMFZ4aFVaU0VNRkJLNFJKZzZaS3ovc2Fa?= =?utf-8?B?U0ZJaW05RkJvVzFGejd1ell0bmhIdG5KZ0dvcFRmalk2dW1TTGJqR3ZtbUdK?= =?utf-8?B?UzZBa25HZ3VOKzYrWWF2UTd6UlE1L1FTeFFaN0dIbWw3OUtjaTJoVUcrNGlz?= =?utf-8?B?bWQvRFBWcE9ncnNOeWFCWkE5aU1mdFAzemFPQXVvcU1zTGF0MW8zVU9vcEk1?= =?utf-8?B?V0JMb1FtQUVNSXh3bnNESFpHSEVBOFo1MHRwYi84OC9PbUV2NVp4MHdkdzFs?= =?utf-8?B?U3gwVDRKKzZqZHQxeENjNG1xN21LQnE1NldrczljcHNCODdSUjJnclI1djF6?= =?utf-8?B?dEFWR3NRZmNzY3RHU0JaRDYvMnFrdVJzVnRHNG9yNTBTdmtobWppNU8yN09H?= =?utf-8?B?YnMvd2JrN1l5eVlsdG0yZTlPcGowVW1SMlFiUHhFOWFtRFpMMXI3Vit4Ujlv?= =?utf-8?B?TXc9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e516532-219c-4e3e-d22c-08da74ff136c X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2022 03:20:11.7259 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uh58J2XuZdU/uhNN+77y97guXEXupxu8fia/ro0bOgT8gGL8iI4bHOkBbNwI8mzMW8hfKC8FlbHRCmaa49lNgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2967 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v4 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-08-02 at 13:29 +0200, Anton Khirnov wrote: > Quoting Xiang, Haihao (2022-08-02 09:56:01) > > From: Haihao Xiang > > > > Usually a HW decoder is expected when user specifies a HW acceleration > > method via -hwaccel option, however the current implementation doesn't > > take HW acceleration method into account, it is possible to select a SW > > decoder. > > > > For example: > > $ ffmpeg -hwaccel vaapi -i av1.mp4 -f null - > > $ ffmpeg -hwaccel nvdec -i av1.mp4 -f null - > > $ ffmpeg -hwaccel vdpau -i av1.mp4 -f null - > > [...] > > Stream #0:0 -> #0:0 (av1 (libdav1d) -> wrapped_avframe (native)) > > > > libdav1d is selected in this case even if vaapi, nvdec or vdpau is > > specified. > > > > After applying this patch, the native av1 decoder (with vaapi, nvdec or > > vdpau support) is selected for decoding(libdav1d is still used for > > probing format). > > $ ffmpeg -hwaccel vaapi -i av1.mp4 -f null - > > $ ffmpeg -hwaccel nvdec -i av1.mp4 -f null - > > $ ffmpeg -hwaccel vdpau -i av1.mp4 -f null - > > [...] > > Stream #0:0 -> #0:0 (av1 (native) -> wrapped_avframe (native)) > > > > Tested-by: Mario Roy > > Signed-off-by: Haihao Xiang > > --- > > fftools/ffmpeg_opt.c | 31 +++++++++++++++++++++++++++---- > > 1 file changed, 27 insertions(+), 4 deletions(-) > > > > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > > index cf0c31bdc2..db51cca66d 100644 > > --- a/fftools/ffmpeg_opt.c > > +++ b/fftools/ffmpeg_opt.c > > @@ -857,7 +857,9 @@ static const AVCodec *find_codec_or_die(const char > > *name, enum AVMediaType type, > > return codec; > > } > > > > -static const AVCodec *choose_decoder(OptionsContext *o, AVFormatContext *s, > > AVStream *st) > > +static const AVCodec *choose_decoder(OptionsContext *o, AVFormatContext *s, > > AVStream *st, > > + enum HWAccelID hwaccel_id, enum > > AVHWDeviceType hwaccel_device_type) > > + > > { > > char *codec_name = NULL; > > > > @@ -868,8 +870,29 @@ static const AVCodec *choose_decoder(OptionsContext *o, > > AVFormatContext *s, AVSt > > if (recast_media && st->codecpar->codec_type != codec->type) > > st->codecpar->codec_type = codec->type; > > return codec; > > - } else > > + } else { > > + if (st->codecpar->codec_type == AVMEDIA_TYPE_VIDEO && > > + hwaccel_id == HWACCEL_GENERIC && > > + hwaccel_device_type != AV_HWDEVICE_TYPE_NONE) { > > + const AVCodec *c; > > + void *i = NULL; > > + > > + while ((c = av_codec_iterate(&i))) { > > + const AVCodecHWConfig *config; > > + > > + if (c->id != st->codecpar->codec_id || > > + !av_codec_is_decoder(c)) > > + continue; > > + > > + for (int j = 0; config = avcodec_get_hw_config(c, j); j++) > > { > > + if (config->device_type == hwaccel_device_type) > > + return c; > > Maybe a verbose-level log message like > > "Selecting decoder '%s' because of requested hwaccel method %s\n", > c->name, av_hwdevice_get_type_name(hwaccel_device_type) > > would be appropriate. No need to send a new patch, just add it (or not, > as you like) and push. Added log and applied patches, thx -Haihao > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".