From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v5 1/2] avformat/riffdec: change declaration of ff_get_wav_header()
Date: Tue, 4 Mar 2025 12:29:25 -0300
Message-ID: <456ddb38-a245-4dda-ae0b-1b9e9c6b28e4@gmail.com> (raw)
In-Reply-To: <20250304152803.GL4991@pb2>
[-- Attachment #1.1.1: Type: text/plain, Size: 1025 bytes --]
On 3/4/2025 12:28 PM, Michael Niedermayer wrote:
> On Tue, Mar 04, 2025 at 01:47:10PM +0100, Andreas Rheinhardt wrote:
>> Michael Niedermayer:
>>> On Mon, Feb 03, 2025 at 09:54:57AM +0530, Viraaj Raulgaonkar wrote:
>>>> Change the type of logctx from void* to AVFormatContext*. This is in
>>>> preparation for the next commit.
>>>> ---
>>>> libavformat/riff.h | 2 +-
>>>> libavformat/riffdec.c | 14 +++++++-------
>>>> 2 files changed, 8 insertions(+), 8 deletions(-)
>>>
>>> will apply
>>>
>>
>> You applied only patch 1/2. This means the "next commit" mentioned in
>> the commit message is "swscale/aarch64: dotprod implementation of
>> rgba32_to_Y".
>
> I didnt notice that
>
> I guess, it would be better if patches dont refer to "next commit"
> but rather to what the commit does so the exact ordering of commits
> dont affect the commit messages
>
> thx
"In a following commit" should be enough to make it valid regardless of
how far in the future the referenced commit is.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-03-04 15:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 4:24 Viraaj Raulgaonkar
2025-02-03 4:24 ` [FFmpeg-devel] [PATCH v5 2/2] avformat/riffdec: warn on invalid sample rate Viraaj Raulgaonkar
2025-02-12 11:31 ` Viraaj Raulgaonkar
2025-03-03 5:35 ` Viraaj Raulgaonkar
2025-03-04 15:29 ` Michael Niedermayer
2025-03-03 5:34 ` [FFmpeg-devel] [PATCH v5 1/2] avformat/riffdec: change declaration of ff_get_wav_header() Viraaj Raulgaonkar
2025-03-04 1:02 ` Michael Niedermayer
2025-03-04 12:47 ` Andreas Rheinhardt
2025-03-04 15:28 ` Michael Niedermayer
2025-03-04 15:29 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456ddb38-a245-4dda-ae0b-1b9e9c6b28e4@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git