Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove experimental status of TrueHD-in-MP4 muxing (mlpa)

[James Almer <jamrial@gmail.com>]

On 11/5/2022 6:31 PM, Nomis101 wrote:
> Support for mlpa muxing was added back in 2019: 
> http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=808a6717e0c584738c60a109afd6d47f4973d619
> But it was hidden back then behind FF_COMPLIANCE_EXPERIMENTAL, because 
> it was new and there was no support from other applications.
> 
> In the meantime there is support in MediaInfo: MediaArea/MediaInfoLib#1258
> 
For VLC: videolan/vlc@9c49f40

> Since version 7.3.4 for Infuse: 
> https://community.firecore.com/t/dolby-mlp-mlpa-codec-support/26100/31
> And mpv does support this as well.
> So, there is no need anymore to hide this behind 
> FF_COMPLIANCE_EXPERIMENTAL. Also, it should be the user's responsibility 
> to choose this only if the user's software/hardware supports it.
> Therefore, this patch removes the experimental status of TrueHD-in-MP4 
> muxing.
> 
> Signed-off-by: Nomis101 <Nomis101@web.de>
> ---
>   libavformat/movenc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 754f95912a..50f1831860 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -7157,7 +7157,6 @@ static int mov_init(AVFormatContext *s)
>                   }
>               }
>               if (track->par->codec_id == AV_CODEC_ID_FLAC ||
> -                track->par->codec_id == AV_CODEC_ID_TRUEHD ||
>                   track->par->codec_id == AV_CODEC_ID_OPUS) {
>                   if (track->mode != MODE_MP4) {
>                       av_log(s, AV_LOG_ERROR, "%s only supported in 
> MP4.\n", avcodec_get_name(track->par->codec_id));

This is wrong. You want to remove the check for experimental flag when 
using truehd that's after this.
This patch as is is preventing other checks from being done (like 
ensuring truehd is only muxed on mp4 output).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".