Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: Don't use AVFrame.channel_layout

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: Don't use AVFrame.channel_layout
Date: Mon, 5 Sep 2022 09:32:00 -0300
Message-ID: <453a811f-9be5-a785-b3a8-cbf8556b703e@gmail.com> (raw)
In-Reply-To: <AS8P250MB074497EA6BCEE5C930035ECB8F7C9@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

On 9/4/2022 8:30 PM, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   libavfilter/avfilter.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
> index 965f5d0f63..6740339808 100644
> --- a/libavfilter/avfilter.c
> +++ b/libavfilter/avfilter.c
> @@ -62,7 +62,7 @@ static void tlog_ref(void *ctx, AVFrame *ref, int end)
>       }
>       if (ref->nb_samples) {
>           ff_tlog(ctx, " cl:%"PRId64"d n:%d r:%d",
> -                ref->channel_layout,
> +                ref->ch_layout.order == AV_CHANNEL_ORDER_NATIVE ? ref->ch_layout.u.mask : 0,

Should be ok, but i expect that eventually filters will support and 
start propagating custom layouts (after the old API is gone), so maybe 
using the layout name helpers is a better idea.

>                   ref->nb_samples,
>                   ref->sample_rate);
>       }
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".