From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 5/6] avcodec/hevc_ps: --typo
Date: Tue, 2 Apr 2024 09:12:09 -0300
Message-ID: <44df12c6-8d0b-4615-85be-d6447eee684d@gmail.com> (raw)
In-Reply-To: <20240401205607.9093-5-michael@niedermayer.cc>
On 4/1/2024 5:56 PM, Michael Niedermayer wrote:
> Fixes: null pointer dereference
> Fixes: 67737/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-4858162608930816
>
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/hevc_ps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c
> index 38b3721a6d5..25f087ed754 100644
> --- a/libavcodec/hevc_ps.c
> +++ b/libavcodec/hevc_ps.c
> @@ -460,7 +460,7 @@ int ff_hevc_decode_nal_vps(GetBitContext *gb, AVCodecContext *avctx,
> int ret = AVERROR_INVALIDDATA;
> HEVCVPS *vps;
>
> - if (ps->pps_list[vps_id]) {
> + if (ps->vps_list[vps_id]) {
> const HEVCVPS *vps1 = ps->vps_list[vps_id];
> if (vps1->data_size == nal_size &&
> !memcmp(vps1->data, gb->buffer, vps1->data_size))
LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-02 12:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 20:56 [FFmpeg-devel] [PATCH 1/6] avformat/isom: Uninit layout in ff_mp4_read_dec_config_descr() Michael Niedermayer
2024-04-01 20:56 ` [FFmpeg-devel] [PATCH 2/6] avformat/mov: Check that tile_item_list is initialized in read_image_iovl() Michael Niedermayer
2024-04-01 21:54 ` James Almer
2024-04-01 23:49 ` Michael Niedermayer
2024-04-02 12:07 ` James Almer
2024-04-01 20:56 ` [FFmpeg-devel] [PATCH 3/6] tools/target_dec_fuzzer: Adjust threshold for RV30 Michael Niedermayer
2024-07-16 13:12 ` Michael Niedermayer
2024-04-01 20:56 ` [FFmpeg-devel] [PATCH 4/6] avformat/demux_utils: Avoid leaking the packet in ff_add_attached_pic() Michael Niedermayer
2024-04-01 21:35 ` Andreas Rheinhardt
2024-04-01 23:57 ` Michael Niedermayer
2024-04-01 20:56 ` [FFmpeg-devel] [PATCH 5/6] avcodec/hevc_ps: --typo Michael Niedermayer
2024-04-02 12:12 ` James Almer [this message]
2024-04-02 21:23 ` Michael Niedermayer
2024-04-01 20:56 ` [FFmpeg-devel] [PATCH 6/6] avcodec/apedec: Use NABS to avoid undefined negation Michael Niedermayer
2024-04-02 21:25 ` Michael Niedermayer
2024-04-01 21:25 ` [FFmpeg-devel] [PATCH 1/6] avformat/isom: Uninit layout in ff_mp4_read_dec_config_descr() James Almer
2024-04-01 21:29 ` James Almer
2024-04-01 21:33 ` James Almer
2024-04-01 23:40 ` Michael Niedermayer
2024-04-02 0:11 ` James Almer
2024-04-02 22:22 ` Marton Balint
2024-04-02 23:34 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44df12c6-8d0b-4615-85be-d6447eee684d@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git