From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C13854526B for ; Mon, 16 Jan 2023 04:36:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1FED168BD5B; Mon, 16 Jan 2023 06:36:00 +0200 (EET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5C8B268022D for ; Mon, 16 Jan 2023 06:35:53 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673843758; x=1705379758; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Hc0UTFvwVrimMqKah9x8WG6n84nUJLmw/EO3y96x414=; b=A835rb4lNPXSt5Dfn04BYdDk3eSEhoECL7nOaWOxsp5FpEd/jiyfPs1m Kw7c+sDhaq9QUTo3zzsYnIqwFswlA02MK/e0s2YJowL2UeCHPpAsCpLdl Ag8TS/89J+VGV9RSuy3yN7q0z0u7IbeBnRkFTq//qi2dhFB+X2Sgj9yuw 1fj5sY/QZJEGRMG5hMira+gP5fzEmoWlTsnoYjQTZiNXq/itMAjPGgxe7 p2IE6mOa/gcvQEB6URMDFtK5CwQI37bCC52sNEfId6oIyu87obI06sn+v YDJWavFpFQijvI+fvv+C/9B88sRjXTpnStOcm5SUxypOXyrmbJWo145JT g==; X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="386731696" X-IronPort-AV: E=Sophos;i="5.97,219,1669104000"; d="scan'208";a="386731696" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2023 20:35:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="691126309" X-IronPort-AV: E=Sophos;i="5.97,219,1669104000"; d="scan'208";a="691126309" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 15 Jan 2023 20:35:51 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 15 Jan 2023 20:35:51 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 15 Jan 2023 20:35:51 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 15 Jan 2023 20:35:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OtIXXRKIzga5GUsVDwf2AW/xoxN0OLGUD6KDempFGPJlq+QWSUF381htgRUjr2N5aZ/k217dyCILkVuHyuLPFjIfCiLLnIt7R8GCQEFHf2kSwieL1t33Gv/oo9kW8RAklTMJZZbC/2DUxut1KNmlFWfWpsSondlsL4b1BN7FKlUDhPqPj9MyiC4GnK2v33JDPCKYkrpc5/HRBgJFADa3wUHr3wp1gpGm/G1umeLelRpjmiohZ6zD8gio1UKNVkSVQqQFitpGUnzioDotWGErbFo7FN5pmUZa78xrzPFeXa+Ybe5IKU5PQk3qqEQUEkKm7hrG1GIqDwrAxL+jppYIaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hc0UTFvwVrimMqKah9x8WG6n84nUJLmw/EO3y96x414=; b=P+y8jeosysuCvMavako+pjHqdYOxTxa52YqW0jjjEDcr74ztEadvof76lWYLUhnCU/PcSTw/90IN1WbwTLowpBuKbVv7FDzEd139kCUHjGzeOE5Wvabi/PAE0rZL2M8C9w6BSVBg/JwKOIDzLaW4PJmT/KHtWjAHtsnj2KNIuvtB87FcAPz13rQzUWOCvTwpm5FAuZtXFnOpRE2iACdv8SJsBYLGfNhwcYhqMrcWS01av6qb9eMp3vR5yCMPT2zlPLiEyPoCnX0Io4GurI4FFos4cMGV1TdXVMbioroRlOVn/vmF+cLZHX+ZiIohTZcB6jK8V675cDUe2mh89hLipA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DS0PR11MB6328.namprd11.prod.outlook.com (2603:10b6:8:cc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Mon, 16 Jan 2023 04:35:47 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9%5]) with mapi id 15.20.5986.023; Mon, 16 Jan 2023 04:35:47 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: enable Hyper Encode Thread-Index: AQHZCObVl7fYOHl6mUOpWoMpXionr66gtjGA Date: Mon, 16 Jan 2023 04:35:47 +0000 Message-ID: <44d8a7999559fdd47a3bba5ef94625a458c95c55.camel@intel.com> References: <20221205201821.1879-1-artem.galin@intel.com> In-Reply-To: <20221205201821.1879-1-artem.galin@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|DS0PR11MB6328:EE_ x-ms-office365-filtering-correlation-id: f858a6b2-b35b-4b8b-23f2-08daf77b2363 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oajQ/E0lZALLLDKWXs3iB6CVZBsnGQRu9FHBsfF2LFBk+rvo4TV5GYx0WJg9AMOut/9/rNxDSP1mDwdmOyuIB7tP+On2oiuVTbx2bgFaaTdqA80TYbJWO9D54KYu1jFW38arKnIkjBp27WK7g34HeRY2tVFV99KeL+NgADouGsNJ4QIrQwXNuG0BXXFUJoiF6z2k0kW3G420Kl7hmEAjUNMrp7FWltqT18SgVO3muZ5IaFIfRGIooLFjRzjoZzeEHv6jPsqtgNWPbBJgNTTqp4FIQcZRGR+4kKZTUTgr6fIs3eF67MJy702apcSuEfBbWBQuuzHG/bX/t3Wc0LGvhqXp+8dpCwDTTov2cHCt+9kcNAQ+ccn8LNxICErK4EQlgnG8DubEr65wHJFqC0hAoa/hC/Qj/du+160aync2cTq9vlKvmFd2ndTVP/VWsfZ8SyKgEEThIXBsnHrNCscYWuTwyOi4DDf2gUmQqtYcMfN43C2mWsJvnaemJaUMbvVRJS9ZjsVnmhubdbRmoEvjIOnDnLlPId/efKyE7ZqYU2VX9aZbSRugKR8aKaE5Pd7e/rdKxUtRNWJXpwdo2Fwicd3hVVnQOuijtVSctrfBDCQxg2sxomaqXNJTQk0SQvF+HaSIiQDv2V0X8Aoy9By46Fguo+kk+5RV95i6VR+ZLJKQiGF10MO8LPMU/UP4NnSqYcKKZJ27uGu2t99K699Msm3RLxvGIT0Q8T1kmNVvjFdzCsszPCZFMqjJtARa0Fqn4doApxxgxeb81/JZju5OUspoyBW9KyYDuSFgUrlSyPg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(396003)(366004)(136003)(39860400002)(451199015)(19627235002)(316002)(71200400001)(41300700001)(8676002)(66946007)(76116006)(6916009)(64756008)(66556008)(36756003)(4326008)(66476007)(66446008)(86362001)(83380400001)(91956017)(82960400001)(38100700002)(38070700005)(122000001)(107886003)(478600001)(6486002)(966005)(2616005)(26005)(6512007)(6506007)(186003)(30864003)(2906002)(8936002)(5660300002)(460985005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cHVWYUVQTDZxbSs2UE5qY3lQcEl4NlZERHBsdzNoUENOczdHL3NxaXJwSXM0?= =?utf-8?B?QTFnaEpRaklUUTVuZno0ZnM3dGhvOWgvUEl1d2wyZlZTVTBVaktkc0RhMkR2?= =?utf-8?B?bXBDcldZZ0drdU94NU9TQ2h6d0ZJVnVNNVl2NHJEaHYwNjBWWlFkVks2MUFP?= =?utf-8?B?endpTytjRkJEQ01zMFFFKzlaVE1oK3BVd3JZc1FmSHA2ZmxsMUMwQ2xvNFpY?= =?utf-8?B?SWVjZWNJaGs4Sjl6TTZOOG1OM0t4NXUya1Z2YzM4ak1mNVFmZVdtbmd3WE55?= =?utf-8?B?NjFxaGxPT2M2ZmN3NnJwZmZEYnd2WmdNYU5kNkQrWXhFb1JCQkdKU3IzTzhh?= =?utf-8?B?c1RHWUsyUGl0TWdYbmNJZUNkOWRWVmNJTXlWdlc2Q0xhMmdqbDY5VXl6eVl4?= =?utf-8?B?S1lHOHI1b2hDMVZlRmloVkVObm8ycjhoei9ySkwyc095aGJBdzZUSHcwdk9C?= =?utf-8?B?dFJCZXE5OWVDV0VtVGllYTY5RGx1V0g2eFdNZm5WVk1xL1EvM3lOdVc4dStK?= =?utf-8?B?UlNIeHVZMXpBYWIyZmhHdERQbVF4RkJKQzMrN1RaZXhZbFk4SWttWVlkK2ts?= =?utf-8?B?OUVpb0toMERCT2JTa2F4aWNZeGJOaUNhRkRnaGFaYTVGd0JzWnB3YlYyZFZK?= =?utf-8?B?YTRnZUhQVmRpV1dnUTA4NHdkcGJkRG1mK21sNWpGbEt3VERxVXE2RGVhRGZZ?= =?utf-8?B?cm1KV0tSeW1hLzVRUG1UK1dTeVZwUUNhZ3JnaVlkdmVJa2t0MVQ0cHpYKytp?= =?utf-8?B?akYyejhyZ1hDelRUaXQ3QUpPeFRPQXhqOTZualZtQms3c2h0UE54WjJmQnJl?= =?utf-8?B?WDc0OUZWRmxPaEhJWEI4KzhwWnhGc3pKaTRZMVUvalhLUnRsZ3V5VmRoSDFo?= =?utf-8?B?V0N4R1A1L1hQWC8yWjRtL2RNSU1SN293UHJQNWttVHJYMEMrM1p5QklOVS9Y?= =?utf-8?B?NDFtb1JwbEhUL2l3bEVML2tyR1BRMkRWbnBkbnVnbVB1eFhsbExzbzBPQmVN?= =?utf-8?B?QUVtUE5TNmtlZzBsNXdhSXpGTmNBTWJNNTluY0U4cUtVVWtHeFJ2L0VhcXRV?= =?utf-8?B?bFM1Q2owQjFRaHdyZlh5TFFEZXNFeXI3NVptejFaV0d5Q29NdXF2L25ncGRQ?= =?utf-8?B?VVFSRGpZY1Vnb0hhNEpLaGtsYUxYY1o2ZENVYnlMWVJTSHp2d1ZpNnhzam9E?= =?utf-8?B?QTBhdFQ3UC8xc2VUb3BONEtjZ0ZlT2NEaDN1U0hYMDlBcTdyRFN5QnVDOGlN?= =?utf-8?B?NUlyOXdINEJiMHlIR2VJQ0VjVENQUHNvZlV6a0J4bFQyQjVpa3lXcG96ZnNw?= =?utf-8?B?RnZPTi83YVJIVmhPcUNzRDdKY0lOWEpUVXhUdHRGY2tXb1FEZVZCSitEMlpo?= =?utf-8?B?Y3ZDS202REk4K29obk5uVGNZK2MzanA5RXMyQWRiTkpVT2FkNy9PbWlLdytX?= =?utf-8?B?SjF3a3dHUlMzdFZTNHNWUFpPZy8va0IyNkZyckk4SStpMWUzVTRnL1FONE1T?= =?utf-8?B?SW9nZjlOK3BHSVFRM0JUMEROYkxPTEJPRnRtZGpURHVRMWpFa1ZVbVFkSjB3?= =?utf-8?B?N2FVMlVYanZvMi9ZdU9FclA3RTJ0SU90NGJaR2VNaWU2b25Xbk1YM0hvN2Zx?= =?utf-8?B?TzVvV29LTnVFdVZXYWd0bHNkTjNRNkRvWlk0S09qckk0VHNZbGIxL2pYYlhP?= =?utf-8?B?RGNyK1JhNUdCMnhKUmhMY1RBL3dyOUlMMGR5N0s5L1loajFoL2I2K3p5WmVM?= =?utf-8?B?ZzNGN2IxYW42Skx3SWErNXJHTlh6aW0ralJoZi9DWjNWOWQ4UXNQeXJmcFQy?= =?utf-8?B?cmdGdG91NStTRFJsSmNnWXpkaGZSNHd0K09Ta0ozWTVwRmpLSllsTDZ2Vzll?= =?utf-8?B?UVoyTU1MamRxUW9DVWlGbm16QjY3WlluRjJhMGJhZkN4d3RaUUlpN0JwVGw2?= =?utf-8?B?a3J0L3hiaVVGMVBBb2xtUmRKclBKbHIxaU1na2VWMHVNWVo3c1M3M0U5T2lL?= =?utf-8?B?QkE2c3ZKQzNXVnVrWU81RDZNb0kyNnBITlpZSkorUDkrYSszcnhZdWtIN2E5?= =?utf-8?B?a2FITUlpM2tmbWFvVHpjaS91WW1ickw3cWlqSEd1UllqU1J5VDlIbjdXeXBS?= =?utf-8?B?UmE3UEs4aUR6SU9vcVo1RnVjUEx6RjNKTlZjekZuYzdEUlMvc3dNWkp1emNV?= =?utf-8?B?Y2c9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f858a6b2-b35b-4b8b-23f2-08daf77b2363 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 04:35:47.2460 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1ikbw35UUqplqG5pV4sXxZn6Y7QMh32Cj23jURAm20JaoH/KaxAqHi4qXsHcUIyas5uT1CKRZdrkXcrrY2yupQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6328 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: enable Hyper Encode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Galin, Artem" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Ma, 2022-12-05 at 20:18 +0000, galinart wrote: > Hyper Encode uses Intel integrated and discrete graphics on one system > to accelerate encoding of a single video stream. > Depending on the selected parameters and codecs, performance gain on AlderLake > iGPU + ARC Gfx up to 1.6x. > > More information: > https://www.intel.co.uk/content/www/uk/en/architecture-and-technology/adaptix/deep-link.html > Developer guide: > https://github.com/oneapi-src/oneVPL-intel-gpu/blob/main/doc/HyperEncode_FeatureDeveloperGuide.md > > Hyper Encode is supported only on Windows and requires D3D11 and oneVPL. > > To enable Hyper Encode need to specify: > -Hyper Encode mode (-dual_gfx on or dual_gfx adaptive) > -Encoder: h264_qsv or hevc_qsv > -BRC: VBR, CQP or ICQ > -Lowpower mode (-low_power 1) > -Closed GOP for AVC or strict GOP for HEVC -idr_interval = 0 used by default > > Depending on the encoding parameters, the following parameters may need > to be adjusted: > -g recommended >= 30 for better performance > -async_depth recommended >= 30 for better performance > -extra_hw_frames recommended equal to async_depth value > -bf recommended = 0 for better performance > > In the cases with fast encoding (-preset veryfast) there may be no > performance gain due to the fact that the decode is slower than the encode. > > Command line examples: > > ffmpeg.exe -init_hw_device qsv:hw,child_device_type=d3d11va,child_device=0 -v > verbose -y -hwaccel qsv -extra_hw_frames 60 -async_depth 60 -c:v h264_qsv -i > bbb_sunflower_2160p_60fps_normal.mp4 > -async_depth 60 -c:v h264_qsv -preset medium -g 60 -low_power 1 -bf 0 > -dual_gfx on output.h265 > > Signed-off-by: galinart > --- > libavcodec/qsvenc.c | 91 +++++++++++++++++++++++++++++++++++++++- > libavcodec/qsvenc.h | 19 ++++++++- > libavcodec/qsvenc_h264.c | 3 ++ > libavcodec/qsvenc_hevc.c | 3 ++ > 4 files changed, 112 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index d5e9f2d420..96526d4579 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -169,6 +169,8 @@ do { \ > } \ > } while (0) \ > > +#define MFX_IMPL_VIA_MASK(impl) (0x0f00 & (impl)) > + > static const char *print_ratecontrol(mfxU16 rc_mode) > { > int i; > @@ -197,6 +199,10 @@ static void dump_video_param(AVCodecContext *avctx, > QSVEncContext *q, > mfxExtCodingOption2 *co2 = NULL; > mfxExtCodingOption3 *co3 = NULL; > mfxExtHEVCTiles *exthevctiles = NULL; > +#if QSV_HAVE_HE > + mfxExtHyperModeParam *exthypermodeparam = NULL; > +#endif > + > const char *tmp_str = NULL; > > if (q->co2_idx > 0) > @@ -208,6 +214,11 @@ static void dump_video_param(AVCodecContext *avctx, > QSVEncContext *q, > if (q->exthevctiles_idx > 0) > exthevctiles = (mfxExtHEVCTiles *)coding_opts[q->exthevctiles_idx]; > > +#if QSV_HAVE_HE > + if (q->exthypermodeparam_idx > 0) > + exthypermodeparam = (mfxExtHyperModeParam *)coding_opts[q- > >exthypermodeparam_idx]; > +#endif > + > av_log(avctx, AV_LOG_VERBOSE, "profile: %s; level: %"PRIu16"\n", > print_profile(avctx->codec_id, info->CodecProfile), info- > >CodecLevel); > > @@ -373,6 +384,21 @@ static void dump_video_param(AVCodecContext *avctx, > QSVEncContext *q, > av_log(avctx, AV_LOG_VERBOSE, "NumTileColumns: %"PRIu16"; > NumTileRows: %"PRIu16"\n", > exthevctiles->NumTileColumns, exthevctiles->NumTileRows); > } > + > +#if QSV_HAVE_HE > + if (exthypermodeparam) { > + av_log(avctx, AV_LOG_VERBOSE, "HyperEncode: "); > + > + if (exthypermodeparam->Mode == MFX_HYPERMODE_OFF) > + av_log(avctx, AV_LOG_VERBOSE, "OFF"); > + if (exthypermodeparam->Mode == MFX_HYPERMODE_ON) > + av_log(avctx, AV_LOG_VERBOSE, "ON"); > + if (exthypermodeparam->Mode == MFX_HYPERMODE_ADAPTIVE) > + av_log(avctx, AV_LOG_VERBOSE, "Adaptive"); > + > + av_log(avctx, AV_LOG_VERBOSE, "\n"); > + } > +#endif > } > > static void dump_video_vp9_param(AVCodecContext *avctx, QSVEncContext *q, > @@ -1154,6 +1180,54 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->extparam_internal[q->nb_extparam_internal++] = (mfxExtBuffer *)&q- > >extvsi; > } > > +#if QSV_HAVE_HE > + if (q->dual_gfx) { > + if (QSV_RUNTIME_VERSION_ATLEAST(q->ver, 2, 4)) { > + mfxIMPL impl; > + MFXQueryIMPL(q->session, &impl); > + > + if (MFX_IMPL_VIA_MASK(impl) != MFX_IMPL_VIA_D3D11) { > + av_log(avctx, AV_LOG_ERROR, "Dual GFX mode requires D3D11VA > \n"); > + return AVERROR_UNKNOWN; > + } > + if (q->param.mfx.LowPower != MFX_CODINGOPTION_ON) { > + av_log(avctx, AV_LOG_ERROR, "Dual GFX mode supports only low- > power encoding mode \n"); > + return AVERROR_UNKNOWN; > + } > + if (q->param.mfx.CodecId != MFX_CODEC_AVC && q->param.mfx.CodecId > != MFX_CODEC_HEVC) { > + av_log(avctx, AV_LOG_ERROR, "Not supported encoder for dual > GFX mode. " > + "Supported: h264_qsv and hevc_qsv > \n"); > + return AVERROR_UNKNOWN; > + } > + if (q->param.mfx.RateControlMethod != MFX_RATECONTROL_VBR && > + q->param.mfx.RateControlMethod != MFX_RATECONTROL_CQP && > + q->param.mfx.RateControlMethod != MFX_RATECONTROL_ICQ) { > + av_log(avctx, AV_LOG_WARNING, "Not supported BRC for dual GFX > mode. " > + "Supported: VBR, CQP and ICQ > \n"); > + } > + if ((q->param.mfx.CodecId == MFX_CODEC_AVC && q- > >param.mfx.IdrInterval != 0) || > + (q->param.mfx.CodecId == MFX_CODEC_HEVC && q- > >param.mfx.IdrInterval != 1)) { > + av_log(avctx, AV_LOG_WARNING, "Dual GFX mode requires closed > GOP for AVC and strict GOP for HEVC, -idr_interval 0 \n"); > + } > + if (q->param.mfx.GopPicSize < 30) { > + av_log(avctx, AV_LOG_WARNING, "For better performance in dual > GFX mode GopPicSize must be >= 30 \n"); > + } > + if (q->param.AsyncDepth < 30) { > + av_log(avctx, AV_LOG_WARNING, "For better performance in dual > GFX mode AsyncDepth must be >= 30 \n"); > + } > + > + q->exthypermodeparam.Header.BufferId = > MFX_EXTBUFF_HYPER_MODE_PARAM; > + q->exthypermodeparam.Header.BufferSz = sizeof(q- > >exthypermodeparam); > + q->exthypermodeparam.Mode = q->dual_gfx; > + q->extparam_internal[q->nb_extparam_internal++] = (mfxExtBuffer > *)&q->exthypermodeparam; > + } else { > + av_log(avctx, AV_LOG_ERROR, > + "This version of runtime doesn't support Hyper Encode\n"); > + return AVERROR_UNKNOWN; > + } > + } > +#endif > + > if (!check_enc_param(avctx,q)) { > av_log(avctx, AV_LOG_ERROR, > "some encoding parameters are not supported by the QSV " > @@ -1328,12 +1402,19 @@ static int qsv_retrieve_enc_params(AVCodecContext > *avctx, QSVEncContext *q) > .Header.BufferSz = sizeof(hevc_tile_buf), > }; > > - mfxExtBuffer *ext_buffers[6]; > +#if QSV_HAVE_HE > + mfxExtHyperModeParam hyper_mode_param_buf = { > + .Header.BufferId = MFX_EXTBUFF_HYPER_MODE_PARAM, > + .Header.BufferSz = sizeof(hyper_mode_param_buf), > + }; > +#endif > + > + mfxExtBuffer *ext_buffers[6 + QSV_HAVE_HE]; > > int need_pps = avctx->codec_id != AV_CODEC_ID_MPEG2VIDEO; > int ret, ext_buf_num = 0, extradata_offset = 0; > > - q->co2_idx = q->co3_idx = q->exthevctiles_idx = -1; > + q->co2_idx = q->co3_idx = q->exthevctiles_idx = q->exthypermodeparam_idx > = -1; > ext_buffers[ext_buf_num++] = (mfxExtBuffer*)&extradata; > ext_buffers[ext_buf_num++] = (mfxExtBuffer*)&co; > > @@ -1355,6 +1436,12 @@ static int qsv_retrieve_enc_params(AVCodecContext > *avctx, QSVEncContext *q) > q->exthevctiles_idx = ext_buf_num; > ext_buffers[ext_buf_num++] = (mfxExtBuffer*)&hevc_tile_buf; > } > +#if QSV_HAVE_HE > + if (q->dual_gfx && QSV_RUNTIME_VERSION_ATLEAST(q->ver, 2, 4)) { > + q->exthypermodeparam_idx = ext_buf_num; > + ext_buffers[ext_buf_num++] = (mfxExtBuffer*)&hyper_mode_param_buf; > + } > +#endif > > q->param.ExtParam = ext_buffers; > q->param.NumExtParam = ext_buf_num; > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > index a7bbb3797e..4a6fa2caed 100644 > --- a/libavcodec/qsvenc.h > +++ b/libavcodec/qsvenc.h > @@ -45,10 +45,12 @@ > #define QSV_HAVE_AVBR 1 > #define QSV_HAVE_VCM 1 > #define QSV_HAVE_MF 0 > +#define QSV_HAVE_HE QSV_VERSION_ATLEAST(2, 4) > #else > #define QSV_HAVE_AVBR 0 > #define QSV_HAVE_VCM 0 > #define QSV_HAVE_MF !QSV_ONEVPL > +#define QSV_HAVE_HE 0 > #endif > > #define QSV_COMMON_OPTS \ > @@ -64,6 +66,14 @@ > { "forced_idr", "Forcing I frames as IDR > frames", OFFSET(qsv.forced_idr), AV_OPT_TYPE_BOOL,{ .i64 = > 0 }, 0, 1, VE }, \ > { "low_power", "enable low power mode(experimental: many limitations by mfx > version, BRC modes, etc.)", OFFSET(qsv.low_power), AV_OPT_TYPE_BOOL, { .i64 = > -1}, -1, 1, VE}, > > +#if QSV_HAVE_HE > +#define QSV_HE_OPTIONS \ > +{ "dual_gfx", "Prefer processing on both iGfx and dGfx > simultaneously", OFFSET(qsv.dual_g > fx), AV_OPT_TYPE_INT, { .i64 = MFX_HYPERMODE_OFF }, MFX_HYPERMODE_OFF, > MFX_HYPERMODE_ADAPTIVE, VE, "dual_gfx" }, \ > +{ "off", "Disable HyperEncode > mode", > 0, AV_OPT_TYPE_CONST, { .i64 = MFX_HYPERMODE_OFF }, INT_MIN, > INT_MAX, VE, "dual_gfx" }, \ > +{ "on", "Enable HyperEncode mode and return error if incompatible > parameters during initialization", 0, AV_OPT_TYPE_CONST, { .i64 = > MFX_HYPERMODE_ON }, INT_MIN, INT_MAX, VE, "dual_gfx" }, \ > +{ "adaptive", "Enable HyperEncode mode or fallback to single GPU if > incompatible parameters during initialization", 0, AV_OPT_TYPE_CONST, { .i64 = > MFX_HYPERMODE_ADAPTIVE }, INT_MIN, INT_MAX, VE, "dual_gfx" }, > +#endif > + > #define QSV_OPTION_RDO \ > { "rdo", "Enable rate distortion > optimization", OFFSET(qsv.rdo), AV_OPT_TYPE_INT, { .i64 = -1 }, > -1, 1, VE }, > > @@ -171,7 +181,9 @@ typedef struct QSVEncContext { > mfxExtAV1TileParam extav1tileparam; > mfxExtAV1BitstreamParam extav1bsparam; > #endif > - > +#if QSV_HAVE_HE > + mfxExtHyperModeParam exthypermodeparam; > +#endif > #if QSV_HAVE_OPAQUE > mfxExtOpaqueSurfaceAlloc opaque_alloc; > mfxFrameSurface1 **opaque_surfaces; > @@ -180,7 +192,7 @@ typedef struct QSVEncContext { > > mfxExtVideoSignalInfo extvsi; > > - mfxExtBuffer *extparam_internal[5 + (QSV_HAVE_MF * 2) + > QSV_HAVE_EXT_AV1_PARAM * 2]; > + mfxExtBuffer *extparam_internal[5 + (QSV_HAVE_MF * 2) + > (QSV_HAVE_EXT_AV1_PARAM * 2) + QSV_HAVE_HE]; > int nb_extparam_internal; > > mfxExtBuffer **extparam; > @@ -255,6 +267,7 @@ typedef struct QSVEncContext { > int co2_idx; > int co3_idx; > int exthevctiles_idx; > + int exthypermodeparam_idx; > int vp9_idx; > > int max_qp_i; > @@ -299,6 +312,8 @@ typedef struct QSVEncContext { > // This is used for SEI Timing reset > int old_pic_timing_sei; > int skip_frame; > + // This is used for Hyper Encode > + int dual_gfx; > } QSVEncContext; > > int ff_qsv_enc_init(AVCodecContext *avctx, QSVEncContext *q); > diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c > index 0ff7356346..bac337198e 100644 > --- a/libavcodec/qsvenc_h264.c > +++ b/libavcodec/qsvenc_h264.c > @@ -117,6 +117,9 @@ static const AVOption options[] = { > QSV_OPTION_SCENARIO > QSV_OPTION_AVBR > QSV_OPTION_SKIP_FRAME > +#if QSV_HAVE_HE > + QSV_HE_OPTIONS > +#endif > > { "cavlc", "Enable > CAVLC", OFFSET(qsv.cavlc), AV_OPT_TYPE_BOOL > , { .i64 = 0 }, 0, 1, VE }, > #if QSV_HAVE_VCM > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > index e042263bf5..5e23ca9647 100644 > --- a/libavcodec/qsvenc_hevc.c > +++ b/libavcodec/qsvenc_hevc.c > @@ -318,6 +318,9 @@ static const AVOption options[] = { > QSV_OPTION_SCENARIO > QSV_OPTION_AVBR > QSV_OPTION_SKIP_FRAME > +#if QSV_HAVE_HE > + QSV_HE_OPTIONS > +#endif > > { "idr_interval", "Distance (in I-frames) between IDR frames", > OFFSET(qsv.idr_interval), AV_OPT_TYPE_INT, { .i64 = 0 }, -1, INT_MAX, VE, > "idr_interval" }, > { "begin_only", "Output an IDR-frame only at the beginning of the > stream", 0, AV_OPT_TYPE_CONST, { .i64 = -1 }, 0, 0, VE, "idr_interval" }, LGTM, will apply. -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".