From: "Rémi Denis-Courmont" <remi@remlab.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/h264chroma: RISC-V V add motion compensation for 8x8 chroma blocks
Date: Sat, 20 May 2023 12:59:34 +0300
Message-ID: <4481495.LvFx2qVVIh@basile.remlab.net> (raw)
In-Reply-To: <NVpLu1Y--3-9@lynne.ee>
Le perjantaina 19. toukokuuta 2023, 21.52.57 EEST Lynne a écrit :
> May 19, 2023, 19:16 by remi@remlab.net:
> > Le keskiviikkona 17. toukokuuta 2023, 17.54.22 EEST Lynne a écrit :
> >> Finally, run:
> >> make checkasm && ./tests/checkasm/checkasm --bench
> >> and report on the timings for both the C and assembly versions.
> >> If you've made a mistake somewhere, (forgot to restore stack, or a
> >> callee-saved register, or your function produces an incorrect result),
> >> checkasm will fail.
> >
> > To be fair, in this particular case, the stack pointer and saved registers
> > are never used, so the risk of messing those are zero.
> >
> > checkasm would of course verify that the function does that it is supposed
> > to do, and personally, I have kept off untested functions. But I am not
> > sure if it is fair to require adding test cases whilst other
> > architectures weren't required to have them.
>
> Other hardware exists, and even without checkasm, bugs are found
> through fate.
There are exactly two FATE RISC-V instances of which exactly zero support
vectors to date, so the chance for FATE to find bugs there is nul. I do
appreciate that checkasm would make revectoring of the patchset easier and
safer though.
That said, the argument is moot seen as you seem to have posted a fix.
--
Реми Дёни-Курмон
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-20 9:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 7:13 Arnie Chang
2023-05-17 14:54 ` Lynne
2023-05-18 8:20 ` Arnie Chang
2023-05-18 12:53 ` Ronald S. Bultje
2023-05-18 16:56 ` Lynne
2023-05-19 17:15 ` Rémi Denis-Courmont
2023-05-19 18:52 ` Lynne
2023-05-20 9:59 ` Rémi Denis-Courmont [this message]
2023-05-20 10:03 ` Rémi Denis-Courmont
2023-05-19 17:12 ` Rémi Denis-Courmont
2023-05-22 14:15 ` Arnie Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4481495.LvFx2qVVIh@basile.remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git