[FFmpeg-devel] retriggering patchwork for failed fate tests?

[FFmpeg-devel] retriggering patchwork for failed fate tests?

[Ronan Waide]

hi folks,

I submitted a patch yesterday which seems to have failed automated `make fate` tests in a place unrelated to the patch (https://patchwork.ffmpeg.org/check/114511/, https://patchwork.ffmpeg.org/check/114513/). I saw a few other patches also failing in this same way - it looks like some libavcodec/tests files contain deprecated usages. I've since seen other patches submitted without tripping over this, so I'm not sure if the failures were triggered specifically by touching files in libavcodec, or if this was an unrelated failure that's since been fixed. `make fate` runs fine on my laptop, but I'm on apple silicon and the failing builds are x86/loongarch64.

What is the correct etiquette here? It seems like my patch may not be at fault, so I could just submit a v5 and see what happens, but that feels like potentially wasting time if it's just going to hit the same problem.

Cheers,
Waider.
-- 
Ronan Waide
waider@waider.ie




_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] retriggering patchwork for failed fate tests?

[Frank Plowman]

On 02/03/2025 08:31, Ronan Waide wrote:
> hi folks,
> 
> I submitted a patch yesterday which seems to have failed automated `make fate` tests in a place unrelated to the patch (https://patchwork.ffmpeg.org/check/114511/, https://patchwork.ffmpeg.org/check/114513/). I saw a few other patches also failing in this same way - it looks like some libavcodec/tests files contain deprecated usages. I've since seen other patches submitted without tripping over this, so I'm not sure if the failures were triggered specifically by touching files in libavcodec, or if this was an unrelated failure that's since been fixed. `make fate` runs fine on my laptop, but I'm on apple silicon and the failing builds are x86/loongarch64.
> 
> What is the correct etiquette here? It seems like my patch may not be at fault, so I could just submit a v5 and see what happens, but that feels like potentially wasting time if it's just going to hit the same problem.
> 
> Cheers,
> Waider.

Hi Waider,

Thank you for your patch.

I wouldn't worry too much about resubmitting the patch at this point.
As you noticed, all the other patches submitted around the same time
failed in the same way, so the failure isn't evidence of a breakage in
your changes.  If a reviewer has is concerned your changes may break
something, they could run FATE themselves or request you resubmit the
patch at that point.  It doesn't look as though your patch touches
anything arch-specific, so I think if FATE passes on AArch64, then
there's a good change it will also pass on x86_64.

All the best,
Frank

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".