From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B802D45DB8 for ; Mon, 12 Jun 2023 09:08:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DAEC868C3BD; Mon, 12 Jun 2023 12:08:14 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EBBA168C3A2 for ; Mon, 12 Jun 2023 12:08:08 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 35C987Bq023281-35C987Br023281; Mon, 12 Jun 2023 12:08:07 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 74F6FA145F; Mon, 12 Jun 2023 12:08:07 +0300 (EEST) Date: Mon, 12 Jun 2023 12:08:07 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <8d881143-3f72-3aee-375-9254f993ee25@martin.st> Message-ID: <447363ef-336a-be80-d697-b69ba939cc6@martin.st> References: <20230604041756.5196-1-Logan.Lyu@myais.com.cn> <20230604041756.5196-3-Logan.Lyu@myais.com.cn> <8d881143-3f72-3aee-375-9254f993ee25@martin.st> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 3/5] lavc/aarch64: new optimization for 8-bit hevc_epel_uni_w_v X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Logan Lyu Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-15"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 12 Jun 2023, Martin Storsj=F6 wrote: > On Sun, 4 Jun 2023, Logan.Lyu@myais.com.cn wrote: > >> From: Logan Lyu >> = >> Signed-off-by: Logan Lyu >> --- >> libavcodec/aarch64/hevcdsp_epel_neon.S | 504 ++++++++++++++++++++++ >> libavcodec/aarch64/hevcdsp_init_aarch64.c | 6 + >> 2 files changed, 510 insertions(+) >> = >> diff --git a/libavcodec/aarch64/hevcdsp_epel_neon.S = >> b/libavcodec/aarch64/hevcdsp_epel_neon.S >> index fe494dd843..4841f49dab 100644 >> --- a/libavcodec/aarch64/hevcdsp_epel_neon.S >> +++ b/libavcodec/aarch64/hevcdsp_epel_neon.S > > >> +function ff_hevc_put_hevc_epel_uni_w_v48_8_neon, export=3D1 >> + stp q8, q9, [sp, #-32] >> + stp q10, q11, [sp, #-64] > > This backs up values on the stack without decrementing the stack pointer, = > i.e. storing it in the red zone. Whether this is supported depends on the = > platform ABI. Linux and macOS have a 128 byte red zone on aarch64, while = > Windows only has 16 bytes. So for portability, don't rely on a red zone a= t = > all. > > I.e., here please decrement the stack pointer like in a previous patch: > > stp q8, q9, [sp, #-64]! > stp q10, q11, [sp, #32] > > And inversely when restoring it. Oh, and another detail here. You don't need to back up and restore the = whole q8-q15 registers, it's enough to restore the lower 64 bits of it, so = you can do stp d8, d9, [sp, #-32] stp d10, d11, [sp, #16] in this case. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".