From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0D43046DC7 for ; Tue, 11 Jul 2023 22:02:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9C7C968C5DB; Wed, 12 Jul 2023 01:01:59 +0300 (EEST) Received: from smtp-fw-52003.amazon.com (smtp-fw-52003.amazon.com [52.119.213.152]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9A78868C2E0 for ; Wed, 12 Jul 2023 01:01:52 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.it; i=@amazon.it; q=dns/txt; s=amazon201209; t=1689112918; x=1720648918; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=2gOnToOUdRAkUu2IUYHT6OL5EzZ0AK/jgJnMZQfg7p8=; b=pQYxtwkiEiuArZeQ2frNZ2qIV6fw18+GAdiYsgmeG08wpFpcFvqfz8PO 8Wp63DXjUDKv0J8xZYKFZIhUggSlIPJbxtfUK5J4FB5nAV4H86kck/cQw RahFaK6vp0ozQ24y9ENZAwnlXyzvlWAqHlKevNkMDc/vHQY1tqZBJArJ8 U=; X-IronPort-AV: E=Sophos;i="6.01,197,1684800000"; d="scan'208";a="595743506" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-pdx-2a-m6i4x-44b6fc51.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-52003.iad7.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 22:01:50 +0000 Received: from EX19D009EUA002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-pdx-2a-m6i4x-44b6fc51.us-west-2.amazon.com (Postfix) with ESMTPS id 03F45A0C1E for ; Tue, 11 Jul 2023 22:01:48 +0000 (UTC) Received: from EX19D025EUC002.ant.amazon.com (10.252.61.247) by EX19D009EUA002.ant.amazon.com (10.252.50.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 11 Jul 2023 22:01:45 +0000 Received: from EX19D025EUC002.ant.amazon.com (10.252.61.247) by EX19D025EUC002.ant.amazon.com (10.252.61.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 11 Jul 2023 22:01:44 +0000 Received: from EX19D025EUC002.ant.amazon.com ([fe80::c9fe:e3a8:dd4f:e087]) by EX19D025EUC002.ant.amazon.com ([fe80::c9fe:e3a8:dd4f:e087%3]) with mapi id 15.02.1118.030; Tue, 11 Jul 2023 22:01:44 +0000 From: "Carotti, Elias" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 2/2] lavc/libx264: add mb_info option Thread-Index: AQHZtENHEpQ1a8jUPUiiufkhHQ5rtQ== Date: Tue, 11 Jul 2023 22:01:44 +0000 Message-ID: <4426e94299f1460aa9b7c76fd5cba7ee@amazon.it> References: <5a7631c93df03c86dd079376a0690b13a049b473.camel@amazon.it> <168890085522.542.1128745243112426352@lain.khirnov.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.21.151.21] MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/libx264: add mb_info option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > +2023-06-21 - xxxxxxxxxx - lavc 60.23.100 - libx264.c > + Add mb_info option. > Do we actually need the option? If the encoder's caller bothered with adding the side data, then I'd think it should always be used, otherwise why is it even there? >I agree, I just thought I had to update that file as well, if that's not the case feel free to remove it. >Best >Elias On a second thought, though, I think I misinterpreted your mail and I wrongly thought you were referring only to the APIchanges file. The thing is that libx264 expects a boolean value (b_mb_info) to be set to check the mb_info. So, yes, in principle I'd agree with you but I think we still need to tell it in advance by setting the option because the encoder needs to track additional statistics. >From x264.h: int b_mb_info; /* Use input mb_info data in x264_picture_t */ and then subsequent uses both in frame.h and analyse.c check for the flag to be set. Further on, this flag doesn't seem to be updated by the x264_encoder_reconfig(..) method, so the only possibility I see is setting it in advance in the setup phase. Best Elias NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".