From: "Carotti, Elias" <eliascrt@amazon.it>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/libx264: add mb_info option
Date: Tue, 11 Jul 2023 22:01:44 +0000
Message-ID: <4426e94299f1460aa9b7c76fd5cba7ee@amazon.it> (raw)
In-Reply-To: <b5a68fd5de914849994633e24fcc1595@amazon.it>
> +2023-06-21 - xxxxxxxxxx - lavc 60.23.100 - libx264.c
> + Add mb_info option.
> Do we actually need the option? If the encoder's caller bothered with adding the side data, then I'd think it should always be used, otherwise why is it even there?
>I agree, I just thought I had to update that file as well, if that's not the case feel free to remove it.
>Best
>Elias
On a second thought, though, I think I misinterpreted your mail and I wrongly thought you were referring only to the APIchanges file.
The thing is that libx264 expects a boolean value (b_mb_info) to be set to check the mb_info.
So, yes, in principle I'd agree with you but I think we still need to tell it in advance by setting the option because the encoder needs to track additional statistics.
From x264.h:
int b_mb_info; /* Use input mb_info data in x264_picture_t */
and then subsequent uses both in frame.h and analyse.c check for the flag to be set.
Further on, this flag doesn't seem to be updated by the x264_encoder_reconfig(..) method, so the only possibility I see is setting it in advance in the setup phase.
Best
Elias
NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-11 22:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 15:57 Carotti, Elias
2023-07-03 15:55 ` Carotti, Elias
2023-07-09 11:07 ` Anton Khirnov
2023-07-11 10:46 ` Carotti, Elias
2023-07-11 22:01 ` Carotti, Elias [this message]
2023-08-08 8:11 ` Stefano Sabatini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4426e94299f1460aa9b7c76fd5cba7ee@amazon.it \
--to=eliascrt@amazon.it \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git