From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 61C3147990 for ; Thu, 28 Dec 2023 00:57:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D248568C58B; Thu, 28 Dec 2023 02:57:00 +0200 (EET) Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B9FF068BDD0 for ; Thu, 28 Dec 2023 02:56:53 +0200 (EET) Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5945ba54d54so1990914eaf.3 for ; Wed, 27 Dec 2023 16:56:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703725011; x=1704329811; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=40i2UTEJsDZx6kDSmRfhesXIX1MA9Sw/x/chFd8q7+E=; b=YDcPgpECBck1Hoe5gDJbURWQVlMpOiCh5PW4bdFDmmCxCu3KKxTzjuCm67aAhIdtLi 1hy89BBh08CzmWMZGTQ347VEQhHAImbguIkhbGQ+LybJN9NQhnHYYJnzBcCpfyeuOvV/ 2EduBBuskTn1NhrGrMOtHnGdOcNrridd7HkLe5Kba9qurkzag0jttqqjMmGjImVZTuyh sFaDZgr/oIot9dQ+zBtRlLgVSklJF6GqQP1agwoi4eMdzT6BKiQRMbJ4NOyhbOBNfurS t62mjNL7T2Z24J4m9UCTTJ10VKBGE8gxOkQ7nG85r4QgMQW/xkn/MabRRyAyzkGnViUz 01iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703725011; x=1704329811; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=40i2UTEJsDZx6kDSmRfhesXIX1MA9Sw/x/chFd8q7+E=; b=CIk1dTW5JZAJnQFuhcsFHtf5wY/bko5ftcbQTiLYH9G6wbDH68aYhFrbeRi186N+1Q f/jhJWJHVVvRspDBJZBoZShyT30tyv0+G6GSKwyLTuppiNpt232Z7XhSeOPRLEcIiSOt Z6gGhOrnVw82FNQcgfQ8aF+BLPXOqif7xWRCLcy24uC90PeNOZNCLlZID4MNDy15OiuB 1ljeYIBqMCySkxGO3/2FUDpuL+TMBEzlXvqN9BwBXtgNnqpDNw5asVuRiOWEpRLHWDHQ ZL0d6qHVYWEs3t3xm7B5h+IcyBJ97elB4/WgZ83Bq+QMOE/31RPNVtcfA4p5KcAfRJFZ sj6A== X-Gm-Message-State: AOJu0YzlPDMWZeuw2DGWnxQJyw9RxaMzB4wndbvDKcn/FeqTbpINGaWU 1+/iIRR70fqnW6pTef52/Jxfj3vHggY= X-Google-Smtp-Source: AGHT+IFE/9ll6GAeicpxywphzH7mNFbEy/tjWpYLv3F30JJOAfwmzPV+mquerPWTKs+D7TnVLkq5fA== X-Received: by 2002:a05:6358:281e:b0:173:5cd:6094 with SMTP id k30-20020a056358281e00b0017305cd6094mr9619716rwb.34.1703725010979; Wed, 27 Dec 2023 16:56:50 -0800 (PST) Received: from [192.168.0.13] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id 7-20020a17090a198700b0028bcc2a47e9sm16627094pji.38.2023.12.27.16.56.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Dec 2023 16:56:50 -0800 (PST) Message-ID: <4425335c-a8d6-448f-9387-676e593ad3b8@gmail.com> Date: Wed, 27 Dec 2023 21:57:19 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20231226162033.782945-1-stefasab@gmail.com> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add quirc filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/27/2023 8:20 PM, Stefano Sabatini wrote: > On date Wednesday 2023-12-27 14:16:24 -0300, James Almer wrote: >> On 12/27/2023 8:37 AM, Stefano Sabatini wrote: >>> On date Tuesday 2023-12-26 22:33:36 -0300, James Almer wrote: >>>> On 12/26/2023 10:25 PM, Stefano Sabatini wrote: >>>>> On date Tuesday 2023-12-26 17:20:33 +0100, Stefano Sabatini wrote: >>>>>> --- >>>>>> Changelog | 1 + >>>>>> configure | 4 + >>>>>> doc/filters.texi | 35 ++++++++ >>>>>> libavfilter/Makefile | 1 + >>>>>> libavfilter/allfilters.c | 1 + >>>>>> libavfilter/vf_quirc.c | 183 +++++++++++++++++++++++++++++++++++++++ >>>>>> 6 files changed, 225 insertions(+) >>>>>> create mode 100644 libavfilter/vf_quirc.c >>>>> >>>>> V2 with a few fixes and all corners put in the metadata (e.g. in case >>>>> the QR code is rotated). >>>> >>> >>>> Looking at the library, the license is very permissive and the code hasn't >>>> been touched in many years. It is also pretty small, so why not just add it >>>> as a native filter instead of requiring an external dependency for what >>>> seems to be a relatively simple process? >>> >>> I see pros and cons, in total that would be about 3K lines of pretty >>> clean code and data, and this would simplify integration for end-users >>> (since they would not need to build the library, which seems not >>> packaged by many distributions), and having the code would help to >>> solve similar problems and probably could be generalized and optimized >>> (e.g. to support other pixel formats). >>> >>> OTOH it would add to the maintenance burden since we would be owners >>> of the code, which also means we would not benefit from fixes to the >>> upstream project, in case they happen (last commit is from March >>> 2023, so not very old): >>> https://github.com/dlbeer/quirc/commit/542848dd6b9b0eaa9587bbf25b9bc67bd8a71fca >> >> That's a build system change, so not really relevant. Last real change was https://github.com/dlbeer/quirc/commit/cc673124335785d220dbb9057b21c51e4a87e0b2, >> also from March 2023, but the one before it is from August 2021. >> > >> I really think this should be ported as a native filter. It's not big and >> complex like a scaler (sws, zscale) which should not live within >> libavfilter. > >> Any change can be contributed back to libquirc > > This is not realistic, given that a reimplementation would be possibly > completely refactored to fit into FFmpeg. > >> (A library >> that's not going to be abandoned like it happened with libdcadec after it >> was merged into lavc, > > OTOH, this library is quite outside the scope of the FFmpeg, so it > makes sense to keep it as external dependency. This is a quite > different use case than a decoder, a QR-decoder library can make sense > outside of a multimedia library, for a decoder you would need a > complete multimedia library anyway. > > I was checking the code, and porting would be a serious effort and > comprise several thousands lines of code (against the moderate effort > of wrapping it - which is already done), also some of the logic would > not really fit into FFmpeg because it is quite specific to this > application domain (QR code decoding), so it makes sense for it to > live within an external library. Not to mention that this would be > a duplication of effort. Image analysis is within FFmpeg's scope, which QR code identification and decoding would be about. > > *Unless* someone is willing to port/reimplement the code, but this > should not be a blocker for the wrapper and can be done as a separate > step. No, i'm not blocking anything. Just stating that ideally this would be a native module. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".