* [FFmpeg-devel] [PATCH] avformat/vpcc: fix vpcC generation for RTMP
@ 2023-09-02 16:59 Alessandro Ros
0 siblings, 0 replies; 3+ messages in thread
From: Alessandro Ros @ 2023-09-02 16:59 UTC (permalink / raw)
To: ffmpeg-devel
In order to send VP9 tracks with RTMP, the enhanced RTMP specification
tells that VPCodecConfigurationRecord, a.k.a. vpcC ISO-BMFF box, must
be inserted into a metadata message. However, the function responsible
for generating vpcCs currently returns invalid boxes, that are lacking
the Version and Flag fields, inherited from FullBox. For some reason,
both flags were being added manually in movenc. This patch fixes the
issue.
Signed-off-by: Alessandro Ros <aler9.dev@gmail.com>
---
libavformat/movenc.c | 3 ---
libavformat/vpcc.c | 2 ++
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 7ef6cef46a..696ae5a6c9 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -1441,10 +1441,7 @@ static int mov_write_vpcc_tag(AVFormatContext *s,
AVIOContext *pb, MOVTrack *tra
avio_wb32(pb, 0);
ffio_wfourcc(pb, "vpcC");
- avio_w8(pb, 1); /* version */
- avio_wb24(pb, 0); /* flags */
ff_isom_write_vpcc(s, pb, track->vos_data, track->vos_len,
track->par);
-
return update_size(pb, pos);
}
diff --git a/libavformat/vpcc.c b/libavformat/vpcc.c
index ea66959abf..256407dd6d 100644
--- a/libavformat/vpcc.c
+++ b/libavformat/vpcc.c
@@ -208,6 +208,8 @@ int ff_isom_write_vpcc(AVFormatContext *s,
AVIOContext *pb,
if (ret < 0)
return ret;
+ avio_w8(pb, 1); /* version */
+ avio_wb24(pb, 0); /* flags */
avio_w8(pb, vpcc.profile);
avio_w8(pb, vpcc.level);
avio_w8(pb, (vpcc.bitdepth << 4) | (vpcc.chroma_subsampling << 1)
| vpcc.full_range_flag);
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/vpcc: fix vpcC generation for RTMP
2023-09-02 17:02 Alessandro Ros
@ 2023-09-02 17:09 ` James Almer
0 siblings, 0 replies; 3+ messages in thread
From: James Almer @ 2023-09-02 17:09 UTC (permalink / raw)
To: ffmpeg-devel
On 9/2/2023 2:02 PM, Alessandro Ros wrote:
> In order to send VP9 tracks with RTMP, the enhanced RTMP specification
> tells that VPCodecConfigurationRecord, a.k.a. vpcC ISO-BMFF box, must
> be inserted into a metadata message. However, the function responsible
> for generating vpcCs currently returns invalid boxes, that are lacking
> the Version and Flag fields, inherited from FullBox. For some reason,
> both flags were being added manually in movenc. This patch fixes the
> issue.
>
> Signed-off-by: Alessandro Ros <aler9.dev@gmail.com>
> ---
> libavformat/movenc.c | 3 ---
> libavformat/vpcc.c | 2 ++
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 7ef6cef46a..696ae5a6c9 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -1441,10 +1441,7 @@ static int mov_write_vpcc_tag(AVFormatContext *s,
> AVIOContext *pb, MOVTrack *tra
> avio_wb32(pb, 0);
> ffio_wfourcc(pb, "vpcC");
> - avio_w8(pb, 1); /* version */
> - avio_wb24(pb, 0); /* flags */
> ff_isom_write_vpcc(s, pb, track->vos_data, track->vos_len,
> track->par);
> -
> return update_size(pb, pos);
> }
>
> diff --git a/libavformat/vpcc.c b/libavformat/vpcc.c
> index ea66959abf..256407dd6d 100644
> --- a/libavformat/vpcc.c
> +++ b/libavformat/vpcc.c
> @@ -208,6 +208,8 @@ int ff_isom_write_vpcc(AVFormatContext *s,
> AVIOContext *pb,
> if (ret < 0)
> return ret;
>
> + avio_w8(pb, 1); /* version */
> + avio_wb24(pb, 0); /* flags */
> avio_w8(pb, vpcc.profile);
> avio_w8(pb, vpcc.level);
> avio_w8(pb, (vpcc.bitdepth << 4) | (vpcc.chroma_subsampling << 1)
> | vpcc.full_range_flag);
This will change the output of the flv muxer. It might be for the
better, since now both these values will be added to it, but it would be
best to know that first.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* [FFmpeg-devel] [PATCH] avformat/vpcc: fix vpcC generation for RTMP
@ 2023-09-02 17:02 Alessandro Ros
2023-09-02 17:09 ` James Almer
0 siblings, 1 reply; 3+ messages in thread
From: Alessandro Ros @ 2023-09-02 17:02 UTC (permalink / raw)
To: ffmpeg-devel
In order to send VP9 tracks with RTMP, the enhanced RTMP specification
tells that VPCodecConfigurationRecord, a.k.a. vpcC ISO-BMFF box, must
be inserted into a metadata message. However, the function responsible
for generating vpcCs currently returns invalid boxes, that are lacking
the Version and Flag fields, inherited from FullBox. For some reason,
both flags were being added manually in movenc. This patch fixes the
issue.
Signed-off-by: Alessandro Ros <aler9.dev@gmail.com>
---
libavformat/movenc.c | 3 ---
libavformat/vpcc.c | 2 ++
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 7ef6cef46a..696ae5a6c9 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -1441,10 +1441,7 @@ static int mov_write_vpcc_tag(AVFormatContext *s,
AVIOContext *pb, MOVTrack *tra
avio_wb32(pb, 0);
ffio_wfourcc(pb, "vpcC");
- avio_w8(pb, 1); /* version */
- avio_wb24(pb, 0); /* flags */
ff_isom_write_vpcc(s, pb, track->vos_data, track->vos_len,
track->par);
-
return update_size(pb, pos);
}
diff --git a/libavformat/vpcc.c b/libavformat/vpcc.c
index ea66959abf..256407dd6d 100644
--- a/libavformat/vpcc.c
+++ b/libavformat/vpcc.c
@@ -208,6 +208,8 @@ int ff_isom_write_vpcc(AVFormatContext *s,
AVIOContext *pb,
if (ret < 0)
return ret;
+ avio_w8(pb, 1); /* version */
+ avio_wb24(pb, 0); /* flags */
avio_w8(pb, vpcc.profile);
avio_w8(pb, vpcc.level);
avio_w8(pb, (vpcc.bitdepth << 4) | (vpcc.chroma_subsampling << 1)
| vpcc.full_range_flag);
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-02 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-02 16:59 [FFmpeg-devel] [PATCH] avformat/vpcc: fix vpcC generation for RTMP Alessandro Ros
2023-09-02 17:02 Alessandro Ros
2023-09-02 17:09 ` James Almer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git