From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/4 v8] avformat/mov: add support for tile HEIF still images
Date: Sun, 11 Feb 2024 18:10:06 -0300
Message-ID: <441254d0-a01d-4791-b251-34708999ab48@gmail.com> (raw)
In-Reply-To: <f779bd1f-ada4-44fa-9c77-f48799e1159e@gmail.com>
On 2/11/2024 6:08 PM, James Almer wrote:
> On 2/11/2024 5:41 PM, Michael Niedermayer wrote:
>> On Sun, Feb 11, 2024 at 03:56:59PM -0300, James Almer wrote:
>>> Export tiles as streams, and the grid information as a Stream Group
>>> of type
>>> TILE_GRID.
>>> This also enables exporting other stream items like thumbnails, which
>>> may be
>>> present in non tiled HEIF images too.
>>>
>>> Based on a patch by Swaraj Hota
>>>
>>> Signed-off-by: James Almer <jamrial@gmail.com>
>>> ---
>>> libavformat/avformat.c | 8 +
>>> libavformat/avformat.h | 6 +
>>> libavformat/dump.c | 2 +
>>> libavformat/internal.h | 5 +
>>> libavformat/isom.h | 16 +-
>>> libavformat/mov.c | 492 +++++++++++++++++++++++++++++++++++++----
>>> 6 files changed, 484 insertions(+), 45 deletions(-)
>>
>> git dislikes this:
>>
>> git am -3
>>
>> Applying: avformat/mov: add support for tile HEIF still images
>> error: sha1 information is lacking or useless (libavformat/avformat.c).
>> error: could not build fake ancestor
>> Patch failed at 0001 avformat/mov: add support for tile HEIF still images
>> Use 'git am --show-current-patch' to see the failed patch
>> When you have resolved this problem, run "git am --continue".
>> If you prefer to skip this patch, run "git am --skip" instead.
>> To restore the original branch and stop patching, run "git am --abort".
>
> I can't reproduce this. Tried to apply the patches as sent to the ml and
> they still apply.
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=10765 shows no
issues.
I also pushed it to https://github.com/jamrial/FFmpeg/commits/heif_new/
so you can test it.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-11 21:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 18:56 [FFmpeg-devel] [PATCH 1/4 v10] avformat: add a Tile Grid stream group type James Almer
2024-02-11 18:56 ` [FFmpeg-devel] [PATCH 2/4 v8] avformat/mov: add support for tile HEIF still images James Almer
2024-02-11 20:41 ` Michael Niedermayer
2024-02-11 21:08 ` James Almer
2024-02-11 21:10 ` James Almer [this message]
2024-02-11 22:14 ` Michael Niedermayer
2024-02-16 12:50 ` Anton Khirnov
2024-02-16 16:35 ` James Almer
2024-02-16 17:32 ` Anton Khirnov
2024-02-11 18:57 ` [FFmpeg-devel] [PATCH 3/4 v7] fate/mov: test remuxing all stream heif items James Almer
2024-02-11 18:57 ` [FFmpeg-devel] [PATCH 4/4 v2] fate/mov: add tests for HEIF samples with derived images James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441254d0-a01d-4791-b251-34708999ab48@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git