Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros

[James Almer <jamrial@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1452 bytes --]

On 5/7/2025 2:57 PM, softworkz . wrote:
> 
> 
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Andreas
>> Rheinhardt
>> Sent: Mittwoch, 7. Mai 2025 13:59
>> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
>> Subject: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and
>> av_assume() macros
>>
>> Patches attached.
>>
>> - Andreas
> 
> Hi Andreas,
> 
> from https://ffmpeg.org/developer.html#Submitting-patches-1
> 
> "..ensure the correct mime type is used (text/x-diff or text/x-patch or at least text/plain) and that only one patch is inline or attached per mail."
> 
> I'm saying that because the way you are submitting, Patchwork only ever recognizes the first attached patch, so - in this case - the remaining 20 patches are not checked by the CI runs.
> It's also difficult to review patches that are submitted in this way, even more difficult to respond, as that requires to copy the patch into a text editor first, in order to add some synthetic quote marks ("> ") and when replying, it isn't clear to which of the patches the reply is corresponding to.
> 
> As long as there's no migration to a better way, why not try out making PRs to https://github.com/ffstaging/FFmpeg?

I doubt "ffstaging" is affiliated with the project in any capacity.
He can make a MR to the Forgejo instance once we enable it for that purpose.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".