From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3966E46E9C for ; Mon, 18 Sep 2023 23:31:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 55A7068C864; Tue, 19 Sep 2023 02:31:11 +0300 (EEST) Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 915DB68C6D8 for ; Tue, 19 Sep 2023 02:31:04 +0300 (EEST) Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-6bf2427b947so2896881a34.3 for ; Mon, 18 Sep 2023 16:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695079862; x=1695684662; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zrWg4xFJASKZ2mZ9UAn7x2MMwPjw4nQrBYU/b3eFb3g=; b=Upprt/EulyyFuwHGdB9H7D+grQB3r7VfHQc0ZIV4AsgntJt6BMlf+H5Ayihyb5yJr5 duCLdeBE9u5JcGFy+TyozLjIBIWUbbbY2ebGEB4uDrzQoyDsin6r0H9pwBk5DCyb7G0n nZdD+sG/pBhUWx8QS3Mv+In5AwM22n7sQVoxaVajwGpVuZDo0sESo37UvFQpsLXmnuin Lj3IXMj5k9dVgzO5ac3y4DahAxToDtVm/QEZ1KcZBabOZZVQXUE4BKYxR54hBXZG8/1Y IirbkJQ2i03x20yvZQQ478L2eDGa7n2Rh05OtImi+sgzEnIHsT4hUMrmRaphBzL5CuSC 4XqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695079862; x=1695684662; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zrWg4xFJASKZ2mZ9UAn7x2MMwPjw4nQrBYU/b3eFb3g=; b=Ldd1Kfb8sCeBaBqY7YCT+QSVQXAMSbWUsm/AYbJx7Wk3Wj2k0q8tMuClzmIKJNXeuD K4GJUxgUOcl12uke79a1xO3+q4QGpI7npUIytYOngOx9hux+InU7ma0qyMRzuojlsLls uPtvCnv38MV5aN/xZwRfrJsz3/AAmbOqneXLapobFulbCmyTXAEMpPHfOdT3Rwr6Mpuu t5gqWMjTTxq3cVIVq8WWKCsOFsjrSfL5Gh84NaJgA/HJx2xjud8+aFbVPvzwM1PNfhYz Ly0F3vdI3USP3WfQLhvEIyVMT54ee5xiTaNX0wsYkvVN4fvc9kCKLAZLD8codG0iVahj mNVg== X-Gm-Message-State: AOJu0Ywekjux6hscTiDmHJ+XvEEN44kZcYhqZ/VFAVAJ2NUy2G/bc48R JBKjKzO3Uvr7QGoqerz91DgyLzYcGq0= X-Google-Smtp-Source: AGHT+IHUIdSwNHxJwGmKbxx3NvJTzugT+BWa8evnxalwK+qY7hs7BkYrtWVDmLRB7L/X6RloO4PziA== X-Received: by 2002:a9d:6a8a:0:b0:6bc:be56:6b9b with SMTP id l10-20020a9d6a8a000000b006bcbe566b9bmr10246438otq.2.1695079861905; Mon, 18 Sep 2023 16:31:01 -0700 (PDT) Received: from [192.168.0.10] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id o2-20020a4a2c02000000b0056c81dedb3bsm5074256ooo.8.2023.09.18.16.31.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 16:31:01 -0700 (PDT) Message-ID: <43a6c010-6c47-a388-7136-3d150a4941b9@gmail.com> Date: Mon, 18 Sep 2023 20:30:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230918223534.23567-1-michael@niedermayer.cc> <20230918223534.23567-5-michael@niedermayer.cc> From: James Almer In-Reply-To: <20230918223534.23567-5-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/decode: EAGAIN is not fully supported in decode_simple_internal() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/18/2023 7:35 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/decode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index 169ee79acd9..376e4a4d373 100644 > --- a/libavcodec/decode.c > +++ b/libavcodec/decode.c > @@ -457,6 +457,7 @@ FF_ENABLE_DEPRECATION_WARNINGS > if (ret == AVERROR(EAGAIN)) > av_frame_unref(frame); > > + av_assert0(consumed != AVERROR(EAGAIN)); // code later will add AVERROR(EAGAIN) to a pointer FF_CODEC_CB_TYPE_DECODE decoders must not return EAGAIN or EOF, only actual error codes. IMO that should be stated too. > if (consumed < 0) > ret = consumed; > if (consumed >= 0 && avctx->codec->type == AVMEDIA_TYPE_VIDEO) LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".