From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/decode: EAGAIN is not fully supported in decode_simple_internal()
Date: Mon, 18 Sep 2023 20:30:58 -0300
Message-ID: <43a6c010-6c47-a388-7136-3d150a4941b9@gmail.com> (raw)
In-Reply-To: <20230918223534.23567-5-michael@niedermayer.cc>
On 9/18/2023 7:35 PM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/decode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavcodec/decode.c b/libavcodec/decode.c
> index 169ee79acd9..376e4a4d373 100644
> --- a/libavcodec/decode.c
> +++ b/libavcodec/decode.c
> @@ -457,6 +457,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
> if (ret == AVERROR(EAGAIN))
> av_frame_unref(frame);
>
> + av_assert0(consumed != AVERROR(EAGAIN)); // code later will add AVERROR(EAGAIN) to a pointer
FF_CODEC_CB_TYPE_DECODE decoders must not return EAGAIN or EOF, only
actual error codes. IMO that should be stated too.
> if (consumed < 0)
> ret = consumed;
> if (consumed >= 0 && avctx->codec->type == AVMEDIA_TYPE_VIDEO)
LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-09-18 23:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 22:35 [FFmpeg-devel] [PATCH 1/5] tools/target_dec_fuzzer: Adjust wmapro threshold Michael Niedermayer
2023-09-18 22:35 ` [FFmpeg-devel] [PATCH 2/5] avcodec/apedec: Fix an integer overflow in predictor_update_filter() Michael Niedermayer
2023-09-18 22:35 ` [FFmpeg-devel] [PATCH 3/5] avcodec/dcadec: Do not explode EAGAIN Michael Niedermayer
2023-09-18 23:24 ` James Almer
2023-09-19 18:18 ` Michael Niedermayer
2023-09-18 22:35 ` [FFmpeg-devel] [PATCH 4/5] avcodec/escape124: Do not return random numbers Michael Niedermayer
2023-09-18 22:35 ` [FFmpeg-devel] [PATCH 5/5] avcodec/decode: EAGAIN is not fully supported in decode_simple_internal() Michael Niedermayer
2023-09-18 23:30 ` James Almer [this message]
2023-09-19 18:24 ` Michael Niedermayer
2023-10-03 14:34 ` [FFmpeg-devel] [PATCH 1/5] tools/target_dec_fuzzer: Adjust wmapro threshold Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43a6c010-6c47-a388-7136-3d150a4941b9@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git