From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1C81F4A21E for ; Wed, 24 Apr 2024 21:28:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C863468D370; Thu, 25 Apr 2024 00:28:15 +0300 (EEST) Received: from btbn.de (btbn.de [144.76.60.213]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 763AE68BDE1 for ; Thu, 25 Apr 2024 00:28:09 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 36DF028190F0C for ; Wed, 24 Apr 2024 23:28:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1713994088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FjAeSYzcdzwOjaHwFKJgvoAsDXGtIXHF6wnT6K1EBOA=; b=U6R18TYPLkRktNpJLYL8rE017Z0IcTx/li3OeW4BeUsijBn2/MBOP8EgsgLSs6nZ5ubb0O tHH8QYGMfQHOIxzT/pqqpdgiaUSUMLfZoFq6ePcMQDzmPFjN8zEPncQ8xaAdt+87H8nO4Y 9zb/JxkS1Tty2jkgK05HRl6Ud+xtZLVuWSxrjeF6BG9nWwAiZXUhlkq9EB4ahL8qjtm8iS qrMyUEMBaPoI/XjL6kGalu/nmQDO0KN6zv13+CKzrlM7BZIZj064pECDoH22fh4R1AkfJ7 wxSXufNtep8Xyy78HFgidqPcebgv+Uisc42ZD2TOhp8+dSaZ3SHN65FXeRiHdA== Message-ID: <439620ac-f50f-4c2f-b272-e158a228fb5d@rothenpieler.org> Date: Wed, 24 Apr 2024 23:28:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240424200117.1659-1-timo@rothenpieler.org> Content-Language: en-US From: Timo Rothenpieler In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] fate: allow https for git URLs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 24.04.2024 22:53, Alexander Strasser via ffmpeg-devel wrote: > On 2024-04-24 22:26 +0200, Timo Rothenpieler wrote: >> On 24.04.2024 22:12, Alexander Strasser via ffmpeg-devel wrote: >>> On 2024-04-24 22:01 +0200, Timo Rothenpieler wrote: >>>> --- >>>> tests/fate.sh | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/tests/fate.sh b/tests/fate.sh >>>> index c5ee18de80..4081e865ae 100755 >>>> --- a/tests/fate.sh >>>> +++ b/tests/fate.sh >>>> @@ -30,14 +30,14 @@ lock(){ >>>> checkout(){ >>>> case "$repo" in >>>> file:*|/*) src="${repo#file:}" ;; >>>> - git:*) git clone --quiet --branch "$branch" "$repo" "$src" ;; >>>> + git:*|https:*) git clone --quiet --branch "$branch" "$repo" "$src" ;; >>>> esac >>>> } >>>> >>>> update()( >>>> cd ${src} || return >>>> case "$repo" in >>>> - git:*) git fetch --quiet --force && git reset --quiet --hard "origin/$branch" ;; >>>> + git:*|https:*) git fetch --quiet --force && git reset --quiet --hard "origin/$branch" ;; >>>> esac >>>> ) >>> >> >> If you manually clone the repo, you can use whatever you like anyway, since > > Sorry my initial wording was probably ambiguous. > > I meant in the repo variable in a fate_config.sh > > >> it never actually uses the URL for anything after the initial clone. > > The URL isn't used per se, but it's used to decide whether to > git fetch or not inside the call to update, isn't it? > Yeah, that's pretty much the only thing it's used for. I also considered to turn the check around, and always assume it's a valid git URL unless the file: thingy is recognized. That way ssh URLs and cloning from local paths would become possible. But that runs a higher risk of breaking someones setup. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".