Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr
@ 2024-05-31 17:51 Rémi Denis-Courmont
  2024-05-31 18:23 ` Lynne via ffmpeg-devel
  2024-05-31 19:30 ` James Almer
  0 siblings, 2 replies; 6+ messages in thread
From: Rémi Denis-Courmont @ 2024-05-31 17:51 UTC (permalink / raw)
  To: ffmpeg-devel

---
 tests/checkasm/lpc.c | 57 ++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 55 insertions(+), 2 deletions(-)

diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
index 592e34c03d..62232fdaf7 100644
--- a/tests/checkasm/lpc.c
+++ b/tests/checkasm/lpc.c
@@ -16,6 +16,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "libavutil/avassert.h"
 #include "libavutil/mem_internal.h"
 
 #include "libavcodec/lpc.h"
@@ -57,10 +58,51 @@ static void test_window(int len)
     bench_new(src, len, dst1);
 }
 
+#if !ARCH_X86
+static void test_compute_autocorr(ptrdiff_t len, int lag)
+{
+    const double eps = EPS * (double)len;
+    LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]);
+    LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]);
+    LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]);
+
+    declare_func(void, const double *in, ptrdiff_t len, int lag, double *out);
+
+    av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER);
+
+    for (int i = 0; i < MAX_LPC_ORDER; i++)
+        src[i] = 0.;
+
+    src += MAX_LPC_ORDER;
+
+    for (int i = 0; i < 5000 + 2; i++) {
+        src[i] = (double)rnd() / (double)UINT_MAX;
+    }
+
+    call_ref(src, len, lag, dst0);
+    call_new(src, len, lag, dst1);
+
+    for (size_t i = 0; i <= lag; i++) {
+        if (!double_near_abs_eps(dst0[i], dst1[i], eps)) {
+            fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
+                    i, dst0[i], dst1[i], dst0[i] - dst1[i]);
+            fail();
+            break;
+        }
+    }
+
+    bench_new(src, 4608, lag, dst1);
+}
+#endif
+
 void checkasm_check_lpc(void)
 {
     LPCContext ctx;
-    int len = rnd() % 5000;
+    int len = 2000 + rnd() % 3000;
+#if !ARCH_X86
+    static const int lags[] = { 8, 12, };
+#endif
+
     ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
 
     if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) {
@@ -72,6 +114,17 @@ void checkasm_check_lpc(void)
         test_window(len | 1);
     }
     report("apply_welch_window_odd");
-
     ff_lpc_end(&ctx);
+
+#if !ARCH_X86
+    for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
+        ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT);
+        if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i])) {
+            test_compute_autocorr(len & ~1, lags[i]);
+            test_compute_autocorr(len | 1, lags[i]);
+        }
+        ff_lpc_end(&ctx);
+    }
+    report("compute_autocorr");
+#endif
 }
-- 
2.45.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr
  2024-05-31 17:51 [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr Rémi Denis-Courmont
@ 2024-05-31 18:23 ` Lynne via ffmpeg-devel
  2024-05-31 18:29   ` Rémi Denis-Courmont
  2024-05-31 19:30 ` James Almer
  1 sibling, 1 reply; 6+ messages in thread
From: Lynne via ffmpeg-devel @ 2024-05-31 18:23 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Lynne


[-- Attachment #1.1.1.1: Type: text/plain, Size: 3026 bytes --]

On 31/05/2024 19:51, Rémi Denis-Courmont wrote:
> ---
>   tests/checkasm/lpc.c | 57 ++++++++++++++++++++++++++++++++++++++++++--
>   1 file changed, 55 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
> index 592e34c03d..62232fdaf7 100644
> --- a/tests/checkasm/lpc.c
> +++ b/tests/checkasm/lpc.c
> @@ -16,6 +16,7 @@
>    * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>    */
>   
> +#include "libavutil/avassert.h"
>   #include "libavutil/mem_internal.h"
>   
>   #include "libavcodec/lpc.h"
> @@ -57,10 +58,51 @@ static void test_window(int len)
>       bench_new(src, len, dst1);
>   }
>   
> +#if !ARCH_X86
> +static void test_compute_autocorr(ptrdiff_t len, int lag)
> +{
> +    const double eps = EPS * (double)len;
> +    LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]);
> +    LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]);
> +    LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]);
> +
> +    declare_func(void, const double *in, ptrdiff_t len, int lag, double *out);
> +
> +    av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER);
> +
> +    for (int i = 0; i < MAX_LPC_ORDER; i++)
> +        src[i] = 0.;
> +
> +    src += MAX_LPC_ORDER;
> +
> +    for (int i = 0; i < 5000 + 2; i++) {
> +        src[i] = (double)rnd() / (double)UINT_MAX;
> +    }
> +
> +    call_ref(src, len, lag, dst0);
> +    call_new(src, len, lag, dst1);
> +
> +    for (size_t i = 0; i <= lag; i++) {
> +        if (!double_near_abs_eps(dst0[i], dst1[i], eps)) {
> +            fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
> +                    i, dst0[i], dst1[i], dst0[i] - dst1[i]);
> +            fail();
> +            break;
> +        }
> +    }
> +
> +    bench_new(src, 4608, lag, dst1);
> +}
> +#endif
> +
>   void checkasm_check_lpc(void)
>   {
>       LPCContext ctx;
> -    int len = rnd() % 5000;
> +    int len = 2000 + rnd() % 3000;

Please don't randomize the length in tests. Pick a few lengths to check 
all corner cases.
Checkasm tests should be deterministic in how long it takes to run them 
between invocations.

> +#if !ARCH_X86
> +    static const int lags[] = { 8, 12, };
> +#endif
> +
>       ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
>   
>       if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) {
> @@ -72,6 +114,17 @@ void checkasm_check_lpc(void)
>           test_window(len | 1);
>       }
>       report("apply_welch_window_odd");
> -
>       ff_lpc_end(&ctx);
> +
> +#if !ARCH_X86
> +    for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
> +        ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT);
> +        if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i])) {
> +            test_compute_autocorr(len & ~1, lags[i]);
> +            test_compute_autocorr(len | 1, lags[i]);
> +        }
> +        ff_lpc_end(&ctx);
> +    }
> +    report("compute_autocorr");
> +#endif
>   }


[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr
  2024-05-31 18:23 ` Lynne via ffmpeg-devel
@ 2024-05-31 18:29   ` Rémi Denis-Courmont
  2024-05-31 19:28     ` Lynne via ffmpeg-devel
  0 siblings, 1 reply; 6+ messages in thread
From: Rémi Denis-Courmont @ 2024-05-31 18:29 UTC (permalink / raw)
  To: ffmpeg-devel

Le perjantaina 31. toukokuuta 2024, 21.23.43 EEST Lynne via ffmpeg-devel a 
écrit :
> Please don't randomize the length in tests. Pick a few lengths to check 
> all corner cases.
> Checkasm tests should be deterministic in how long it takes to run them 
> between invocations.

I agree, but that problem was introduced by 
a1c6f4b653b6fca51eea40f12a22ab1cb045751d, and I have no pretense to fix it in 
this patch.

Frankly, this test has outlived its usefulness for my purposes and I have had 
enough rebasing it again and again and again and again and again due to mostly 
external problems. As far as I am concerned, this is now dropped.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr
  2024-05-31 18:29   ` Rémi Denis-Courmont
@ 2024-05-31 19:28     ` Lynne via ffmpeg-devel
  2024-05-31 19:34       ` Rémi Denis-Courmont
  0 siblings, 1 reply; 6+ messages in thread
From: Lynne via ffmpeg-devel @ 2024-05-31 19:28 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Lynne


[-- Attachment #1.1.1.1: Type: text/plain, Size: 767 bytes --]

On 31/05/2024 20:29, Rémi Denis-Courmont wrote:
> Le perjantaina 31. toukokuuta 2024, 21.23.43 EEST Lynne via ffmpeg-devel a
> écrit :
>> Please don't randomize the length in tests. Pick a few lengths to check
>> all corner cases.
>> Checkasm tests should be deterministic in how long it takes to run them
>> between invocations.
> 
> I agree, but that problem was introduced by
> a1c6f4b653b6fca51eea40f12a22ab1cb045751d, and I have no pretense to fix it in
> this patch.
> 
> Frankly, this test has outlived its usefulness for my purposes and I have had
> enough rebasing it again and again and again and again and again due to mostly
> external problems. As far as I am concerned, this is now dropped.

Are you going to submit a new test, or?


[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr
  2024-05-31 17:51 [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr Rémi Denis-Courmont
  2024-05-31 18:23 ` Lynne via ffmpeg-devel
@ 2024-05-31 19:30 ` James Almer
  1 sibling, 0 replies; 6+ messages in thread
From: James Almer @ 2024-05-31 19:30 UTC (permalink / raw)
  To: ffmpeg-devel

On 5/31/2024 2:51 PM, Rémi Denis-Courmont wrote:
> ---
>   tests/checkasm/lpc.c | 57 ++++++++++++++++++++++++++++++++++++++++++--
>   1 file changed, 55 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
> index 592e34c03d..62232fdaf7 100644
> --- a/tests/checkasm/lpc.c
> +++ b/tests/checkasm/lpc.c
> @@ -16,6 +16,7 @@
>    * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>    */
>   
> +#include "libavutil/avassert.h"
>   #include "libavutil/mem_internal.h"
>   
>   #include "libavcodec/lpc.h"
> @@ -57,10 +58,51 @@ static void test_window(int len)
>       bench_new(src, len, dst1);
>   }
>   
> +#if !ARCH_X86
> +static void test_compute_autocorr(ptrdiff_t len, int lag)
> +{
> +    const double eps = EPS * (double)len;
> +    LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]);
> +    LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]);
> +    LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]);
> +
> +    declare_func(void, const double *in, ptrdiff_t len, int lag, double *out);
> +
> +    av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER);
> +
> +    for (int i = 0; i < MAX_LPC_ORDER; i++)
> +        src[i] = 0.;
> +
> +    src += MAX_LPC_ORDER;
> +
> +    for (int i = 0; i < 5000 + 2; i++) {
> +        src[i] = (double)rnd() / (double)UINT_MAX;
> +    }
> +
> +    call_ref(src, len, lag, dst0);
> +    call_new(src, len, lag, dst1);
> +
> +    for (size_t i = 0; i <= lag; i++) {
> +        if (!double_near_abs_eps(dst0[i], dst1[i], eps)) {
> +            fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
> +                    i, dst0[i], dst1[i], dst0[i] - dst1[i]);
> +            fail();
> +            break;
> +        }
> +    }
> +
> +    bench_new(src, 4608, lag, dst1);
> +}
> +#endif
> +
>   void checkasm_check_lpc(void)
>   {
>       LPCContext ctx;
> -    int len = rnd() % 5000;
> +    int len = 2000 + rnd() % 3000;
> +#if !ARCH_X86
> +    static const int lags[] = { 8, 12, };
> +#endif
> +
>       ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
>   
>       if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) {
> @@ -72,6 +114,17 @@ void checkasm_check_lpc(void)
>           test_window(len | 1);
>       }
>       report("apply_welch_window_odd");
> -
>       ff_lpc_end(&ctx);
> +
> +#if !ARCH_X86
> +    for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
> +        ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT);
> +        if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i])) {
> +            test_compute_autocorr(len & ~1, lags[i]);
> +            test_compute_autocorr(len | 1, lags[i]);

I'll apply this patch by splitting this into two separate tests, and 
disabling the x86 one on odd lengths for now.

> +        }
> +        ff_lpc_end(&ctx);
> +    }
> +    report("compute_autocorr");
> +#endif
>   }
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr
  2024-05-31 19:28     ` Lynne via ffmpeg-devel
@ 2024-05-31 19:34       ` Rémi Denis-Courmont
  0 siblings, 0 replies; 6+ messages in thread
From: Rémi Denis-Courmont @ 2024-05-31 19:34 UTC (permalink / raw)
  To: ffmpeg-devel

Le perjantaina 31. toukokuuta 2024, 22.28.03 EEST Lynne via ffmpeg-devel a 
écrit :
> > Frankly, this test has outlived its usefulness for my purposes and I have
> > had
 enough rebasing it again and again and again and again and again due
> > to mostly external problems. As far as I am concerned, this is now
> > dropped.
> 
> Are you going to submit a new test, or?

I do not know what to do and no motivation to figure it out, so no.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-05-31 19:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-31 17:51 [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr Rémi Denis-Courmont
2024-05-31 18:23 ` Lynne via ffmpeg-devel
2024-05-31 18:29   ` Rémi Denis-Courmont
2024-05-31 19:28     ` Lynne via ffmpeg-devel
2024-05-31 19:34       ` Rémi Denis-Courmont
2024-05-31 19:30 ` James Almer

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git