From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 909574383F for ; Sat, 1 Oct 2022 11:24:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7654E68BAEF; Sat, 1 Oct 2022 14:24:34 +0300 (EEST) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7195468B7B9 for ; Sat, 1 Oct 2022 14:24:28 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 2A360225C93 for ; Sat, 1 Oct 2022 13:24:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1664623467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=25CDlQe0F4lF5HhydQ6LBScpdoa0ovHKrs3XY4itD6A=; b=dtTvQitdQhtRXns0/hhmZYHR/Qa0MpprvaVTXMcegBmK6QNfvtfeaoHoOV0+AXfJ7D6aDH gcaPd8cugRqxrvYALGT3VApVtztW0WP7bx9HiP3gqzs06J5mCL1fZhJbyaPthfCzrUI/7l UgKmU3XobhAlhso3iUi69QYbxDAl8id7QsuHWgi//eq2nbA6UQ8kYmtykBeu69xz4dW4JW D/YpnHnmcfMCdxdfP7C9hoIBHbCb02cn2yEFZsHzHpD5d+DOztnVgKHeIN0n0FQbArt53k pQ9fXzOy17Db8aTpkZeSZ8VKdrrCHYLIY3bYJebsqngCC96mGh4+EUGWYh+G6Q== Message-ID: <4369be7d-a656-9c0f-0596-68740b42d345@rothenpieler.org> Date: Sat, 1 Oct 2022 13:24:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 To: ffmpeg-devel@ffmpeg.org References: <20221001061341.662-1-ovchinnikov.dmitrii@gmail.com> Content-Language: en-US From: Timo Rothenpieler In-Reply-To: <20221001061341.662-1-ovchinnikov.dmitrii@gmail.com> Subject: Re: [FFmpeg-devel] [crop support for matroska demuxer 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 01.10.2022 08:13, OvchinnikovDmitrii wrote: > --- > libavcodec/avcodec.h | 8 ++++++++ > libavcodec/codec_par.h | 8 ++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 7365eb5cc0..66df571afc 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -585,6 +585,14 @@ typedef struct AVCodecContext { > */ > int coded_width, coded_height; > > + /** > + * The dimensions of the crop, usually from container. > + */ > + int crop_top; > + int crop_left; > + int crop_bottom; > + int crop_right; > + Shouldn't these be added at the very end, to not break ABI? I'm also not very convinced this kind of information really belongs into AVCodecContext and codecpar. Can't it just be frame-sidedata? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".