From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [crop support for matroska demuxer 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters.
Date: Sat, 1 Oct 2022 13:24:26 +0200
Message-ID: <4369be7d-a656-9c0f-0596-68740b42d345@rothenpieler.org> (raw)
In-Reply-To: <20221001061341.662-1-ovchinnikov.dmitrii@gmail.com>
On 01.10.2022 08:13, OvchinnikovDmitrii wrote:
> ---
> libavcodec/avcodec.h | 8 ++++++++
> libavcodec/codec_par.h | 8 ++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 7365eb5cc0..66df571afc 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -585,6 +585,14 @@ typedef struct AVCodecContext {
> */
> int coded_width, coded_height;
>
> + /**
> + * The dimensions of the crop, usually from container.
> + */
> + int crop_top;
> + int crop_left;
> + int crop_bottom;
> + int crop_right;
> +
Shouldn't these be added at the very end, to not break ABI?
I'm also not very convinced this kind of information really belongs into
AVCodecContext and codecpar.
Can't it just be frame-sidedata?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-01 11:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 6:13 OvchinnikovDmitrii
2022-10-01 6:13 ` [FFmpeg-devel] [crop support for matroska demuxer 2/3] libavcodec: Public code to support container crop OvchinnikovDmitrii
2022-10-01 7:16 ` Hendrik Leppkes
2022-10-04 11:35 ` Anton Khirnov
2022-10-01 6:13 ` [FFmpeg-devel] [crop support for matroska demuxer 3/3] libavformat\matroskadec.c: crop support for matroska demuxer OvchinnikovDmitrii
2022-10-01 7:06 ` [FFmpeg-devel] [crop support for matroska demuxer 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters Hendrik Leppkes
2022-10-04 11:49 ` James Almer
2022-10-07 15:12 ` Dmitrii Ovchinnikov
2022-10-01 11:24 ` Timo Rothenpieler [this message]
2022-10-04 11:34 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4369be7d-a656-9c0f-0596-68740b42d345@rothenpieler.org \
--to=timo@rothenpieler.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git