Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* Re: [FFmpeg-devel] Politics
@ 2021-12-20 13:48 Daniel Cantarín
  0 siblings, 0 replies; 30+ messages in thread
From: Daniel Cantarín @ 2021-12-20 13:48 UTC (permalink / raw)
  To: ffmpeg-devel

> 
> The more the focus is moving to "a single frame" doesn't matter,
> the more will that conversation create the impression that my patchset
> would be lacking precision.
> 

This is a possibility, indeed.

Yet, the less one answers, the more it also looks like the issue is dead
and/or some argument was the last word on the issue. Neither are the
case. Also, there's the constant claim of "you didn't listened to me";
not answering surely leads to that effect, and answering puts the burden
of proof to the people stating the hypothetical issue.

OTOH, people here could be very knowledgeable and experienced, thus
actually maybe being onto something. Debating fantasy scenarios could be
a chore and even a waste of time, but asking for proper input files is
not, and this gives the oportunity to deal with such possible tests.

No input files so far, of course, as I also do believe the
"frame-perfect serious issue" is simply not real: not any problem in
your code, not any real-life use case. We'll see if anyone brings such
real example, with files to test.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: [FFmpeg-devel] Politics
@ 2021-12-20 16:27 Daniel Cantarín
  0 siblings, 0 replies; 30+ messages in thread
From: Daniel Cantarín @ 2021-12-20 16:27 UTC (permalink / raw)
  To: ffmpeg-devel

> 
> I am not sure the direction from which you approuch this is going to
> increase the chances this patch has.
> 

Me neither.

But I can barely talk about ffmpeg internals: they're huge, and I know
the little bits I'm familiar with, having some experience with filters.
So, whatever argument I may have come from use cases experience and not
from ffmpeg internals knowledge.

That's why I don't deny there may be issues with softworkz code. But I
can say when the critics are presenting unreal use cases as some kind of
proof of a problem.


> 
> All stream types in libavformat/codec are timebase based, that was
> done because its exact (for some definition of exact at least)
> 
> I think you should argue why this is the best way forward not why its
> not too bad
> 

No, I don't think that's the case.
I recognize what you say has ground. Thing is, what I do does too.

It's not about it being "not too bad", but about it working were no
other code is present, and nothing being broken by it. You may speak
about ffmpeg internals, I speak about real life use cases, both are
valid considerations.

Your (and others) criticism against the patchset seems legit. However,
softworkz has been dealing with such criticism from months now, he has
been sustaining that what he did was neccessary, and suspiciously every
single example against that seems to be unreal. So, softworkz may be
wrong somehow, but the devs are clearly exaggerating about the supposed
consequences of such wrongness. Why? Devs here are experts. Why would
they need to exaggerate like this? I say something's fishy.

I understand devs may have biases towards norms, standard or otherwise,
but I find it hard to believe that somebody experienced in software
development would not accept a patch if it adds use cases and doesn't
break any previously implemented one, specially when the proper way to
implement it was object of debate for a decade without anybody doing it.
That's no small detail. And this patchset is no small feat. This is
special, not norm.

I'm doing tests from my side, by the way: it's not about "just approve
it". I see the thing working, and I'm looking for problems when somebody
say there's a problem. That's why I also discuss what I believe to be
fantasy problems: I respect the devs claims, even if I don't believe in
it. But this "frame-perfect serious problem" is clearly an exaggeration,
and that says something about arguments against the patchset.

Breaking something is the real issue here IMO, and not some clearly
unachievable purity, whatever the reason of the unachievability. I
pretend to intervene here with that logic in mind. If that doesn't help,
so be it.

In any case, devs biases will be there no matter what I say. So it's not
really about me: it's about softworkz against the ffmpeg devs community.
I just happen to want the use cases, and find this patchset working.


> 
> also in a few places where a fixed timebase is used ffmpeg uses
> AV_TIME_BASE_Q which is micro not milli seconds. That suddenly
> allows exactly addressing individual frames and audio samples.
> And it should be easy to change to from ms, its just a *1000
> it would weaken the precission argument
> 

Then softworkz would most likely adapt the code. He doesn't seem to be
reluctant to apply small modifications in order to be approved. Yet,
again and again he claims it's not that easy, and we get back to unreal
examples. This part I don't understand yet, as my time and knowledge are
both limited. But, with time, I will; if the patch doesn't die, perhaps
we'll find its way to be implemented. I just hope softworkz doesn't get
burned.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: [FFmpeg-devel] Politics
@ 2021-12-20 14:06 Daniel Cantarín
  2021-12-20 15:23 ` Michael Niedermayer
  0 siblings, 1 reply; 30+ messages in thread
From: Daniel Cantarín @ 2021-12-20 14:06 UTC (permalink / raw)
  To: ffmpeg-devel


> 
> consider a subtitle track
> consider 2 video tracks for US 30000/1001 fps and EU 25 fps
> 
> the 6th frame in the US track is at  0.2002 sec, the 5th in the EU 
> track at 0.2sec
> 
> 
> if these differ and you want a subtitle to either stop displaying after 
> the
> earlier or begin displaying after the earlier reliably. Then you need a
> timebase that can represent points within each such close encounter of 
> frame
> times.
> 

So, this isn't a subtitle problem if subtitle timings are correct. You
let 0.2002 in the subtitle, players will decide the frame. You want to
match the frame with the content, then you transcode the video properly.
Am I losing something?

Then again, we're of course not discussing players. One may say "that's
not ffmpeg responsability", yet players are 90% of the time the main
reason we have to do any extra work with ffmpeg. If we discuss real
life scenarios, we should be discussing players.

I also fail to see why would somebody want a "frame-perfect" sync
between two videos with different FPS. That's absurd: there's no such
thing as "frame-perfect" in such scenarios. What you would want is video
timings to be honored. That is: FPS conversion to be faithful to video
timings and content. I can imagine such precision dealing with frames
being blurred and having to do lots of fine tuning in order to be able
to perceive a single frame off in subtitles. That would be the real
problematic situation, not any .0002 rounding.

So, I see your example as a case of "what would the player do with that
0.2002 rounding" (in which case, we all know there would be two
different subtitle files/streams with different precision for each
video if it's THAT important) instead of "we need to change the timebase
to something 4 decimals precise multiplier to both videos".

And even if this fails and a frame is interpreted incorrectly in the
player, good luck finding anyone saying anything about it: nobody cares
about a single frame when it's about subtitles. People watching
subtitles are simply not looking at that. This isn't speedrunning: it's
translating and transcribing. People wants to understand what's going on
in the screen, not debugging video frames.

So, I see no "serious subtitle problem" nor anything close to
"unnaceptable" here.

Let's remark, as softworkz say, this are all fantasy scenarios, and the
patchset doesn't show any real precision problem so far. If anyone is
willing to share input files to test such possible precision problems,
I'm willing to do the tests. No such files so far.


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 30+ messages in thread
[parent not found: <8dbfd345-c661-459e-b242-94830107eae3@www.fastmail.com>]

end of thread, other threads:[~2021-12-22 20:17 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 13:48 [FFmpeg-devel] Politics Daniel Cantarín
  -- strict thread matches above, loose matches on Subject: below --
2021-12-20 16:27 Daniel Cantarín
2021-12-20 14:06 Daniel Cantarín
2021-12-20 15:23 ` Michael Niedermayer
2021-12-22 13:29   ` Soft Works
2021-12-22 19:54     ` Michael Niedermayer
2021-12-22 20:17       ` Soft Works
     [not found] <8dbfd345-c661-459e-b242-94830107eae3@www.fastmail.com>
     [not found] ` <DM8P223MB0365510C72E8CFEF027FF97FBA749@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
     [not found]   ` <MqpKkF_--7-2@lynne.ee>
     [not found]     ` <DM8P223MB0365FEDCCEFB370D20979CF5BA749@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
     [not found]       ` <c2f7048d-a1b6-253e-8a50-7fdf9a34ada3@canta.com.ar>
     [not found]         ` <DM8P223MB036596CACBB6509CB1AE78CBBA759@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
     [not found]           ` <CAPYw7P64=axtAC0-8Ux+1d+f8WEseuWk9OkhmbAnNWp-eRpq8A@mail.gmail.com>
2021-12-15 13:34             ` Soft Works
2021-12-18 10:26               ` Paul B Mahol
2021-12-18 11:34                 ` Soft Works
2021-12-18 13:32                   ` Lynne
2021-12-18 14:28                     ` Soft Works
2021-12-18 15:16                       ` Lynne
2021-12-18 15:43                         ` Soft Works
2021-12-18 17:53                           ` Lynne
2021-12-18 18:16                             ` Daniel Cantarín
2021-12-18 18:30                               ` Hendrik Leppkes
2021-12-18 18:49                                 ` Soft Works
2021-12-18 20:05                                 ` Daniel Cantarín
2021-12-18 20:41                                   ` Soft Works
2021-12-19 15:16                                     ` Michael Niedermayer
2021-12-19 18:23                                       ` Soft Works
2021-12-19 18:31                                         ` Soft Works
2021-12-20 14:49                                           ` Michael Niedermayer
2021-12-20 22:35                                             ` Soft Works
2021-12-20 23:20                                               ` Soft Works
2021-12-21 18:38                                                 ` Michael Niedermayer
2021-12-22 10:23                                                   ` Soft Works
2021-12-18 17:59                           ` Daniel Cantarín
2021-12-18 15:41                     ` Daniel Cantarín

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git