From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B732F44BEC for ; Wed, 8 Feb 2023 13:55:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 133B768BE9E; Wed, 8 Feb 2023 15:55:33 +0200 (EET) Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C355068BAF5 for ; Wed, 8 Feb 2023 15:55:26 +0200 (EET) Received: by mail-il1-f173.google.com with SMTP id u8so7380632ilq.13 for ; Wed, 08 Feb 2023 05:55:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GSZv+yi8TppmCgXygYDNCEvELYwNWBgGUtt5E/QS/VM=; b=RUNVh0SYa8pKHdu+/O2wFWTUWJZiZU6MKAOWpibmDxwfjgFFsPTckDIeXMOpZmbf7e FEHQXaE905FckZS5QbeTgKiIAdaoLiYHx89zlyPDD95BWmlKh/E7vF7cpsMim3uIXcHv Zm61w+tFV6H105d6EcyQiXj9JYreffazJ1/N2CQ2tSeQgH+pGke+brAoDyKVEL89xjuQ 5DN8NZ5+IDOxdX2EFO4rWKhXimbRYTxsuj9qnsb5cXv45O4Z7yb5AXbA5p0gZcWOnmDI sXaGiXeNZ2RxzTdOhpzAxSUItFe/FppuTL8PWx6lr0L5pfIzYzVYSsPslRH0Kt5IbFiv iMdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GSZv+yi8TppmCgXygYDNCEvELYwNWBgGUtt5E/QS/VM=; b=y5hV4spfqsFxDYwoV95ZsgCHJ8ALKlRF7uRW4SpkCDPMnrVBdFuhvVpcP11xK8KYov +f0ioNO//sEtEvV5LyvteucGE1xnyaPO3iNzoz+E8VRa47XQaZ58KqPzImj8MhQWVLVR itUFGOXlk99p9lkKtu5KYFOjKqZGOkVHRBD2EmI2T+d1Q/mKrDw0DQ9Lc6qNtc7RzpYk 8b8smENhYSeHCqRQEIc6/OkrKLeCwoJZi6ei6ibj4VH0drh9zhXuxK/zExfSeM8TMWKg EsDlg5XAOXJz//f9L8YADl2unhSuXKVEvJmUBlco1eiXDu73R9Xh7EgKGfMQQlNuIJsl xh/Q== X-Gm-Message-State: AO0yUKVYSKjvW5RVDLSKQNtZXOSBDcWoo6uvdcvH5OIUjoMlwUq1mOdc qkF9jQfUwmqV3NTlA5u2XK2DvZAoCopvpA== X-Google-Smtp-Source: AK7set/AnnVpyUAhrGlgP/LMZn4hACjuDmtyLYVN7WLB7zKDaa2cYwHfJJh2Omm/80oDW3cMCSeV9A== X-Received: by 2002:a05:6e02:933:b0:313:c8b1:b88a with SMTP id o19-20020a056e02093300b00313c8b1b88amr4963796ilt.3.1675864525066; Wed, 08 Feb 2023 05:55:25 -0800 (PST) Received: from [192.168.1.35] (c-98-224-219-15.hsd1.mi.comcast.net. [98.224.219.15]) by smtp.gmail.com with ESMTPSA id z12-20020a92cd0c000000b0030ef5881a51sm1059272iln.34.2023.02.08.05.55.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 05:55:24 -0800 (PST) Message-ID: <42cdbf35-ee7e-631f-f853-bb55fa1799b1@gmail.com> Date: Wed, 8 Feb 2023 08:55:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US-large From: Leo Izen To: FFmpeg Development References: <20230202150938.22297-1-leo.izen@gmail.com> <20230202150938.22297-2-leo.izen@gmail.com> <0bf64cd1-dcfd-ce5e-1aba-a0aa47253600@gmail.com> In-Reply-To: <0bf64cd1-dcfd-ce5e-1aba-a0aa47253600@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/pngenc: avoid writing cICP when inappropriate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/7/23 14:17, Leo Izen wrote: > On 2/2/23 10:09, Leo Izen wrote: >> We parse the fallback cHRM on decode and correctly determine that we >> have BT.709 primaries, but unknown TRC. This causes us to write cICP >> where we shouldn't. Primaries without transfer can be handled entirely >> by cHRM, so we should only write cICP if we actually know the transfer >> function. >> >> Additionally, we should avoid writing cICP if there's an ICC profile >> because the spec says decoders must prioritize cICP over the ICC >> profile. >> > > Andreas has an issue with one of the other patches, but as this first > one is just a fix I'll apply it soon if there's no objections. > > - Leo Izen (thebombzen) Pushed just this one patch. The other two are still open for review. - Leo Izen (thebombzen) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".