From: Leo Izen <leo.izen@gmail.com>
To: FFmpeg Development <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/pngenc: avoid writing cICP when inappropriate
Date: Wed, 8 Feb 2023 08:55:24 -0500
Message-ID: <42cdbf35-ee7e-631f-f853-bb55fa1799b1@gmail.com> (raw)
In-Reply-To: <0bf64cd1-dcfd-ce5e-1aba-a0aa47253600@gmail.com>
On 2/7/23 14:17, Leo Izen wrote:
> On 2/2/23 10:09, Leo Izen wrote:
>> We parse the fallback cHRM on decode and correctly determine that we
>> have BT.709 primaries, but unknown TRC. This causes us to write cICP
>> where we shouldn't. Primaries without transfer can be handled entirely
>> by cHRM, so we should only write cICP if we actually know the transfer
>> function.
>>
>> Additionally, we should avoid writing cICP if there's an ICC profile
>> because the spec says decoders must prioritize cICP over the ICC
>> profile.
>>
>
> Andreas has an issue with one of the other patches, but as this first
> one is just a fix I'll apply it soon if there's no objections.
>
> - Leo Izen (thebombzen)
Pushed just this one patch. The other two are still open for review.
- Leo Izen (thebombzen)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-08 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 15:09 [FFmpeg-devel] [PATCH v3 0/3] PNG color tagging improvements Leo Izen
2023-02-02 15:09 ` [FFmpeg-devel] [PATCH v3 1/3] avcodec/pngenc: avoid writing cICP when inappropriate Leo Izen
2023-02-07 19:17 ` Leo Izen
2023-02-08 13:55 ` Leo Izen [this message]
2023-02-02 15:09 ` [FFmpeg-devel] [PATCH v3 2/3] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL Leo Izen
2023-02-05 3:47 ` Andreas Rheinhardt
2023-02-05 4:57 ` Leo Izen
2023-02-02 15:09 ` [FFmpeg-devel] [PATCH v3 3/3] avcodec/pngdec: populate enum transfer values from gAMA chunk Leo Izen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42cdbf35-ee7e-631f-f853-bb55fa1799b1@gmail.com \
--to=leo.izen@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git