From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1933849464 for ; Thu, 11 Apr 2024 21:07:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 98F7168D0F6; Fri, 12 Apr 2024 00:07:16 +0300 (EEST) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 37C1668C882 for ; Fri, 12 Apr 2024 00:07:10 +0300 (EEST) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5cfd95130c6so188790a12.1 for ; Thu, 11 Apr 2024 14:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712869627; x=1713474427; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=2fPfXc03XAaD2zrVgJgTi2KGA0Ij3v79Pe/z0MJHwRM=; b=fpRO3Zvt8qEyv3/Io6+OYJVQavep0jDPGHfPnEnsoYTVLbyeNDiUMAUci5rVnffe1p O1TJMc5RZeRN73sIyEx7BvjIF3wsZKjTwxpRBcL269LttquAGnoIAMXE58TFVZ1diah9 moeGlbRlRWke/9FU5vTH6aouIoLp769aR6PvSibrtHhvaJWfgEqIqlQ9oSU2Wb6HUHxf Gcrt5KimQozmRpPSyImdX9SJlvqRl1P518wQQsMhXk3s1C7gdvIoKCeVH7VfjX5AXfuQ 0CqZrkxv4jDZ72HkVRvWopVCZYFNao3lYdYuITJGgVVpFmH7tUX9S5quK/1EPP6ZSrAm Ix5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712869627; x=1713474427; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2fPfXc03XAaD2zrVgJgTi2KGA0Ij3v79Pe/z0MJHwRM=; b=XJeyjrrBs1OJDepNmkRMCVVe71s6HrOsyXJQgIAalcVjTT8hZ/+gY+b7T73UYftZD3 Wq6qjhb9c6LDBB0G6gjKvyFMqX3Ontp0cZx/hm55YwjOLWB1tC7cDP0/6b9WclC+hMfD dLVy0cIO48bgWgdpn2dLB67Ifpz16MXgKgzJXT3OAdjbbPhFthiO9+WdJ9H5DxQ19IeL 45FudrCnXjJ2wD7BYNcLfsG/n3ZzTK7dwJnc8tcMW50DUVnLEbwhd5lCGFhjgZFLZUOY pJ8/qiHLzq+LzSNrdsYc4lyMwlRdaHY67YYFXR0JU9TKzbPFMox2LQnxatALNUpZD9r0 t2Vg== X-Gm-Message-State: AOJu0Yym0EuzhHNHn7FbOw7gKXpfCUT3Irjy06/CG1ZxII1QTBS3xx+U nRQvtMaTUbdlkNrHAzHdTpCCsQXEE3GuHPazUSY6O1R0iENjY0qimOR/bw== X-Google-Smtp-Source: AGHT+IEZw/EBGV6hLxtr7YRus/upsbpjOjBy5k8UAtpBZncEtuvu4c/Gb4ignEDrNwbWfqpWXmMDHg== X-Received: by 2002:a17:902:d588:b0:1e4:48a6:968b with SMTP id k8-20020a170902d58800b001e448a6968bmr802356plh.13.1712869626869; Thu, 11 Apr 2024 14:07:06 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d15-20020a170903230f00b001d8be6d1ec4sm1615500plh.39.2024.04.11.14.07.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 14:07:06 -0700 (PDT) Message-ID: <42c48c2b-5bf5-4802-80f3-c36f4ff73e2c@gmail.com> Date: Thu, 11 Apr 2024 18:07:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240411154223.61774-1-jamrial@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avutil/frame: flag A53_CC side data type as allowing multiple entries X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/11/2024 5:17 PM, Kieran Kunhya wrote: > On Thu, 11 Apr 2024, 16:42 James Almer, wrote: > >> Some interlaced h264 samples may export one caption per field. >> >> Signed-off-by: James Almer >> --- >> libavutil/frame.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavutil/frame.c b/libavutil/frame.c >> index 0775e2abd9..fdac6f8ee2 100644 >> --- a/libavutil/frame.c >> +++ b/libavutil/frame.c >> @@ -30,7 +30,6 @@ >> >> static const AVSideDataDescriptor sd_props[] = { >> [AV_FRAME_DATA_PANSCAN] = { "AVPanScan" }, >> - [AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4 >> Closed Captions" }, >> [AV_FRAME_DATA_MATRIXENCODING] = { "AVMatrixEncoding" }, >> [AV_FRAME_DATA_DOWNMIX_INFO] = { "Metadata relevant to >> a downmix procedure" }, >> [AV_FRAME_DATA_AFD] = { "Active format >> description" }, >> @@ -55,6 +54,7 @@ static const AVSideDataDescriptor sd_props[] = { >> [AV_FRAME_DATA_AMBIENT_VIEWING_ENVIRONMENT] = { "Ambient viewing >> environment", AV_SIDE_DATA_PROP_GLOBAL }, >> [AV_FRAME_DATA_SPHERICAL] = { "Spherical Mapping", >> AV_SIDE_DATA_PROP_GLOBAL }, >> [AV_FRAME_DATA_ICC_PROFILE] = { "ICC profile", >> AV_SIDE_DATA_PROP_GLOBAL }, >> + [AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4 >> Closed Captions", AV_SIDE_DATA_PROP_MULTI }, >> [AV_FRAME_DATA_SEI_UNREGISTERED] = { "H.26[45] User Data >> Unregistered SEI message", AV_SIDE_DATA_PROP_MULTI }, >> }; >> >> -- >> 2.44.0 >> > > But we merge the captions into a single side data element, no? > > Kieran Oh, I must have misread how it was exported. Dropping this patch then. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".