From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6EAD140BB8 for ; Tue, 8 Mar 2022 07:47:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3F26168B1B8; Tue, 8 Mar 2022 09:47:29 +0200 (EET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 076AA6804DC for ; Tue, 8 Mar 2022 09:47:22 +0200 (EET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0018F5C023F for ; Tue, 8 Mar 2022 02:47:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 08 Mar 2022 02:47:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itanimul.li; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=xhyAf3cr+TnYo3 Cj+Q2eJxdfj4FKFwO3Eii3XAmTL+A=; b=dSkX7L7EadNrp/svbf7fw+YhW7ldo4 uoMoFHD6Nl/IrgsnRcWMd0Dl0gQzsKCC4iI1boEm9MpxzL3OI/1+t4/cFjfswZN8 8TSTH+NDcxQKLtMSRrsxsXXxZDjeekfl+NVlHaZkJbSFikS4JCA5NS2nE6k+1OUJ sldbjWdDjgdwN/iKaOUUjDq9Aam4kGJAlQ18MghZYseuy9GjnRPIWx4/vK6ry0sv 31filF3doVhqXCSSnqmviXARsh/YXkcfp5Z9SHtdxZmgWOACsxVKpWvDo2xi8UYz BgS1ZPwaCyTl7vFFlLGza6JlmRoG5CEfruYdZKTBAvXx3HxKtkW51kHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=xhyAf3cr+TnYo3Cj+Q2eJxdfj4FKFwO3Eii3XAmTL+A=; b=SALVwfwS h0Ee5YHh0DgX2FqyePJJbEoKxVuDvFD86qSPzQ/zfvNNwvpigDGlD/IZIZPTufVs IN7fhuEzxsEDJrM6p0mjJ24bI778BhT8Tq+rYO5uJQ6OZoNRkELMO9aQap9tSJQY 0qR8yXqd1t99qByP9oXkR5+aPd5tVjXYb1vRNh5Pt+ZYZ9rRZ6jHlzjUSRihJkOz bQ645m03SQcPqojI4Oh6prcNYMYeWkcoMU5xIUufH/F25024lfrKmbgg3zaXNW13 xVqMkhfKpceO3e6WeT23OGzoHuoBKgWydhooO5Lrh9VsVCKs+HVldOk3ijHz4yfS p7YNFBQw0e/jwQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudduhedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffokfgjfhggtgfgsehtqhhmtdertddtnecuhfhrohhmpedflfdr ucffvghkkhgvrhdfuceojhguvghksehithgrnhhimhhulhdrlhhiqeenucggtffrrghtth gvrhhnpedvgeeiveetvddttdfhgefgudeitedvhfduvdetveetgedugeevleeihfeitdel jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjug gvkhesihhtrghnihhmuhhlrdhlih X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 8 Mar 2022 02:47:19 -0500 (EST) From: "J. Dekker" To: FFmpeg development discussions and patches Date: Tue, 08 Mar 2022 08:47:17 +0100 X-Mailer: MailMate Trial (1.14r5852) Message-ID: <41C84D25-F6DF-4ED0-A173-E6142EF53373@itanimul.li> In-Reply-To: <20220305191642.GG2829255@pb2> References: <20220304150307.61769-1-ffmpeg@haasn.xyz> <20220304150307.61769-2-ffmpeg@haasn.xyz> <20220305191642.GG2829255@pb2> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavu/tests/opts: add tests for filepath options X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5 Mar 2022, at 20:16, Michael Niedermayer wrote: > On Fri, Mar 04, 2022 at 04:03:07PM +0100, Niklas Haas wrote: >> From: Niklas Haas >> >> Using the venerable HEADER.txt as a small file to load. >> --- >> libavutil/tests/opt.c | 38 +++++++++++++++++++++++++++++++++++++- >> tests/fate/libavutil.mak | 2 +- >> tests/ref/fate/opt | 4 ++++ >> 3 files changed, 42 insertions(+), 2 deletions(-) > > Please add tests which tries to load > id_rsa > ~/.ssh/id_rsa > shadow > /etc/shadow > .bash_history > ... > > The idea here is of course that such attempts fail There is absolutely no way we can or should try to implement a path based blacklist. Untrusted inputs should be sanitised externally by whichever script is being used to call ffmpeg. > Also document the security implications of this feature in > doc/APIchanges / release notes if there is a security implication > > Adjusting the parameters of most components could previously > not read arbitrary files so a application could previously > pass a string from a untrusted user to it. > If this changes it needs to be justfied and documented > If it doesnt change and its still safe that should be documented. > If it depends on whitelists and callbacks that should be actually implemented > in ffmpeg and the relevant examples > > And i do like this feature, if it can be done without security issues There aren't any extra security implications here, if a user is allowed to specify filter arguments themselves then they can already use the movie/amovie filter etc. This new option is just a way to unify the way in which filters which already (and will) require to load files can do so. -- J. Dekker _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".