From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 58C624A80C for ; Wed, 10 Apr 2024 09:18:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 743EF68C6E0; Wed, 10 Apr 2024 12:18:27 +0300 (EEST) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 74A6568CC2B for ; Wed, 10 Apr 2024 12:18:21 +0300 (EEST) Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-516d6898bebso5536656e87.3 for ; Wed, 10 Apr 2024 02:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1712740700; x=1713345500; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=DntWPw06+7IzD2rEfhza3eK+nf+h0dm/yeAZPrph4t4=; b=uAHr9fWFAmcIny3c8YlirvvOnwk80milRDG/6PGhOARB4Z9v4ftLn7N+ARnDQ2M20N TV1y8A2XIkiE7VOp9Kw7TpStKfy1rnz09GdqCCgvNjm9QBRwWN5luenm4CkUAbLBL/ns E0umalM4zWXP+jlvJcUAAqIG+3KnE1GyL9ZZ2j9Uzpa56W7z8WuRS/3yxa9+lMtM19AU e25mrb6nqF3M8ZbDhAGvuyZVSpt4mRmJzgvTjdNVSrU4IybbHUqwuqyCoeEkQ59BqVlX yYTHco67qABBlbhEV7AY902aZ0DAGAcfrGpIPslTz3amiYL6ai2vh3N02xLtHbPSm3eF bLpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712740700; x=1713345500; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DntWPw06+7IzD2rEfhza3eK+nf+h0dm/yeAZPrph4t4=; b=H9293afeZQFsyNYBqs55p+3mq15hk0+nqqT+9QNoDrN02KaCpGIUq1sBdC5Iek/wu/ WvM7m8cEjicA8yVeFb8RVwqKad1RwpvH6LuLJj/DxRBqzmFHRIi8gnFSG5m3BkMyJcbA TMyCo1fqNdORY27r+4uinAcm8ksqMIVVR7N9sQNwFNpCen80nTDpU64aCh2Bf9ukg3j/ lYGqzvQ1vwknshQ36i09X0wgCPk9BqIePUKScyiJeNHVrLz0KcTQ9uaPlMAvVjvGqYch AaxWwjQWjmdYi+JJcU9TN1ggplML/gqc0HO1CnLMkOIwgbddhvAw9Z9Vm9WdJy3x/8sb W1eg== X-Gm-Message-State: AOJu0YxXo8HTguir2xsE6soc4ZKRKYQfdxzg4vAcfiBgfYrTqpaaCD1I 0IxdgQUfqle6kzb1lPaWVDhbfzNJlNHSQTQE99uKuZOHeZwb38BOx2yEY0gZ2cloena68TAG0fp v/g== X-Google-Smtp-Source: AGHT+IE5V+IHW6v00U8eMkXxtjp5gTB7kZT4y6RRVtG9qbxrPdle7R0E2tz8j8wLJoKmSKcx96GEGA== X-Received: by 2002:ac2:596f:0:b0:516:c860:3c70 with SMTP id h15-20020ac2596f000000b00516c8603c70mr1054135lfp.57.1712740700495; Wed, 10 Apr 2024 02:18:20 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id w15-20020ac254af000000b00515939472e0sm1785777lfk.176.2024.04.10.02.18.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 02:18:20 -0700 (PDT) Date: Wed, 10 Apr 2024 12:18:18 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20240410084458.152389-1-jdek@itanimul.li> Message-ID: <4112ae65-41b1-63d7-2e32-434c1049ec@martin.st> References: <20240410084458.152389-1-jdek@itanimul.li> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2] tests/checkasm: add exclude_guest for non-x86 linux perf X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 10 Apr 2024, J. Dekker wrote: > The exclude_guest option only has an effect on x86. Omitting > 'exclude_guest' defaults to zero which implies that you can count guest > events should you run one. Some non-x86 kernels just ignore it, while > others (e.g. the Asahi Linux kernels) require the user to explicitly set > the option to 1, i.e. the only behaviour that makes sense when counting > guest events isn't supported. > > Signed-off-by: J. Dekker > --- > > Made commit message clearer, no functional change since v1. > > tests/checkasm/checkasm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c > index dcd2fd6957..8be6cb0f55 100644 > --- a/tests/checkasm/checkasm.c > +++ b/tests/checkasm/checkasm.c > @@ -742,6 +742,9 @@ static int bench_init_linux(void) > .disabled = 1, // start counting only on demand > .exclude_kernel = 1, > .exclude_hv = 1, > +#if !ARCH_X86 > + .exclude_guest = 1, > +#endif > }; > > printf("benchmarking with Linux Perf Monitoring API\n"); > -- > 2.44.0 Thanks, the updated commit message feels more readable to me at least. I'm not familiar with the perf API, but I tested perf on an aarch64 machine where perf benchmarking previously worked, and it still works after this change, so it seems ok. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".