From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4E3FD48CEA for ; Wed, 24 Jan 2024 13:39:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA56568D083; Wed, 24 Jan 2024 15:39:14 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DC639680BEC for ; Wed, 24 Jan 2024 15:39:07 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 40ODd6FX029213-40ODd6FY029213 for ; Wed, 24 Jan 2024 15:39:06 +0200 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id 9695EA1482 for ; Wed, 24 Jan 2024 15:39:06 +0200 (EET) Date: Wed, 24 Jan 2024 15:39:05 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20240124120634.84237-1-jdek@itanimul.li> Message-ID: <40f21059-551d-fc6c-ad19-cd5e21da76c0@martin.st> References: <20240124120634.84237-1-jdek@itanimul.li> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v2] checkasm/hevc_deblock: add luma and chroma full X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 24 Jan 2024, J. Dekker wrote: > Signed-off-by: J. Dekker > --- > tests/checkasm/hevc_deblock.c | 225 +++++++++++++++++++++++++++++----- > 1 file changed, 195 insertions(+), 30 deletions(-) > > - added luma 10/12 bit > - supporting full (*_c) luma & chroma functions > - dynamically generating all test data > > Appears to work for me. Testing on x86, hits the filtering decisions correctly. > x86 doesn't have the full asm functions though, need to check a platform which > has them (though the difference is minor, not sure why it wouldn't work). Looks mostly good, although I didn't test it myself. A couple of cosmetic comments below: > +#define RNDDIFF(val, diff) av_clip(((SIZEOF_PIXEL == 1) ? \ > + *(uint8_t*)(&val) : *(uint16_t*)(&val)) - (diff), 0, \ > + (1 << (bit_depth)) - 1) + rnd() % FFMAX(2 * (diff), 1) This macro is quite hard to read - can you indent it semantically based on nesting level or something like that? > +#define TC25(x) ((tc[x] * 5 + 1) >> 1); > + > +static void randomize_luma_buffers(int type, int *beta, int32_t tc[2], uint8_t *buf, ptrdiff_t xstride, ptrdiff_t ystride, int bit_depth) > +{ This one line is quite significantly longer than all the surrounding ones - can you wrap it? (Elsewhere, there are also a couple rather long lines, but they fit in better, but wrapping them is welcome too.) // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".