From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A5EE94767A for ; Tue, 19 Dec 2023 06:18:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9765368CFCB; Tue, 19 Dec 2023 08:18:39 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 08A3068CCBF for ; Tue, 19 Dec 2023 08:18:31 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702966718; x=1734502718; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=h5zdn4GDiW7DUYNEiVJn6IoxiNy3IFImXKBVN5hXexc=; b=nUcefN+lX+N94aYhwjWxNQMe1u5oLf6tQ/PkduLBUBwipwwB8mNZTbkO h5TpDmNBgs/VIsGHvb0jnIkpviBcwZnD3Tk6VGUzh6l7hrS36haQFflJM FB6VG/xDYEmvMFkhDgnlQF1pD0jXzMb4QDpK5iozJpugk41F1JebzY3yo 5zl6JhJwtkgb+iW3qBaQ8BfHVu7U8DGHqO4cKc2yJsMiOIMR/uZrigPab d2j95b1S/s+YopqCNgyar/qEmof1+6v2xRlpvjrWiXPBxFgh41ygEaIZq MOhSgheaULbFqkBldiaHRJRJavED3oHg5w+tM8KBc3iV0zZw03Gi3dfBf Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="14301576" X-IronPort-AV: E=Sophos;i="6.04,287,1695711600"; d="scan'208";a="14301576" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 22:18:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="775851999" X-IronPort-AV: E=Sophos;i="6.04,287,1695711600"; d="scan'208";a="775851999" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Dec 2023 22:18:29 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Dec 2023 22:18:28 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Dec 2023 22:18:28 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 18 Dec 2023 22:18:28 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 18 Dec 2023 22:18:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OcyoO2X3ldhCxFkeN3R2ZBCA5axXvg7ukPYZ+3XxXm7JH60OCi7DIUJhcK23BOYLNvsMp5zzqRXyA4hRtDPeZMwDMMOQPjN44757dwVq8kLwX3nGVPnct52j9tUb8SVK1u3F1ZTkv3RY8xGlCcNY4f5xzRKPXL7KifnNl2uykffuZRplZQiyjvgx6oWWzJe2ytTUvPlZSU4Gmse7NOGsxIcjxIsL34N7KTEAjLQg81yVnjsmooUj3PzVE3dNetJXxAcPvlW5YP3Vxig6/fba+pTrKI2be2ZSc+DvIUvEkKRIVvQJ563sDDL66Dop8qA596pruwV0hg/H5pWcC2l1NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h5zdn4GDiW7DUYNEiVJn6IoxiNy3IFImXKBVN5hXexc=; b=lP+onYGOzq1XZJTMaNcq/qroLfKh2ana1J+JybFBV1kPzwjjn53yQ42wFaA1JeAflyYSZ7PCWGrJSUSA0DewgWtQAdMQif1UEAdQM6+Zm0QvtsE1WTaw+ki9ORMFvMyeT4o5HB3ukQMO3LZjv51EDtyyGMA2V7yiGuqkL9dD4INeQmBGYukxEKKqhHc0h926OV9AvSzmGljwmcbp63uMKPme3y94lY80mdw36JF6UVgJblpTfsATz3+gi5uywLjSSOiQjKgOKI4rn2fl1w9A3ruuRf9Dgq6bC/Q+SQv+ozN1GWwBaDVes+1viKzK5LDlZPjcnkJafGaa223/ZGQh6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by MW4PR11MB7030.namprd11.prod.outlook.com (2603:10b6:303:22f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec 2023 06:18:25 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::43fa:28c3:7592:9f49]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::43fa:28c3:7592:9f49%4]) with mapi id 15.20.7091.034; Tue, 19 Dec 2023 06:18:25 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v1] lavc/vaapi_encode_av1: Add qp option explicitly to set base q index Thread-Index: AQHaITbGtkKs+2FlsUKj33tNSjaqRbCPD+yAgCE0M4A= Date: Tue, 19 Dec 2023 06:18:25 +0000 Message-ID: <40dde2858ac0b68f95822e3cdc924a1c2851389e.camel@intel.com> References: <20231127005801.3440746-1-fei.w.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|MW4PR11MB7030:EE_ x-ms-office365-filtering-correlation-id: c1c07e9b-6da8-4605-6208-08dc005a4f1e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AfoUkrPy1SwJPBJevmsshGVZvRvDxw6IgRzWPBlS8Wq/GqKp7C208DIsDhk8ajHMc8+wLE55FxtFLeddFHpmGTnEpCMT9G5J19VYNLM3qhp8A4R9y9R+QI+aZPssBjuy+Aqt5AT4eg1cFtXVKvMdEG5ZSr4A+yRrHVh2iCdGknDuw1CHYiXktWBj/B64q1W5aHiowUOU1YciBGKwKgw6BRT2YDIkgjAzSkVX6BOdAdh26OabExDU59yfW6aHPcCQCV1CSNGyFv5ZbyCa00GHxbcvZnyoWJqzXqUmkF7dE9EI4/9/6sqQ08VeiGSPNbEMI9WhFxWClYKHW0Vvf/esIufriOhN/PTJYDNpnpoE7nL4NTBQGXXbtEmNKD38utLBBsgXw4Yhk/4/YkF9hDe+pp5ohgrfLFMV1fXVMAzzlb/IahpdpHreEBf958f+n7ciVxKFLJBYKxLcMv6Yuh3DcqRmj8559I5M/qffhTwDmRLr+klaC7oUL88PQFm9z8dl/zbBFlYxaObu8fdeP6XJsKtw43MwMxa7iGzY0O+QGJaqLTI8mqx8Qhwks9JEtNxEIP0mestqHAOQ0M0fDwUUas52fsZsKH3e4Cn6/6SBhEc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(376002)(39860400002)(136003)(396003)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(66899024)(2616005)(26005)(82960400001)(86362001)(38100700002)(122000001)(36756003)(38070700009)(71200400001)(6512007)(83380400001)(5660300002)(53546011)(66946007)(8936002)(8676002)(66556008)(76116006)(316002)(6486002)(91956017)(66446008)(6916009)(64756008)(66476007)(2906002)(966005)(4001150100001)(41300700001)(478600001)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V2ttRGIvL1BuSkhGVVVQd1NCRnRhdVNRc2Mva2Y0MnM2U1ZucytUZ0pTZytv?= =?utf-8?B?ZCtIZVVOaUVzcEVsbTlOaG85Sng3aWJqU2dFdm8rLzh1bXo4WmE5K3Z3OHd3?= =?utf-8?B?eE1BRTA1QThHK0NsTUJNR0RDRWxPNU5CUngySUhHdURweXVTTEtsOEZKSHJq?= =?utf-8?B?Q1VtcGQvRDlwZEhodFhSQzE5enNQQnlKalhONllxdlYyQ0VTSkpZUjYwdzZ2?= =?utf-8?B?ZGdjekx2T0VMUzNiRmV6UnNjeEs2ZG5KUlRBYzUxTS8vd1gzWnpFV0NrTkx0?= =?utf-8?B?T1V3ZjRzYkdOSkkzaGJpS0ZVRGwydTlVejEvaGw1MFdvR05HcUkzRVNhKzgv?= =?utf-8?B?b2pzSWNqTlVleDhWcFd5NjQwRSsyUUFWSWNHSUlPVkFoek5XcFFYL0c4ZHJR?= =?utf-8?B?VkZGWC9idnFYVlJwdHFCRGtnVnNrYTdxSmc2bENVRThJOTB0akVtYXB5ZVhE?= =?utf-8?B?elFEL3l1R3YvODVCZk1WbG1MSWdzZy9QMjZHeGhBQktRK3J4OGFMb05OMWRM?= =?utf-8?B?UE1ReGVza1dTUlUvNHkvTlplNk1xTWlCY28vQ010OGR1NnVmSStEU2NLZmJ3?= =?utf-8?B?R0UzRGRzNTRITWpORWFnemhsT2lxYW5jYUlhdjNXOFVXcDU2bTFYbHJIYWUz?= =?utf-8?B?blRxR2ZERzFCQmJLRm9Xb3lUSTJURWttOWtMdW5XcUUwRGlRaGZNTGlaT2JZ?= =?utf-8?B?djFNRXBockZGenYySUErcFN1VkdRMEk4MFRZcndiUDh6dndrZnlzVlJOYVho?= =?utf-8?B?VldNejRXdTVQQ25Pb3dGa1piQjZYRkpuTEZQRmVZMDB3dnlRQndFZXcxZit6?= =?utf-8?B?c1YvbVhGL1QwNVQzS29rS0YxRmhWQnBISHArNVovN2UyQXZJeUI4WlNJY1o3?= =?utf-8?B?S0hFYkdReG9wZWtsVm5ERkVnbXY4MnhMMGRyVUxrS3h6NkE2QjV1aTdoUXJZ?= =?utf-8?B?eWd6cnYyUXNkVnhwZm8vQWJlR3pWUTVXZGFwdmcydzliSVh0N1pjL2JsT3lw?= =?utf-8?B?NnBZTXVjY0NFYzgvL1RQcllxYk5rYjhjRlI0bVUwcmRjVW51UWhWVHpwUWtv?= =?utf-8?B?bXJnRlNkdGRIZ1g5QytmdS9VR21MQWdjTDBvanJnNlA1dGFhQXZLa0FNcVAr?= =?utf-8?B?eWVOTXgwTzg0VThyV29mdEUvQ2JnUEkyQ1BLMnZ0b2R2cHFOdS9teUtoaUZ6?= =?utf-8?B?K0VJbzdISUxnRkJWL0V6bldEUkpMTVlRaFA3RnRIbE94NUl3bTZLdC9OVHMw?= =?utf-8?B?TndZakw3V1ZuODA3cFhMemNxQWZIZEttWTNJdms3blhYNW9PelF0QzlVc2hR?= =?utf-8?B?eC9GOVFqVFZBMHVaV29rOFBVdk9KVHRleWozWjBBNUVTNWR6WHhZZzJFMFZh?= =?utf-8?B?S1V4T3ltUVZRNGNLZ1hLdWJFWFh6UHNHR09IWXp4cmNRck5WVkg3eXJCRzZS?= =?utf-8?B?cE9RL1FhcjBSajlORUxETHFpL0FoMHlHbmhQRVMyWmg4M1N3b0pGTWxxQTN3?= =?utf-8?B?dmJ0QVpmRkd3d0o0Mll1Q3hFcVVUNzZaeVQ5VEhiU29Ka0JPRW05QlRzQkpE?= =?utf-8?B?ZUtrVzRzZ1pnRWlmbDdzU0ZtcEUwTkttbGFJMEE2bU5HOElzZjlkUm45UXBT?= =?utf-8?B?ajllS0RPSkhobld2L1JGUFlSSDhoUFhKem04ZGVyL0VxNE11aU1pLzBjazNU?= =?utf-8?B?c0RqaS9TRzcvcSs4SkFtMmw3YmFBN2RqMVVPRDg5TEYvd1RSaUh2YXFmMFpx?= =?utf-8?B?UGxTWXlFbFV3L1lJMmd3RmdwcktCSmFmWGowSTNRaEJ0dnFnNktEM2NSaXhD?= =?utf-8?B?KzN2eWVPWWtSdkRCUHliT2p1dkhjd2d6d1ArOUgwZ0o0TlZxQmM2Tnozajh2?= =?utf-8?B?cWM4WUdRRnFUQzd6bUhkY3RCRUpwZFhDSldNWVdaL3lDRFduZ2xXSzdtNTF4?= =?utf-8?B?TVhOU0Q5RktJd084d0NsNnI1SGJRbU9CbVgvSmRIcDNoejQ5Q0pnQmoyRHdl?= =?utf-8?B?MWpwaWR2MkI4dFJic1V3czRuSllvek1BNVFvdEFDY0JGQXBTYWpzeUVDdXFZ?= =?utf-8?B?RFY4UG5MU1lLQkVONFgyWkdOVnlmSVhFdjNPRHJxK3k5WjBCbHdRWDZ0b1h3?= =?utf-8?B?TEovcStWY2VUWmdJN1ZCS2ZoQ2ZTNzdhQkxjK1c3NWJFYVkzdmV6QnBab2kx?= =?utf-8?B?QkE9PQ==?= Content-ID: <3A838F90FD1EE345B71349474581A1F8@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1c07e9b-6da8-4605-6208-08dc005a4f1e X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2023 06:18:25.3798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 16JB/irMmQDPTUQv5tweSFTU69VswaT1FEuPX4Qb7dw9tH5EbJGZbR0q9poYlzkOtqpfrqYa1h7PjVMniOi8wA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7030 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v1] lavc/vaapi_encode_av1: Add qp option explicitly to set base q index X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2023-11-28 at 03:15 +0000, Xiang, Haihao wrote: > On Ma, 2023-11-27 at 13:36 +0000, Mark Thompson wrote: > > On 27/11/2023 00:58, fei.w.wang-at-intel.com@ffmpeg.org wrote: > > > From: Fei Wang > > > > > > Keep same way with librav1e/libsvtav1/qsv_av1.. to make it more > > > acceptable instead of using global option "-global_quality". > > > > > > Fix #10615 > > > > > > Signed-off-by: Fei Wang > > > --- > > > doc/encoders.texi | 1 + > > > libavcodec/vaapi_encode_av1.c | 6 ++++++ > > > 2 files changed, 7 insertions(+) > > > > > > diff --git a/doc/encoders.texi b/doc/encoders.texi > > > index 27a9acf076..2cffc32daf 100644 > > > --- a/doc/encoders.texi > > > +++ b/doc/encoders.texi > > > @@ -4079,6 +4079,7 @@ Each encoder also has its own specific > > > options: > > > @table @option > > > > > > @item av1_vaapi > > > +@option{qp} sets the value of @emph{base_q_index}. > > > @option{profile} sets the value of @emph{seq_profile}. > > > @option{tier} sets the value of @emph{seq_tier}. > > > @option{level} sets the value of @emph{seq_level_idx}. > > > diff --git a/libavcodec/vaapi_encode_av1.c > > > b/libavcodec/vaapi_encode_av1.c > > > index 5a9ff0f798..2e327fec5a 100644 > > > --- a/libavcodec/vaapi_encode_av1.c > > > +++ b/libavcodec/vaapi_encode_av1.c > > > @@ -79,6 +79,7 @@ typedef struct VAAPIEncodeAV1Context { > > > int cdef_param_size; > > > > > > /** user options */ > > > + int qp; > > > int profile; > > > int level; > > > int tier; > > > @@ -786,6 +787,9 @@ static av_cold int > > > vaapi_encode_av1_init(AVCodecContext > > > *avctx) > > > return AVERROR(EINVAL); > > > } > > > > > > + if (priv->qp > 0) > > > + ctx->explicit_qp = priv->qp; > > > + > > > ret = ff_vaapi_encode_init(avctx); > > > if (ret < 0) > > > return ret; > > > @@ -864,6 +868,8 @@ static av_cold int > > > vaapi_encode_av1_close(AVCodecContext > > > *avctx) > > > static const AVOption vaapi_encode_av1_options[] = { > > > VAAPI_ENCODE_COMMON_OPTIONS, > > > VAAPI_ENCODE_RC_OPTIONS, > > > + { "qp", "Base q index (for P-frames; scaled by > > > qfactor/qoffset for > > > I/B)", > > > + OFFSET(qp), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 255, FLAGS > > > }, > > > { "profile", "Set profile (seq_profile)", > > > OFFSET(profile), AV_OPT_TYPE_INT, > > > { .i64 = AV_PROFILE_UNKNOWN }, AV_PROFILE_UNKNOWN, 0xff, > > > FLAGS, > > > "profile" }, > > > > Disagree; QP is not a concept in AV1. > > Yes, it not a concept in AV1. > > nvenc h264/hevc/av1 encoders provide the same qp option: > > libavcodec/nvenc_av1.c: { "qp", "Constant quantization > parameter > rate control method", > libavcodec/nvenc_h264.c: { "qp", "Constant quantization > parameter > rate control method", > libavcodec/nvenc_hevc.c: { "qp", "Constant quantization > parameter > rate control method", > > May we provide the same qp option for vaapi h264/hevc/av1 encoders > too? User > will be able to use same options when using these encoders. > > Thanks > Haihao > > > > Further, your examples from other encoders do not have a > > consistent view of > > what it should mean. We may also assign different meaning for different VAAPI encoder in its individual option description. And it may be more reasonable to use "-qp" together with "-rc_mode CQP" and "-i/b_qfactor/qoffset" options. Thanks Fei > > > > librav1e.c: > > > > { "qp", "use constant quantizer mode", OFFSET(quantizer), > > AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 255, VE }, > > > > 0-255 is presumably the base_q_idx scale. > > > > libsvtav1.c: > > > > { "qp", "Initial Quantizer level value", OFFSET(qp), > > AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 63, VE }, > > > > 0-63 is presumably the H.26x-qp-ish scale used by some VP9/AV1 > > encoders which > > maps nonlinearly to the internal scale. > > > > qsv_av1 doesn't seem to have such an option. > > > > Thanks, > > > > - Mark > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".