From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 493F44BA37 for ; Wed, 10 Jul 2024 11:20:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AC8A868DA92; Wed, 10 Jul 2024 14:20:36 +0300 (EEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7451368D73F for ; Wed, 10 Jul 2024 14:20:30 +0300 (EEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-70afe18837cso3817889b3a.3 for ; Wed, 10 Jul 2024 04:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720610427; x=1721215227; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=rH8lihS2eqfA1gOtyre4cfZz4Or6OWzSxzMDJkhABtY=; b=kLqI+bpiRYn3gamFWZp2ZpQt4vlfGuNTJacQyh29k97R4HO2+r+VsrYNyVJFqwHDZU AErWPRzUIWo5cy3si/k5vjsuiBp1a9RfqmL1/6jZgxwJ4YKzIn7wqgI/UFW8hPJHK2B6 2sCb0wVi4VRtw0M9fChncSPQ/qQTBrR9/XHd7G3rF5qJEwGLov26EURjYjsbsGwHm7bD jrtBBVCkwRihx2wp7KtxZBfDc0aHIcWrTy7kyyV5TpGrp7kWARvk0OXPnq9dlgxaP/9+ aMg3TJiROFczcZwvILAWnwdSsudJdL4TO+mBRd0X+Q4DbTzZlrfPboJPm4Ip/zfWlAQa XNXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720610427; x=1721215227; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rH8lihS2eqfA1gOtyre4cfZz4Or6OWzSxzMDJkhABtY=; b=j5S5lT9touaheVyFcMgKm18u+iDGerhxih89X/4WourAX3WgB0IMezIBoYTw0SHUlD qafGlNhPR6Z+9SQMiHJZVm32kG53T5003Oz3q5b2orSierdtE7v887tnOTAoxog6zOw5 grh1CkZDLuvOsDPMwoRaDmeFT0c+40INo2bo1uB95qRTuiXRzRtj2TqQ7cAdR9BAo35S g854zseeRXRKTPmjPvFvJ2y+ULbXhLSTsv/ZWBKMIPJ1F8L+4bZPnZ70EC0FfFCA0091 LuEFXRn4bQ94KILjC1I7jU95ALEU69BuooC4TbJMyv8Usc2NP+vZn2G0gn5KB1vJ+LZ8 J8zA== X-Gm-Message-State: AOJu0YwQtUT/uMJkErnBPcQMdS+rKfNMMvXyHdVYZaymiAGEE5lbeQf1 XG8EAXezCRVgG2QWrw4MeuHf6n+QG5nR240pfMkQmNqYAIkqmUlKvzruuQ== X-Google-Smtp-Source: AGHT+IFGVJoY+ljy2xGIa4nzvPuibthZ9JB8oiy8gtxKg6V24BXG35hRno1sRsKxDLIz84KS909m6w== X-Received: by 2002:a05:6a20:438f:b0:1c2:9969:60e3 with SMTP id adf61e73a8af0-1c2996962e3mr4852754637.55.1720610427029; Wed, 10 Jul 2024 04:20:27 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6ac07f2sm31317625ad.194.2024.07.10.04.20.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 04:20:26 -0700 (PDT) Message-ID: <4062bae4-260f-4e2c-95ab-1d7ebbe982a8@gmail.com> Date: Wed, 10 Jul 2024 08:20:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240709190626.41550-1-jamrial@gmail.com> <172060017372.21847.14904279915340843501@lain.khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <172060017372.21847.14904279915340843501@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: set keep_aspect to true for the crop filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/10/2024 5:29 AM, Anton Khirnov wrote: > Quoting James Almer (2024-07-09 21:06:26) >> The input sample aspect ratio applies to the pre-cropping dimensions, so update it. > > I don't understand this reasoning, why should cropping a video change > pixel aspect ratio? You're right, this patch is not ok. I noticed the display aspect ratio was preserved with this option, but this is not intended by the container. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".