From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DAA8F424FD for ; Thu, 17 Mar 2022 19:46:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9B64468AEB5; Thu, 17 Mar 2022 21:46:35 +0200 (EET) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 27573687F96 for ; Thu, 17 Mar 2022 21:46:30 +0200 (EET) Received: by mail-ot1-f51.google.com with SMTP id w17-20020a056830111100b005b22c584b93so4196862otq.11 for ; Thu, 17 Mar 2022 12:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=XGkHfghpZhi/FMKyiVrWkG90VxdAK6NUNeemmQBQqRg=; b=fZWOmV9Wrl7/IKAXLpqO1eKSEbJPklRfbmgR/jMdJATVZWeIUyM/FHiWw2TCh0Ayy7 I7GeALIWZmTxIFN56QRUkjeyKR9YhIW0dhJ+1bLLHxsuMuHp/hnHeU5yE71cghJc3PUT yMHUeTJBnvaCQeh9AfbNq10a6WD9BwA8huFVyj9h947CXx09CQF79OzboVHTb8X6QEkM hklpnDHX4wDBTo6gRsaDMKy0Lv56fWfbAd+75+ix/QlBWXSXJY4ZW1/KyLu5sLjYRs+X yWLJiDdPC9R7bGlmtITru9aBrhu5pV3ULqq/ML9bWq7flB1m8oJdZ41btRjyekqebrxZ KJjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=XGkHfghpZhi/FMKyiVrWkG90VxdAK6NUNeemmQBQqRg=; b=SigbvnL6LhjhXhTQAJzHT2s3vYP8jJdEj65sx8549QplivOfkiofLW2eKHRuWN9LVw MNZQAsGVsRwkvCYZZ2MEAtkhKgAielHY+794GPWrFQhr+4s8kqt1FhkgEZmEjCJgSuLu EfVdLr2o9nKbTJJB/1+3/9CZQujiChx7dT8Im9TNgs2smIoMIPXiVDdg7P8BdPqs04RB qYTAm/a/eiMueKXuJGX4VK2IdU2bTQ8Ag6NbMU2UuPrtp311DIErRpi8wL1s/xznvrcB bS4HS3vyekbwaZmv6c3+3hvC2qbOtV+zMTlv3xKe8YewTdFAGfuUndVB9FvXl79tyVqm DnYg== X-Gm-Message-State: AOAM533g+fY+MOyXgm9kccGdbUnEDsnqW7s9TfoOXnn/zuFsxeoU9/z6 4zhLZIwNGz8xkukawHgEqc/xyI1XXOecyQ== X-Google-Smtp-Source: ABdhPJyn9H3ItfW3eAMUj0WwnH1C3LRr//0BHB8ObPZN37vzDjKdCdqpoKrf4fLQXKyXw0ofVt5AOg== X-Received: by 2002:a05:6830:1f49:b0:5b2:5c16:3dd1 with SMTP id u9-20020a0568301f4900b005b25c163dd1mr2205747oth.207.1647546388216; Thu, 17 Mar 2022 12:46:28 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id r19-20020acaa813000000b002ed02ca6a3fsm2929594oie.1.2022.03.17.12.46.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Mar 2022 12:46:27 -0700 (PDT) Message-ID: <4048bc0f-9a75-1b3c-6f47-ac4f78fe2e0e@gmail.com> Date: Thu, 17 Mar 2022 16:46:26 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220124204656.48625-1-jamrial@gmail.com> <20220316004108.GH2829255@pb2> <20220317193918.GQ2829255@pb2> From: James Almer In-Reply-To: <20220317193918.GQ2829255@pb2> Subject: Re: [FFmpeg-devel] [PATCH 001/293 v8] avutil/channel_layout: Add a new channel layout API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/17/2022 4:39 PM, Michael Niedermayer wrote: > On Tue, Mar 15, 2022 at 11:00:02PM -0300, James Almer wrote: >> On 3/15/2022 9:41 PM, Michael Niedermayer wrote: >>> On Mon, Jan 24, 2022 at 05:46:56PM -0300, James Almer wrote: >>>> From: Anton Khirnov >>>> >>>> The new API is more extensible and allows for custom layouts. >>>> More accurate information is exported, eg for decoders that do not >>>> set a channel layout, lavc will not make one up for them. >>>> >>>> Deprecate the old API working with just uint64_t bitmasks. >>>> >>>> Expanded and completed by Vittorio Giovara >>>> and James Almer . >>>> Signed-off-by: Vittorio Giovara >>>> Signed-off-by: James Almer >>>> --- >>>> Changes since last version: >>>> >>>> *Both av_channel_layout_describe() and av_channel_layout_from_string() now >>>> support a "2 channels (FL+LFE)" syntax, to signal native (usually >>>> non-standard) or custom order layouts. >>>> *a single decimal value is now interpreted as a mask by >>>> av_channel_layout_from_string(), same as a single hexadecimal value. >>>> *De-duplicated code by simplifying av_channel_layout_channel_from_string(). >>>> >>>> The entire set can still be found in >>>> https://github.com/jamrial/FFmpeg/commits/channel_layout4 >>>> >>>> libavutil/channel_layout.c | 661 +++++++++++++++++++++++++++++++++---- >>>> libavutil/channel_layout.h | 551 +++++++++++++++++++++++++++++-- >>>> libavutil/version.h | 1 + >>>> 3 files changed, 1110 insertions(+), 103 deletions(-) >>> >>> didnt bisect but >>> >>> this >>> ./ffmpeg -i ~/tickets/3542/out.mov -channel_layout stereo -acodec pcm_s16be file.mov >>> fails after the patchset but not before >>> >>> [graph_0_in_0_0 @ 0x5642d659ec40] filter context - fmt: s16 r: 44100 layout: 3 ch: 2, incoming frame - fmt: s16 r: 44100 layout: 60000000 ch: 2 pts_time: 0 >>> [graph_0_in_0_0 @ 0x5642d659ec40] Changing audio frame properties on the fly is not supported. >>> Error while filtering: Invalid argument >>> Failed to inject frame into filter network: Invalid argument >>> Error while processing the decoded data for stream #0:0 >>> Conversion failed! >> >> Should be fixed. > > Heres another which broke around the channel change > ./ffmpeg -i tickets//2064/mus_sympathy_for_the_devil_l.wav file.wav > > "tickets//2064/mus_sympathy_for_the_devil_l.wav: Function not implemented" > > file seems here: > https://www.djxmmx.net/ffmpeg/2064/ What was this file read as before the set? Ticket 2064 mentions a file with a wav extension that's an "unknown container", and then the ticket was closed as fixed without referencing a commit. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".