From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B7CF049F5B for ; Fri, 15 Mar 2024 09:33:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 24AE668D0E0; Fri, 15 Mar 2024 11:33:53 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D5BEF68D04F for ; Fri, 15 Mar 2024 11:33:46 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 42F9XjwT004250-42F9XjwU004250; Fri, 15 Mar 2024 11:33:45 +0200 Received: from cone.home.martin.st (host-114-191.parnet.fi [77.234.114.191]) by mail9.parnet.fi (Postfix) with ESMTPS id 56CF6A1467; Fri, 15 Mar 2024 11:33:45 +0200 (EET) Date: Fri, 15 Mar 2024 11:33:44 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <403d1cd2-37a-773d-1c1e-dbb03b7d36a@martin.st> References: MIME-Version: 1.0 X-FEAS-Client-IP: 77.234.108.21 X-FE-Last-Public-Client-IP: 77.234.108.21 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH] configure: Remove av_restrict X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 10 Mar 2024, Andreas Rheinhardt wrote: > All versions of MSVC that support C11 (namely >= v19.27) > also support the restrict keyword, therefore av_restrict > is no longer necessary since 75697836b1db3e0f0a3b7061be6be28d00c675a0. > > Signed-off-by: Andreas Rheinhardt > --- > Untested except via godbolt. > MSVC actually uses it for optimizations: https://godbolt.org/z/3EzPnff9T This change looks good overall, thanks! Fate runs successfully both with an old version of MSVC targeting x86_64 and a new one targeting aarch64. However, MSVC 19.27 (aka 2019 16.7) can't successfully build ffmpeg at the moment - it regressed in ec1b6e0cd404b2f7f4d202802b1c0a40d52fc9b0. Now building fails with this error: src/libavcodec/ccaption_dec.c(186): error C2143: syntax error: missing ')' before 'sizeof' src/libavcodec/ccaption_dec.c(186): error C2143: syntax error: missing '{' before 'sizeof' src/libavcodec/ccaption_dec.c(186): error C2059: syntax error: 'sizeof' This issue is not present with the following version, MSVC 2019 16.8 (aka 19.28) though. > Btw: The block about __declspec(restrict) was always unneeded > for FFmpeg due to 17fad33f81c7e9787fcdc17934fc1eee6c6aa4bf. > It came from Libav commit 17fad33f81c7e9787fcdc17934fc1eee6c6aa4bf. This looks like a copypaste typo, I presume the latter should have been 0cff125200ab53fa3ae70d85b4f614f269fe3426. (The code it changed originated in dfa559bcbd41397b3408c59d016631c7c65e320f in libav.) // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".