* [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion
@ 2024-01-29 5:00 Gyan Doshi
2024-02-02 10:04 ` Gyan Doshi
0 siblings, 1 reply; 3+ messages in thread
From: Gyan Doshi @ 2024-01-29 5:00 UTC (permalink / raw)
To: ffmpeg-devel
Existing use of strtoll can lead to ERANGE errors leading to incorrect
storage of UMID.
---
libavformat/wavenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c
index 82acb9ef0f..a41f40b449 100644
--- a/libavformat/wavenc.c
+++ b/libavformat/wavenc.c
@@ -129,7 +129,7 @@ static void bwf_write_bext_chunk(AVFormatContext *s)
for (i = 0; i < len/16; i++) {
memcpy(umidpart_str, tmp_tag->value + 2 + (i*16), 16);
- umidpart = strtoll(umidpart_str, NULL, 16);
+ umidpart = strtoull(umidpart_str, NULL, 16);
avio_wb64(s->pb, umidpart);
}
ffio_fill(s->pb, 0, 64 - i*8);
--
2.39.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion
2024-01-29 5:00 [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion Gyan Doshi
@ 2024-02-02 10:04 ` Gyan Doshi
2024-02-04 9:17 ` Gyan Doshi
0 siblings, 1 reply; 3+ messages in thread
From: Gyan Doshi @ 2024-02-02 10:04 UTC (permalink / raw)
To: ffmpeg-devel
On 2024-01-29 10:30 am, Gyan Doshi wrote:
> Existing use of strtoll can lead to ERANGE errors leading to incorrect
> storage of UMID.
Plan to push tomorrow.
Regards,
Gyan
> ---
> libavformat/wavenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c
> index 82acb9ef0f..a41f40b449 100644
> --- a/libavformat/wavenc.c
> +++ b/libavformat/wavenc.c
> @@ -129,7 +129,7 @@ static void bwf_write_bext_chunk(AVFormatContext *s)
>
> for (i = 0; i < len/16; i++) {
> memcpy(umidpart_str, tmp_tag->value + 2 + (i*16), 16);
> - umidpart = strtoll(umidpart_str, NULL, 16);
> + umidpart = strtoull(umidpart_str, NULL, 16);
> avio_wb64(s->pb, umidpart);
> }
> ffio_fill(s->pb, 0, 64 - i*8);
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion
2024-02-02 10:04 ` Gyan Doshi
@ 2024-02-04 9:17 ` Gyan Doshi
0 siblings, 0 replies; 3+ messages in thread
From: Gyan Doshi @ 2024-02-04 9:17 UTC (permalink / raw)
To: ffmpeg-devel
On 2024-02-02 03:34 pm, Gyan Doshi wrote:
>
>
> On 2024-01-29 10:30 am, Gyan Doshi wrote:
>> Existing use of strtoll can lead to ERANGE errors leading to incorrect
>> storage of UMID.
>
> Plan to push tomorrow.
Pushed as 7375a6ca7b4a4b223a71f85a772c64a34e60eabe
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-04 9:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-29 5:00 [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion Gyan Doshi
2024-02-02 10:04 ` Gyan Doshi
2024-02-04 9:17 ` Gyan Doshi
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git