From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8AE0E40187 for ; Fri, 3 Feb 2023 04:23:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7DD1668BE88; Fri, 3 Feb 2023 06:22:58 +0200 (EET) Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6EE4D68B5DB for ; Fri, 3 Feb 2023 06:22:52 +0200 (EET) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4P7MvY6XZQz9sW6 for ; Fri, 3 Feb 2023 05:22:49 +0100 (CET) Message-ID: <4039d916-a926-de54-7346-ea20c40c6043@gyani.pro> Date: Fri, 3 Feb 2023 09:52:36 +0530 MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org References: <20230202180642.3479-1-ffmpeg@gyani.pro> Content-Language: en-US From: Gyan Doshi In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avformat/tee: signal EOF if no more output is to be published. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2023-02-03 04:17 am, Marton Balint wrote: > > > On Thu, 2 Feb 2023, Gyan Doshi wrote: > >> Prior to 2d924b3a630, ffmpeg.c would exit if any packet write failed. >> tee's >> write_packet seemingly relied on that to enforce its abort failure >> policy. >>> From 2d924b3a630, ffmpeg only closes that OutputStream and keeps on >> sending packets of other streams. > > Hmm, are you sure? I glanced at the code and it seems to me that any > failure of av_interleaved_write_frame() will cause the muxing thread > to exit. So I don't quite see how other streams can receive packets. Steps to reproduce: 1) ffmpeg -readrate 1 -stream_loop -1 -i INPUT -map 0:v -map 0:a -c copy -f tee "[f=flv:onfail=abort]rtmp://url/playpath|[f=null:onfail=ignore]stub" 2) Kill the rtmp endpoint at the server side. The tee muxer logs that it's aborting, however, ffmpeg keeps running. Contrast with 5.1 or earlier, which exit. av_iwf returns EOF which just results in a call to tq_receive_finish() for that ost without breaking muxer_thread's loop. Reards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".