From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6029F40095 for ; Sun, 18 May 2025 14:21:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 973F768D7CF; Sun, 18 May 2025 17:21:44 +0300 (EEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 6DAC868D7B2 for ; Sun, 18 May 2025 17:21:38 +0300 (EEST) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43cf680d351so26976205e9.0 for ; Sun, 18 May 2025 07:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1747578098; x=1748182898; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BjY6dsxGknVymdziORXb0KKmhC5KBzs9VMqmKp7ODNU=; b=U3u8ZNAt/oDCs+R7/xjW6ONOfWtSy0gVFqNrWhL75IXGSonMNe+8RLx4zlz48PcCfF /uxAVRrF68Jb5hDdUl/vRmrN8juK148lmyWVUc6x4fJrGdIuxlk/HC/DQwdOEF8ymn7n rMXTy0VT3sOyZxYn/B33gMaaFXy9c1kUsKQ2stNhi/84AHyKIbTJ9SE21yTjfAiF1TqL k9VoAIcOPrNQb9xJ0/FDOVV0Qs0RRZPYJTjfCFy7NMhMy9O7wK68iQSTb9+mVZAVIOHy IakFIkuIyw0ZvMsCu5HZT16RpF1x19TSmClk5EtlfzYdr19mkRKlNF2TCzbZo+2BRynr yJdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747578098; x=1748182898; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BjY6dsxGknVymdziORXb0KKmhC5KBzs9VMqmKp7ODNU=; b=MrE+ntxaJmXyAbtHiStpmzhH15KDH2AJnEoopQxLeMv3SN8BFywPNKJFuc8ttn3+WO ERPwJHqrHyAqtgkBtgiMI3HUWppqMHFawtnWsywKljPUmGIMu0zuvWbJlJYdPaE0lS/Q vMFlUKCasqro2PuX/AP5hSgq9HFWL4EdlKFSeqgjWcbeOeA1nHbLPD1nabM9oN8oVsjk 34fWcM+LojFnMJGwhLRXbsSh649gULlyoPP/jIXsaV/HpmGD+yXVgS+nCZjLmeClsyum NPArtc9jPKUdKvH0bfMH5OeJODFanwzscpqKVbuLsNl6Rgb2isNgRwiKRU8KOzXyYBw3 U4EQ== X-Gm-Message-State: AOJu0Yy3hOMQuev1aVu7/XVntmdxb0Oo79qER3yvVNa4elYUpzDNFwHw JhNOuE0S+/0OB+elTk940xDaIKgII0X/SKwcVjn2uHq9wyyfoqzw9Ct+Dzo1x4KVfQubw7bIjrI lPXqsQCqjgA== X-Gm-Gg: ASbGncu31XwCHm/EmfU+dffk90fboCUq5tbRb6DB7XWBzxKS7Q54eyZ6reBybZXCibp JHC0kxLN7tQaVQb3KdaFsmsP2tqaQ6xniTE2p3vj3TqPkqIuf43Zjr7CsFDY43ALMmWdT8iwops QB+wxugYsRc2A+fkWEQVUEjGnJ2sCo1v9MLBNvS1znDO32lTP8ctyFe3yveB76G9GrZiZBnZXRT tS5ANUmIObLIpWGaye69LQKppNDSR5sEMHBivPxqWhg+uyDu9M71uwx8cqWRDLyI2k/83gXlI+k RtDhRhQh+DcWNSntu03KtL2KH6Jew5VBiFUuwFDRtBx9t/1CPp/rurJQaZfmfrnfYNNSkKiS705 7Mbcgk38/CaI5P/9/jptJx7kp X-Google-Smtp-Source: AGHT+IEJ2xFJUbfIxODKL31sIT1zFPle+mkz+gDP5Xct/6SWC1dzZWq5UzqYl9JHnf1dL+SdGZP0Jw== X-Received: by 2002:a5d:5f94:0:b0:3a0:92d9:dbf with SMTP id ffacd0b85a97d-3a35ca76607mr8500352f8f.3.1747578097668; Sun, 18 May 2025 07:21:37 -0700 (PDT) Received: from [192.168.0.15] (cpc92320-cmbg19-2-0-cust719.5-4.cable.virginm.net. [82.13.66.208]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca5beccsm9642025f8f.36.2025.05.18.07.21.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 May 2025 07:21:37 -0700 (PDT) Message-ID: <40001c07-a1ac-4075-8c8c-da684461c82e@jkqxz.net> Date: Sun, 18 May 2025 15:21:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20250517200227.3454348-1-sw@jkqxz.net> From: Mark Thompson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2] ffmpeg: Don't print graphs if there are no outputs yet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 17/05/2025 21:04, softworkz . wrote: >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of Mark >> Thompson >> Sent: Samstag, 17. Mai 2025 22:02 >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH v2] ffmpeg: Don't print graphs if there are no >> outputs yet >> >> Avoids writing an empty json blob in setup error cases. >> --- >> On 17/05/2025 20:08, softworkz . wrote: >>> If you could resubmit without the nb_filtergraphs check that would be fine! >> >> Sure, here. >> >> Thanks, >> >> - Mark >> >> fftools/ffmpeg.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c >> index 964770df23..bd6f22e421 100644 >> --- a/fftools/ffmpeg.c >> +++ b/fftools/ffmpeg.c >> @@ -309,7 +309,7 @@ const AVIOInterruptCB int_cb = { decode_interrupt_cb, NULL >> }; >> >> static void ffmpeg_cleanup(int ret) >> { >> - if (print_graphs || print_graphs_file) >> + if ((print_graphs || print_graphs_file) && nb_output_files > 0) >> print_filtergraphs(filtergraphs, nb_filtergraphs, input_files, >> nb_input_files, output_files, nb_output_files); >> >> if (do_benchmark) { >> -- > > Excellent, thanks a lot for reviewing the feature! > > LGTM Set applied. Suggest doing any non-performance-critical development (like this) with asan enabled in future; it doesn't slow things down very much and makes it easier to catch and fix leaks as you go along. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".