Re: [FFmpeg-devel] [PATCH v2] ffmpeg: Don't print graphs if there are no outputs yet

[Mark Thompson <sw@jkqxz.net>]

On 17/05/2025 21:04, softworkz . wrote:
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Mark
>> Thompson
>> Sent: Samstag, 17. Mai 2025 22:02
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: [FFmpeg-devel] [PATCH v2] ffmpeg: Don't print graphs if there are no
>> outputs yet
>>
>> Avoids writing an empty json blob in setup error cases.
>> ---
>> On 17/05/2025 20:08, softworkz . wrote:
>>> If you could resubmit without the nb_filtergraphs check that would be fine!
>>
>> Sure, here.
>>
>> Thanks,
>>
>> - Mark
>>
>>  fftools/ffmpeg.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
>> index 964770df23..bd6f22e421 100644
>> --- a/fftools/ffmpeg.c
>> +++ b/fftools/ffmpeg.c
>> @@ -309,7 +309,7 @@ const AVIOInterruptCB int_cb = { decode_interrupt_cb, NULL
>> };
>>
>>  static void ffmpeg_cleanup(int ret)
>>  {
>> -    if (print_graphs || print_graphs_file)
>> +    if ((print_graphs || print_graphs_file) && nb_output_files > 0)
>>          print_filtergraphs(filtergraphs, nb_filtergraphs, input_files,
>> nb_input_files, output_files, nb_output_files);
>>
>>      if (do_benchmark) {
>> --
> 
> Excellent, thanks a lot for reviewing the feature!
> 
> LGTM
Set applied.

Suggest doing any non-performance-critical development (like this) with asan enabled in future; it doesn't slow things down very much and makes it easier to catch and fix leaks as you go along.

Thanks,

- Mark

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".