From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B573943DAE for ; Wed, 10 Aug 2022 22:56:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3C0C868B8EF; Thu, 11 Aug 2022 01:55:59 +0300 (EEST) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5DDF968B4EC for ; Thu, 11 Aug 2022 01:55:53 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 0B5852F6E90 for ; Thu, 11 Aug 2022 00:55:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1660172153; bh=3XZvS4aHIveiKDEAe3c1B//JAtGykabLBDTTcujFimc=; h=Date:Subject:To:References:From:In-Reply-To; b=VRjslXeTH4oB0CK2m9Lkds88pDF1Idx9fkPWJEXWbwVmYysBqMq9SfKJB01FbZnxu X4ZGLYGVsTUXeoFCerBESmkgoA4Fu4IQtngEvenUSP+8KnOaqeMgPcLm87q7p9cB4X pb6Spu6sXvfs3+h3kRUlHkLaUwFSkBAMgfa8pPbNzk5TZWlMQVffvW9kMfgcfhD62U BERfCnYSWwPyks1fsngBaGTmoGHtXp2okYBwcu0RCE3kgRoMgicX2XJGho7Qs6zo0f yvjKCzsKqXf+y9I+iWtBeHq/DgfVBKYSCgGzb7GXCBZsCjBdagqzDAt9hwe4eFsNoD r23Xv0aLeeTXg== Message-ID: <3ff257f1-dcbc-543e-21d6-50e62d8f879d@rothenpieler.org> Date: Thu, 11 Aug 2022 00:55:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220810204712.3123-1-timo@rothenpieler.org> <20220810204712.3123-6-timo@rothenpieler.org> <423b2beb-9ad6-003e-be31-e3237f9f9788@rothenpieler.org> <9f390e60-6243-115c-ca11-81d2fc3d43e9@rothenpieler.org> From: Timo Rothenpieler In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 06/11] avutil/half2float: adjust conversion of NaN X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11.08.2022 00:37, Mark Reid wrote: > On Wed, Aug 10, 2022 at 3:28 PM Timo Rothenpieler > wrote: > >> On 11.08.2022 00:18, James Almer wrote: >>> Then maybe the current implementation should be moved back to exr (it >>> used to be internal to exr until Paul made it standalone), so this lavu >>> module can match the existing hardware implementations of IEEE-734 half >>> floats for the purpose of relevant pixel format support. >> >> That doesn't seem necessary to me. >> The values produced before and now are both correct, just different. >> But there is no functional difference in the values it produces. >> >> Duplicating the entirety of that code just for that seems extremely >> unnecessary. >> > > openexr does note the intel implementations difference here > https://github.com/AcademySoftwareFoundation/Imath/blob/main/src/Imath/half.h#L288 It's actually quite curious how that came to be. My natural idea would be that our current and EXRs code does it right. But all hardware as well as gccs software emulation agrees. Makes me wonder if it's fully intentional and according to some spec. But I couldn't find anything on the matter. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".